-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Generic script crate #21371
base: main
Are you sure you want to change the base?
[WIP] Generic script crate #21371
Conversation
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon. |
Heads up! This PR modifies the following files:
|
@bors-servo try |
[WIP] Generic script crate Separation is based on adding types to TypeHolderTrait which contains associated types with traits that script crate actually needs. This allows using static methods and Sized types. Affects servo in two ways: - generic structs do not compile in script crate but are left for later monomorphization - dom_structs itself are moved to separate crate TODO: - [ ] tests - [ ] performance - [ ] polyshing Fixes #1799 r? @jdm <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #1799 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21371) <!-- Reviewable:end -->
💔 Test failed - linux-rel-css |
Results from local measurements using non-incremental builds: master: PR: |
Results from local measurements using incremental builds: master: PR: |
☔ The latest upstream changes (presumably #20678) made this pull request unmergeable. Please resolve the merge conflicts. |
e668042
to
0723a3c
Compare
540bef5
to
57d5567
Compare
@retep007 Does this PR contain the most recent changes you have been making? I might try to keep investigating this week. |
@jdm It contains all latest changes, however I can rebase it for you. Also I don't really know how to solve the ICE problem, no response from rust-lang so far. Those const functions are used to generate const variables and one of them can't be replaced so easily. |
Ah, that's good to know. Have you tried making duplicating the function and making a non-const version? |
Last static fn which I wasn't able to remove is |
I'm not sure I understand - what's the problem with Guard::new, exactly? |
Separation is based on adding types to TypeHolderTrait which contains associated types with traits that script crate actually needs. This allows using static methods and Sized types. Affects servo in two ways: - generic structs does not compile in script crate, but are left for later monomorphization - dom_structs itself are moved to separate crate TODO: - [] tests - [] performance - [] polyshing
57d5567
to
ee0b2e0
Compare
@jdm I solved the |
Separation is based on adding types to TypeHolderTrait which contains
associated types with traits that script crate actually needs. This allows
using static methods and Sized types.
Affects servo in two ways:
TODO:
Fixes #1799
r? @jdm
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is