Fix Windows nightly build #21545

ferjm · 2018-08-30T16:44:30Z

This change is

highfive · 2018-08-30T16:44:34Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/package_commands.py

ferjm · 2018-08-30T16:45:00Z

This patch tries to include the merge modules provided by GStreamer in Servo's MSI installer.

Unfortunately, it is currently failing during mach package with a bunch of errors like:

light.exe : error LGHT0204 : ICE80: This 32BitComponent _libgstapp.dll.D9626750_E8B7_4E40_944D_98B67ED0C6BF uses 64BitDirectory _gstreamer_1.0.D9626750_E8B

Which is a bit confusing, as I am downloading the merge modules from https://gstreamer.freedesktop.org/data/pkg/windows/1.14.2/gstreamer-1.0-x86_64-1.14.2-merge-modules.zip, which are supposed to be for 64 bits (?). (FWIW I tried with the 32 bits version as well with the same result).

file says the following for libgstapp.dll:

/Users/ferjm/Downloads/libgstapp.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows

There are also a bunch of warnings like:

light.exe : warning LGHT1076 : ICE03: String overflow (greater than length permitted in column); Table: Component, Column: Component, Key(s): _adaptive__video__framerate.scenario.44786CC0_8CCC_11E8_B956_10C37B6AFE07

The installer is generated anyway and after execution the application folder contains a few new dirs:

 Directory of C:\Program Files\Mozilla Research\Servo Tech Demo
08/30/2018  05:55 PM    <DIR>          .
08/30/2018  05:55 PM    <DIR>          ..
08/30/2018  05:55 PM    <DIR>          bin
08/30/2018  05:54 PM    <DIR>          etc
08/30/2018  05:54 PM    <DIR>          include
08/30/2018  05:54 PM    <DIR>          lib
08/30/2018  05:45 PM         2,386,944 libcryptoMD.dll
08/30/2018  05:54 PM    <DIR>          libexec
08/30/2018  05:45 PM           489,984 libsslMD.dll
08/30/2018  05:55 PM    <DIR>          resources
08/30/2018  12:09 PM        70,460,416 servo.exe
08/30/2018  05:54 PM    <DIR>          share

Inside lib there are many .dll files. But unfortunately running Servo still throws the errors mentioned in #21414 about the missing .dll files.

The generated wxs file looks like this:

<?xml version="1.0" encoding="utf-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
  <Product Id="*"
           Name="Servo Tech Demo"
           Manufacturer="Mozilla Research"
           UpgradeCode="060cd15d-eab1-4614-b438-3988e3efdcf1"
           Language="1033"
           Codepage="1252"
           Version="1.0.0">
    <Package Id="*"
             Keywords="Installer"
             Description="Servo Tech Demo Installer"
             Manufacturer="Mozilla Research"
             InstallerVersion="200"
             Platform="x64"
             Languages="1033"
             SummaryCodepage="1252"
             Compressed="yes"/>
    <MajorUpgrade AllowDowngrades="yes"/>
    <Media Id="1"
           Cabinet="Servo.cab"
           EmbedCab="yes"/>
    <Directory Id="TARGETDIR" Name="SourceDir">
      <Directory Id="ProgramFiles64Folder" Name="PFiles">
        <Directory Id="MozResearch" Name="Mozilla Research">
          <Directory Id="INSTALLDIR" Name="Servo Tech Demo">
            <Component Id="Servo"
                       Guid="95bcea71-78bb-4ec8-9766-44bc01443840"
                       Win64="yes">
              <File Id="ServoEXE"
                    Name="servo.exe"
                    DiskId="1"
                    Source="C:\Users\harpo\servo\target\release\servo.exe"
                    KeyPath="yes">
                <Shortcut Id="StartMenuServoTechDemo"
                          Directory="ProgramMenuDir"
                          Name="Servo Tech Demo"
                          WorkingDirectory="INSTALLDIR"
                          Icon="servo.exe"
                          Advertise="yes"/>
              </File>
             
              <File Id="IdlibcryptoMDdll"
                    Name="libcryptoMD.dll"
                    Source="C:\Users\harpo\servo\target\release\msi\temp\servo\libcryptoMD.dll"
                    DiskId="1"/>
              <File Id="IdlibsslMDdll"
                    Name="libsslMD.dll"
                    Source="C:\Users\harpo\servo\target\release\msi\temp\servo\libsslMD.dll"
                    DiskId="1"/>
            </Component>
           
        <Merge Id="Idbase_crypto_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\base-crypto-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idbase_system_10_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\base-system-1.0-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_capture_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-capture-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_codecs_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-codecs-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_codecs_gpl_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-codecs-gpl-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_codecs_restricted_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-codecs-restricted-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_core_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-core-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_devtools_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-devtools-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_dvd_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-dvd-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_editing_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-editing-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_effects_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-effects-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_encoding_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-encoding-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_libav_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-libav-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_net_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-net-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_net_restricted_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-net-restricted-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_playback_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-playback-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_system_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-system-1.14.2-x86_64.msm"
               DiskId="1"/>
        <Merge Id="Idgstreamer_10_visualizers_1142_x86_64msm"
               Language="1033"
               SourceFile="C:\Users\harpo\servo\target\release\msi\temp\servo\msm\gstreamer-1.0-visualizers-1.14.2-x86_64.msm"
               DiskId="1"/>

           
<Directory Id="Idresources" Name="resources">
  <Component Id="Idresources"
             Guid="5700f161-1bef-4089-b7af-a2d8771b3399"
             Win64="yes">
    <CreateFolder/>
   
    <File Id="Id_resources_ahem.css"
          Name="ahem.css"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\ahem.css"
          DiskId="1"/>
    <File Id="Id_resources_android_params"
          Name="android_params"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\android_params"
          DiskId="1"/>
    <File Id="Id_resources_badcert.html"
          Name="badcert.html"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\badcert.html"
          DiskId="1"/>
    <File Id="Id_resources_badcert.jpg"
          Name="badcert.jpg"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\badcert.jpg"
          DiskId="1"/>
    <File Id="Id_resources_cert_google_only"
          Name="cert-google-only"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\cert-google-only"
          DiskId="1"/>
    <File Id="Id_resources_certs"
          Name="certs"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\certs"
          DiskId="1"/>
    <File Id="Id_resources_Credits.rtf.mako"
          Name="Credits.rtf.mako"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\Credits.rtf.mako"
          DiskId="1"/>
    <File Id="Id_resources_gatt_blocklist.txt"
          Name="gatt_blocklist.txt"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\gatt_blocklist.txt"
          DiskId="1"/>
    <File Id="Id_resources_hsts_preload.json"
          Name="hsts_preload.json"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\hsts_preload.json"
          DiskId="1"/>
    <File Id="Id_resources_iso_8859_8.css"
          Name="iso-8859-8.css"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\iso-8859-8.css"
          DiskId="1"/>
    <File Id="Id_resources_neterror.html"
          Name="neterror.html"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\neterror.html"
          DiskId="1"/>
    <File Id="Id_resources_not_found.html"
          Name="not-found.html"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\not-found.html"
          DiskId="1"/>
    <File Id="Id_resources_prefs.json"
          Name="prefs.json"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\prefs.json"
          DiskId="1"/>
    <File Id="Id_resources_presentational_hints.css"
          Name="presentational-hints.css"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\presentational-hints.css"
          DiskId="1"/>
    <File Id="Id_resources_privatekey_for_testing.key"
          Name="privatekey_for_testing.key"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\privatekey_for_testing.key"
          DiskId="1"/>
    <File Id="Id_resources_public_domains.txt"
          Name="public_domains.txt"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\public_domains.txt"
          DiskId="1"/>
    <File Id="Id_resources_quirks_mode.css"
          Name="quirks-mode.css"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\quirks-mode.css"
          DiskId="1"/>
    <File Id="Id_resources_quotes.css"
          Name="quotes.css"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\quotes.css"
          DiskId="1"/>
    <File Id="Id_resources_rippy.png"
          Name="rippy.png"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\rippy.png"
          DiskId="1"/>
    <File Id="Id_resources_self_signed_certificate_for_testing.crt"
          Name="self_signed_certificate_for_testing.crt"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\self_signed_certificate_for_testing.crt"
          DiskId="1"/>
    <File Id="Id_resources_servo.css"
          Name="servo.css"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\servo.css"
          DiskId="1"/>
    <File Id="Id_resources_servo.icns"
          Name="servo.icns"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\servo.icns"
          DiskId="1"/>
    <File Id="Id_resources_Servo.ico"
          Name="Servo.ico"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\Servo.ico"
          DiskId="1"/>
    <File Id="Id_resources_servo.png"
          Name="servo.png"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\servo.png"
          DiskId="1"/>
    <File Id="Id_resources_servo.svg"
          Name="servo.svg"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\servo.svg"
          DiskId="1"/>
    <File Id="Id_resources_servo64.png"
          Name="servo64.png"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\servo64.png"
          DiskId="1"/>
    <File Id="Id_resources_tumbeast.png"
          Name="tumbeast.png"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\tumbeast.png"
          DiskId="1"/>
    <File Id="Id_resources_user_agent.css"
          Name="user-agent.css"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\user-agent.css"
          DiskId="1"/>
  </Component>
 
<Directory Id="Idahem" Name="ahem">
  <Component Id="Idahem"
             Guid="0bb19733-98aa-408a-8f10-53cfd93a1bb8"
             Win64="yes">
    <CreateFolder/>
   
    <File Id="Id_resources_ahem_Ahem.ps"
          Name="Ahem.ps"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\ahem\Ahem.ps"
          DiskId="1"/>
    <File Id="Id_resources_ahem_Ahem.sit"
          Name="Ahem.sit"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\ahem\Ahem.sit"
          DiskId="1"/>
    <File Id="Id_resources_ahem_AHEM____.TTF"
          Name="AHEM____.TTF"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\ahem\AHEM____.TTF"
          DiskId="1"/>
    <File Id="Id_resources_ahem_COPIED_FROM"
          Name="COPIED-FROM"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\ahem\COPIED-FROM"
          DiskId="1"/>
    <File Id="Id_resources_ahem_COPYING"
          Name="COPYING"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\ahem\COPYING"
          DiskId="1"/>
    <File Id="Id_resources_ahem_README"
          Name="README"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\ahem\README"
          DiskId="1"/>
  </Component>
</Directory>
 
<Directory Id="Iduser_agent_js" Name="user-agent-js">
  <Component Id="Iduser_agent_js"
             Guid="cd66a0d5-a0be-4f55-b4c4-f15d938ff084"
             Win64="yes">
    <CreateFolder/>
   
    <File Id="Id_resources_user_agent_js_00.example.js"
          Name="00.example.js"
          Source="C:\Users\harpo\servo\target\release\msi\temp\servo\resources\user-agent-js\00.example.js"
          DiskId="1"/>
  </Component>
</Directory>
</Directory>
          </Directory>
        </Directory>
      </Directory>
      <Directory Id="ProgramMenuFolder" Name="Programs">
        <Directory Id="ProgramMenuDir" Name="Servo Tech Demo">
          <Component Id="ProgramMenuDir" Guid="e04737ce-16eb-4977-9b4c-ed2db8a5a77d">
            <RemoveFolder Id="ProgramMenuDir" On="both"/>
            <RegistryValue Root="HKCU"
                           Key="Software\Mozilla Research\Servo Tech Demo"
                           Type="string"
                           Value=""
                           KeyPath="yes"/>
          </Component>
        </Directory>
      </Directory>
    </Directory>
    <Feature Id="Complete" Level="1">
      <ComponentRef Id="Servo"/>
      <ComponentRef Id="Idresources"/>
      <ComponentRef Id="Idahem"/>
      <ComponentRef Id="Iduser_agent_js"/>
      <ComponentRef Id="ProgramMenuDir"/>
     
        <MergeRef Id="Idbase_crypto_1142_x86_64msm"/>
        <MergeRef Id="Idbase_system_10_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_capture_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_codecs_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_codecs_gpl_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_codecs_restricted_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_core_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_devtools_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_dvd_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_editing_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_effects_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_encoding_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_libav_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_net_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_net_restricted_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_playback_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_system_1142_x86_64msm"/>
        <MergeRef Id="Idgstreamer_10_visualizers_1142_x86_64msm"/>
    </Feature>
    <Icon Id="servo.exe" SourceFile="C:\Users\harpo\servo\target\release\servo.exe"/>
  </Product>
</Wix>

@Manishearth @larsbergstrom I could use some help here :)

NiLSPACE · 2018-08-31T09:27:23Z

Which is a bit confusing, as I am downloading the merge modules from https://gstreamer.freedesktop.org/data/pkg/windows/1.14.2/gstreamer-1.0-x86_64-1.14.2-merge-modules.zip

I don't know if it matters, but according to GStreamer-rs' readme it uses GStreamer v1.12.3: https://github.com/sdroege/gstreamer-rs#gstreamer-binaries-1

ferjm · 2018-08-31T16:40:31Z

I don't know if it matters, but according to GStreamer-rs' readme it uses GStreamer v1.12.3: https://github.com/sdroege/gstreamer-rs#gstreamer-binaries-1

Thanks for your comment. I assume that the .msi file names described in the readme are just an example (note the e.g.) and that that's not the only possible version, probably just the current one at the time the readme was edited.

That said, it may be worth trying with different binaries.

ferjm · 2018-09-03T15:12:52Z

I changed the approach here. Instead of using merge modules I chose to do the "Shared GStreamer" option as described in GStreamer docs, where we bundle the GStreamer installer inside Servo's installer.

With the current patch, I don't get the missing GStreamer dlls error anymore. I am still seeing the one about the missing nspr4.dll though.

Manishearth · 2018-09-03T15:33:34Z

Hmm. Does the regular servo installer built with gstreamer disabled work for you? I don't see why gstreamer would need nspr (maybe post-upgrade mozjs does?)

…

On Mon, Sep 3, 2018, 8:43 PM Fernando Jiménez Moreno < ***@***.***> wrote: I changed the approach here. Instead of using merge modules I chose to do the "Shared GStreamer" option as described in GStreamer docs <https://gstreamer.freedesktop.org/documentation/deploying/windows.html>, where we bundle the GStreamer installer inside Servo's installer. With the current patch, I don't get the missing GStreamer dlls error anymore. I am still seeing the one about the missing nspr4.dll though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21545 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABivSBVUUNl0Tt_8-DhUcrs1I-PMEHtTks5uXUb-gaJpZM4WT1lv> .

ferjm · 2018-09-03T15:42:01Z

I haven't tried disabling GStreamer, but I can confirm that this comes from mozjs. We generate this dll while building mozjs_sys, so we can get it from there.

I tried moving it manually into Servo's installation folder and it fixes the missing dll issue. Unfortunately, that one does not seem to be the last issue. Now Servo is opening and immediately closing without loading anything or providing any ouput or error message :_(

Manishearth · 2018-09-03T15:43:40Z

Looks like the spidermonkey upgrade (or some other change) _also_ broke the installer :) (We should probably periodically test these things on fresh VMs)

…

On Mon, Sep 3, 2018, 9:12 PM Fernando Jiménez Moreno < ***@***.***> wrote: I haven't tried disabling GStreamer, but I can confirm that this comes from mozjs. We generate this dll while building mozjs_sys, so we can get it from there. I tried moving it manually into Servo's installation folder and it fixes the missing dll issue. Unfortunately, that one does not seem to be the last issue. Now Servo is opening and immediately closing without loading anything or providing any ouput or error message :_( — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21545 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABivSIFbJTlRRfop2-DL54fdTEhzpyqYks5uXU3SgaJpZM4WT1lv> .

ferjm · 2018-09-06T07:16:36Z

I confirmed again that the missing nspr4.dll plus the weird crash without any error output is still happening with a build with GStreamer disabled on Windows. That proves that this PR should suffice to fix the GStreamer related errors.

I am trying to get additional information about the crash, but unfortunately I'm currently unable to create dev builds on Windows #21604

Manishearth · 2018-09-06T09:14:49Z

r=me

cc @larsbergstrom is this method of packaging consistent with the license? We are shipping the gstreamer MSI in the bundle, but it's still dynamically linked

larsbergstrom · 2018-09-06T13:08:31Z

@Manishearth Yes. Our only restrictions with LGPL code and packaging are around not linking it statically into the code.

That said, we may have some license disclosure rules that we should look into as a follow-up issue. i.e., we may need to plunk a LICENSES file into the toplevel of our installation.

Manishearth · 2018-09-06T13:28:05Z

Looks ready to land then (unless you want to plop in the LICENSE file now)

Needs tidy fixes:

./python/servo/package_commands.py:358: E703 statement ends with a semicolon
./python/servo/package_commands.py:359: E703 statement ends with a semicolon
./python/servo/package_commands.py:370: F841 local variable 'dir_to_bundle_msi' is assigned to but never used
./python/servo/package_commands.py:364: Line is longer than 120 characters

ferjm · 2018-09-06T13:41:11Z

The BootstrapperApplication that I used is showing a Lorem Ipsum as End User License Agreement by default. We may want to provide our own EULA or try to use a different bootstrapper without EULA before merging as well.

CC @jdm

ferjm · 2018-09-11T15:53:07Z

a56dc48 fixes the missing nspr4.dll error.

ferjm · 2018-09-11T16:24:33Z

r? @Manishearth for the additional commit fixing the nspr4.dll error.

If you are ok with this last change, I think we are good here and we can merge it as is. We can add the LICENSES and EULA later.

Manishearth · 2018-09-11T16:38:59Z

@bors r+

Manishearth · 2018-09-11T16:40:31Z

Travis has a "can't find crate fontsan" error, which seems weird?

Manishearth · 2018-09-11T16:41:06Z

@bors r-

Let's retrigger travis first. r=me if travis is passing

ferjm · 2018-09-11T16:42:06Z

Travis has a "can't find crate fontsan" error, which seems weird?

Does not seem to be related. It's been happening for the last few builds https://travis-ci.org/servo/servo/builds

(You probably want to use @bors-servo here :P )

ferjm · 2018-09-11T16:46:42Z

I filed #21677 for that

Manishearth · 2018-09-11T16:46:44Z

@bors r+

Manishearth · 2018-09-11T16:48:08Z

@bors-servo r+

bors-servo · 2018-09-11T16:48:09Z

📋 Looks like this PR is still in progress, ignoring approval

ferjm · 2018-09-11T16:51:46Z

@bors-servo r=Manishearth

bors-servo · 2018-09-11T16:51:46Z

📌 Commit 8416061 has been approved by Manishearth

bors-servo · 2018-09-11T19:00:57Z

⌛ Testing commit 8416061 with merge c1d567b...

Fix Windows nightly build  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21545)

bors-servo · 2018-09-11T20:07:33Z

💔 Test failed - windows-msvc-dev

ferjm · 2018-09-12T07:42:15Z

@bors-servo r=Manishearth

bors-servo · 2018-09-12T07:42:16Z

📌 Commit 3c5c01a has been approved by Manishearth

bors-servo · 2018-09-12T07:42:21Z

⌛ Testing commit 3c5c01a with merge 4c4c251...

Fix Windows nightly build  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21545)

bors-servo · 2018-09-12T08:10:12Z

💔 Test failed - linux-rel-wpt

ferjm · 2018-09-12T08:54:08Z

@bors-servo retry

bors-servo · 2018-09-12T08:54:13Z

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css1, mac-rel-wpt1...

bors-servo · 2018-09-12T09:48:29Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing 4c4c251 to master...

highfive assigned paulrouget Aug 30, 2018

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 30, 2018

ferjm force-pushed the windows.nightly.gst.fix branch from 1b2d8aa to 100fd89 Compare September 3, 2018 15:06

ferjm added 3 commits September 11, 2018 17:43

Create bundle with GStreamer and Servo installers

c3ed1d1

Package generated nspr4.dll

a56dc48

Make tidy happy

8416061

ferjm force-pushed the windows.nightly.gst.fix branch from 100fd89 to 8416061 Compare September 11, 2018 15:52

highfive assigned Manishearth and unassigned paulrouget Sep 11, 2018

ferjm changed the title ~~[WIP] Fix Windows nightly build~~ Fix Windows nightly build Sep 11, 2018

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 11, 2018

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 11, 2018

Move gstreamer msi to msi folder after download

3c5c01a

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 12, 2018

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 12, 2018

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 12, 2018

bors-servo merged commit 3c5c01a into servo:master Sep 12, 2018

ferjm deleted the windows.nightly.gst.fix branch September 12, 2018 09:56

atouchet mentioned this pull request Sep 13, 2018

Windows nightly build is broken since gstreamer addition and spidermonkey upgrade #21414

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Windows nightly build #21545

Fix Windows nightly build #21545

ferjm commented Aug 30, 2018 •

edited by SimonSapin

Loading

highfive commented Aug 30, 2018

ferjm commented Aug 30, 2018

NiLSPACE commented Aug 31, 2018

ferjm commented Aug 31, 2018

ferjm commented Sep 3, 2018

Manishearth commented Sep 3, 2018 via email

ferjm commented Sep 3, 2018

Manishearth commented Sep 3, 2018 via email

ferjm commented Sep 6, 2018

Manishearth commented Sep 6, 2018

larsbergstrom commented Sep 6, 2018

Manishearth commented Sep 6, 2018

ferjm commented Sep 6, 2018

ferjm commented Sep 11, 2018

ferjm commented Sep 11, 2018

Manishearth commented Sep 11, 2018

Manishearth commented Sep 11, 2018

Manishearth commented Sep 11, 2018

ferjm commented Sep 11, 2018

ferjm commented Sep 11, 2018

Manishearth commented Sep 11, 2018

Manishearth commented Sep 11, 2018

bors-servo commented Sep 11, 2018

ferjm commented Sep 11, 2018

bors-servo commented Sep 11, 2018

bors-servo commented Sep 11, 2018

bors-servo commented Sep 11, 2018

ferjm commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

ferjm commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

Fix Windows nightly build #21545

Fix Windows nightly build #21545

Conversation

ferjm commented Aug 30, 2018 • edited by SimonSapin Loading

highfive commented Aug 30, 2018

ferjm commented Aug 30, 2018

NiLSPACE commented Aug 31, 2018

ferjm commented Aug 31, 2018

ferjm commented Sep 3, 2018

Manishearth commented Sep 3, 2018 via email

ferjm commented Sep 3, 2018

Manishearth commented Sep 3, 2018 via email

ferjm commented Sep 6, 2018

Manishearth commented Sep 6, 2018

larsbergstrom commented Sep 6, 2018

Manishearth commented Sep 6, 2018

ferjm commented Sep 6, 2018

ferjm commented Sep 11, 2018

ferjm commented Sep 11, 2018

Manishearth commented Sep 11, 2018

Manishearth commented Sep 11, 2018

Manishearth commented Sep 11, 2018

ferjm commented Sep 11, 2018

ferjm commented Sep 11, 2018

Manishearth commented Sep 11, 2018

Manishearth commented Sep 11, 2018

bors-servo commented Sep 11, 2018

ferjm commented Sep 11, 2018

bors-servo commented Sep 11, 2018

bors-servo commented Sep 11, 2018

bors-servo commented Sep 11, 2018

ferjm commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

ferjm commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

ferjm commented Aug 30, 2018 •

edited by SimonSapin

Loading