Improve border images #21608

pyfisch · 2018-09-04T19:22:08Z

Respect CSS border-image-width.
Properly support gradients as a border-image-source.

Add a new test and mark two more as passing.

This change is

highfive · 2018-09-04T19:22:12Z

Heads up! This PR modifies the following files:

@emilio: components/layout/display_list/builder.rs, components/layout/display_list/background.rs

highfive · 2018-09-04T19:22:14Z

Warning

These commits modify layout code, but no tests are modified. Please consider adding a test!

pyfisch · 2018-09-04T19:24:05Z

@bors-servo try=wpt

WIP Improve border gradients and images  ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21608)

bors-servo · 2018-09-04T19:24:11Z

⌛ Trying commit fc17b38 with merge 777e001...

bors-servo · 2018-09-04T19:52:57Z

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

jdm · 2018-09-10T23:28:50Z

@pyfisch Is this still WIP or is it waiting on review?

pyfisch · 2018-09-11T05:57:29Z

It is still WIP because I have not written tests for the changes. (This needs to test at least: * Specifying a border-image-width has the same effect as a border-width. * If the border-width is 0 there is still a border-image displayed. * border-image-outset can be replaced by a bigger box. ) Josh Matthews <notifications@github.com> schrieb am Di., 11. Sep. 2018, 01:29:

…

@pyfisch <https://github.com/pyfisch> Is this still WIP or is it waiting on review? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21608 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACpvWSKK87gqSEPLwfg2Qr_OHsLq2kgqks5uZvW8gaJpZM4WZmjB> .

servo-wpt-sync · 2018-09-11T14:26:21Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#83.

pyfisch · 2018-09-11T14:29:52Z

@bors-servo try=wpt

@jdm this is ready for review. Added a test for the first two points. The third is covered already by border-image-outset-003.

Note that I just removed the check border-width == 0 and early return. This could be considered to be a performance regression but I did not want to bother right now with writing a correct early return statement.

jdm · 2018-09-11T14:42:27Z

@bors-servo try=wpt

bors-servo · 2018-09-11T15:12:50Z

⌛ Trying commit 9a18f33 with merge 3484a7e...

Improve border images Respect CSS border-image-width. Properly support gradients as a border-image-source. Add a new test and mark two more as passing.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21608)

bors-servo · 2018-09-11T15:28:17Z

💔 Test failed - linux-rel-css

servo-wpt-sync · 2018-09-12T06:03:50Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#83.

pyfisch · 2018-09-12T06:06:37Z

Update. Mark two paint worklet tests as passing.

#17860 was referenced by the tests. Property border-image-outset is now implemented but css-paint-api/geometry-border-image-004.html still fails.

I deemed {"status": "CRASH", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/syntax/parsing/html5lib_tests9.html?run_type=uri", "line": 98391, "action": "test_result", "expected": "OK"}to be intermittent.

pyfisch · 2018-09-12T06:18:30Z

@bors-servo try=wpt

bors-servo · 2018-09-12T06:18:37Z

⌛ Trying commit ab34be1 with merge 22e1679...

Improve border images Respect CSS border-image-width. Properly support gradients as a border-image-source. Add a new test and mark two more as passing.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21608)

bors-servo · 2018-09-12T06:44:26Z

💔 Test failed - linux-rel-wpt

pyfisch · 2018-09-27T21:03:59Z

Error syncing changes upstream. Logs saved in error-snapshot-1538082026475.

@jdm This may interest you.

jdm · 2018-09-27T21:41:51Z

Yep. Could you do another force push with no meaningful changes? I want to see if it will open a PR in the proper place now.

ghost · 2018-09-28T06:58:22Z

No Taskcluster jobs started for this pull request

The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

servo-wpt-sync · 2018-09-28T06:58:24Z

Error syncing changes upstream. Logs saved in error-snapshot-1538117948500.

pyfisch · 2018-09-28T06:59:39Z

Force pushed.

jdm · 2018-09-28T13:06:45Z

Ok, force pushing again should work.

emilio

Looks great with or without the nit addressed.

emilio · 2018-09-28T14:09:23Z

components/layout/display_list/builder.rs

+        let mut height = border_image_area.height.to_px() as u32;
+        let source = match image {
+            Image::Url(ref image_url) => {
+                let image = image_url.url().and_then(|url| {


nit: Given you're doing ? at the end you may as well:

let url = image_url.url()?; let image = state.layout_context.get_webrender_image_for_url( self.node, url.clone(), UsePlaceholder::No, )?; // ...

emilio · 2018-09-28T14:10:31Z

@bors-servo delegate+

bors-servo · 2018-09-28T14:10:32Z

✌️ @pyfisch can now approve this pull request

Additionally if an image border can't be displayed show solid border. Introduce build_display_list_for_border_image to display border images.

servo-wpt-sync · 2018-09-28T20:34:29Z

Error syncing changes upstream. Logs saved in error-snapshot-1538166914642.

pyfisch · 2018-09-28T20:36:49Z

@bors-servo r=emilio

@jdm servo-wpt-sync failed again...

bors-servo · 2018-09-28T20:36:50Z

📌 Commit 60d0c8c has been approved by emilio

bors-servo · 2018-09-28T20:36:57Z

⌛ Testing commit 60d0c8c with merge 97e3c5f...

Improve border images Respect CSS border-image-width. Properly support gradients as a border-image-source. Add a new test and mark two more as passing.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21608)

bors-servo · 2018-09-28T21:27:08Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: emilio
Pushing 97e3c5f to master...

servo-wpt-sync · 2018-09-28T21:27:29Z

Error syncing changes upstream. Logs saved in error-snapshot-1538170094369.

jdm · 2018-09-28T21:28:26Z

Ok. I know what went wrong, and I'll perform a manual sync.

Respect CSS border-image-width. Properly support gradients as a border-image-source. Only emit a border item if the border-width is non-zero for simple borders but still emit one if the item is an image as paint worklet that are not drawn cause servo to hang and fail tests. Add a new test and mark 4 more as passing. Upstreamed from servo/servo#21608 [ci skip]

Additionally if an image border can't be displayed show solid border. Introduce build_display_list_for_border_image to display border images. Upstreamed from servo/servo#21608 [ci skip]

highfive assigned ferjm Sep 4, 2018

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 4, 2018

pyfisch mentioned this pull request Sep 4, 2018

Rendering of border-gradients is broken servo/webrender#3015

Open

pyfisch force-pushed the border-gradients branch from fc17b38 to 9a18f33 Compare September 11, 2018 14:25

pyfisch changed the title ~~WIP Improve border gradients and images~~ Improve border images Sep 11, 2018

servo-wpt-sync mentioned this pull request Sep 11, 2018

WIP Improve border gradients and images jdm/web-platform-tests#83

Closed

highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 11, 2018

pyfisch force-pushed the border-gradients branch from 9a18f33 to ab34be1 Compare September 12, 2018 06:03

highfive removed the S-tests-failed The changes caused existing tests to fail. label Sep 12, 2018

highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 12, 2018

pyfisch force-pushed the border-gradients branch from 35f354f to d60d564 Compare September 28, 2018 06:58

emilio approved these changes Sep 28, 2018

View reviewed changes

Layout: stylistic changes

60d0c8c

Additionally if an image border can't be displayed show solid border. Introduce build_display_list_for_border_image to display border images.

pyfisch force-pushed the border-gradients branch from d60d564 to 60d0c8c Compare September 28, 2018 20:34

highfive assigned emilio and unassigned ferjm Sep 28, 2018

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 28, 2018

bors-servo merged commit 60d0c8c into servo:master Sep 28, 2018

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 28, 2018

servo-wpt-sync mentioned this pull request Sep 28, 2018

Improve border images web-platform-tests/wpt#13267

Merged

servo-wpt-sync mentioned this pull request Sep 28, 2018

Layout: stylistic changes web-platform-tests/wpt#13268

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve border images #21608

Improve border images #21608

pyfisch commented Sep 4, 2018 •

edited by SimonSapin

Loading

highfive commented Sep 4, 2018

highfive commented Sep 4, 2018

pyfisch commented Sep 4, 2018

bors-servo commented Sep 4, 2018

bors-servo commented Sep 4, 2018

jdm commented Sep 10, 2018

pyfisch commented Sep 11, 2018 via email

servo-wpt-sync commented Sep 11, 2018

pyfisch commented Sep 11, 2018

jdm commented Sep 11, 2018

bors-servo commented Sep 11, 2018

bors-servo commented Sep 11, 2018

servo-wpt-sync commented Sep 12, 2018

pyfisch commented Sep 12, 2018 •

edited

Loading

pyfisch commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

pyfisch commented Sep 27, 2018

jdm commented Sep 27, 2018

ghost commented Sep 28, 2018

servo-wpt-sync commented Sep 28, 2018

pyfisch commented Sep 28, 2018

jdm commented Sep 28, 2018

emilio left a comment

emilio Sep 28, 2018

emilio commented Sep 28, 2018

bors-servo commented Sep 28, 2018

servo-wpt-sync commented Sep 28, 2018

pyfisch commented Sep 28, 2018

bors-servo commented Sep 28, 2018

bors-servo commented Sep 28, 2018

bors-servo commented Sep 28, 2018

servo-wpt-sync commented Sep 28, 2018

jdm commented Sep 28, 2018

Improve border images #21608

Improve border images #21608

Conversation

pyfisch commented Sep 4, 2018 • edited by SimonSapin Loading

highfive commented Sep 4, 2018

highfive commented Sep 4, 2018

pyfisch commented Sep 4, 2018

bors-servo commented Sep 4, 2018

bors-servo commented Sep 4, 2018

jdm commented Sep 10, 2018

pyfisch commented Sep 11, 2018 via email

servo-wpt-sync commented Sep 11, 2018

pyfisch commented Sep 11, 2018

jdm commented Sep 11, 2018

bors-servo commented Sep 11, 2018

bors-servo commented Sep 11, 2018

servo-wpt-sync commented Sep 12, 2018

pyfisch commented Sep 12, 2018 • edited Loading

pyfisch commented Sep 12, 2018

bors-servo commented Sep 12, 2018

bors-servo commented Sep 12, 2018

pyfisch commented Sep 27, 2018

jdm commented Sep 27, 2018

ghost commented Sep 28, 2018

servo-wpt-sync commented Sep 28, 2018

pyfisch commented Sep 28, 2018

jdm commented Sep 28, 2018

emilio left a comment

Choose a reason for hiding this comment

emilio Sep 28, 2018

Choose a reason for hiding this comment

emilio commented Sep 28, 2018

bors-servo commented Sep 28, 2018

servo-wpt-sync commented Sep 28, 2018

pyfisch commented Sep 28, 2018

bors-servo commented Sep 28, 2018

bors-servo commented Sep 28, 2018

bors-servo commented Sep 28, 2018

servo-wpt-sync commented Sep 28, 2018

jdm commented Sep 28, 2018

pyfisch commented Sep 4, 2018 •

edited by SimonSapin

Loading

pyfisch commented Sep 12, 2018 •

edited

Loading