Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more WebGL extensions #21665

Closed
wants to merge 1 commit into from
Closed

Expose more WebGL extensions #21665

wants to merge 1 commit into from

Conversation

jdm
Copy link
Member

@jdm jdm commented Sep 10, 2018

According to https://developer.mozilla.org/en-US/docs/Web/API/EXT_color_buffer_half_float and https://developer.mozilla.org/en-US/docs/Web/API/WEBGL_color_buffer_float these are implicitly exposed by the corresponding OES texture extensions. The tests were testing for the presence of the extension along with the ability to make use of its features.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/EXTColorBufferHalfFloat.webidl, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webidls/WEBGLColorBufferFloat.webidl, components/script/dom/webgl_extensions/ext/webglcolorbufferfloat.rs and 1 more
  • @jgraham: tests/wpt/webgl/meta/conformance/extensions/oes-texture-float.html.ini, tests/wpt/webgl/meta/conformance/extensions/oes-texture-half-float.html.ini
  • @KiChjang: components/script/dom/webidls/EXTColorBufferHalfFloat.webidl, components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webgl_extensions/ext/mod.rs, components/script/dom/webidls/WEBGLColorBufferFloat.webidl, components/script/dom/webgl_extensions/ext/webglcolorbufferfloat.rs and 1 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 10, 2018
…mplicitly exposed by OES_texture_float and OES_texture_half_float.
@jdm
Copy link
Member Author

jdm commented Sep 11, 2018

r? @nox

@highfive highfive assigned nox and unassigned avadacatavra Sep 11, 2018
@jdm jdm added this to In progress in WebGL content Sep 18, 2018
@nox
Copy link
Contributor

nox commented Sep 19, 2018

This needs code changes, the 32-bit floating-point type RGBA32F becomes available as a color-renderable format only when WEBGL_color_buffer_float is enabled. There are probably similar things for EXT_color_buffer_half_float.

@nox nox added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 19, 2018
@nox
Copy link
Contributor

nox commented Oct 26, 2018

I cleaned this up and will push it soon.

@nox nox closed this Oct 26, 2018
@atouchet atouchet removed this from In progress in WebGL content Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-code-changes Changes have not yet been made that were requested by a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants