Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ctx.drawImage a bit #21911

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Simplify ctx.drawImage a bit #21911

merged 1 commit into from
Oct 12, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Oct 11, 2018 •
edited by SimonSapin
Loading

There is no need to swap between RGBA and BGRA twice.

This change is Reviewable

@nox
Simplify ctx.drawImage a bit
bb2101f 
There is no need to swap between RGBA and BGRA twice.
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/canvasrenderingcontext2d.rs
  • @KiChjang: components/script/dom/canvasrenderingcontext2d.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 11, 2018
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit bb2101f has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Oct 11, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 11, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit bb2101f with merge a4726ed...

bors-servo pushed a commit that referenced this pull request Oct 11, 2018
Auto merge of #21911 - servo:webgl, r=jdm
a4726ed 
Simplify ctx.drawImage a bit

There is no need to swap between RGBA and BGRA twice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21911)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 11, 2018
@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo: retry
#21916

@bors-servo
Copy link
Contributor

💣 Failed to start rebuilding: Unknown error

@bors-servo
Copy link
Contributor

⌛ Testing commit bb2101f with merge 120f927...

bors-servo pushed a commit that referenced this pull request Oct 11, 2018
Auto merge of #21911 - servo:webgl, r=jdm
120f927 
Simplify ctx.drawImage a bit

There is no need to swap between RGBA and BGRA twice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21911)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 11, 2018
@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo r-

@jdm
Copy link
Member

jdm commented Oct 11, 2018

@bors-servo clean r+ retry

@bors-servo
Copy link
Contributor

📌 Commit bb2101f has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit bb2101f with merge 6061034...

bors-servo pushed a commit that referenced this pull request Oct 11, 2018
Auto merge of #21911 - servo:webgl, r=jdm
6061034 
Simplify ctx.drawImage a bit

There is no need to swap between RGBA and BGRA twice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21911)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 12, 2018
@jdm
Copy link
Member

jdm commented Oct 12, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit bb2101f with merge dc786ed...

bors-servo pushed a commit that referenced this pull request Oct 12, 2018
Auto merge of #21911 - servo:webgl, r=jdm
dc786ed 
Simplify ctx.drawImage a bit

There is no need to swap between RGBA and BGRA twice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21911)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 12, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 12, 2018
@nox
Copy link
Contributor Author

nox commented Oct 12, 2018

@bors-servo retry #13480

@bors-servo
Copy link
Contributor

⌛ Testing commit bb2101f with merge 5f463d3...

bors-servo pushed a commit that referenced this pull request Oct 12, 2018
Auto merge of #21911 - servo:webgl, r=jdm
5f463d3 
Simplify ctx.drawImage a bit

There is no need to swap between RGBA and BGRA twice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21911)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 12, 2018
@bors-servo
Copy link
Contributor

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 5f463d3 to master...

@bors-servo bors-servo merged commit bb2101f into master Oct 12, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nox @highfive @jdm @bors-servo @ferjm