Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly build WebRender LineDisplayItem #22035

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Directly build WebRender LineDisplayItem #22035

merged 1 commit into from
Oct 29, 2018

Conversation

pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Oct 28, 2018 •
edited by SimonSapin
Loading

Remove unused SimpleMatrixDetection.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @emilio: components/layout/display_list/items.rs, components/layout/display_list/builder.rs, components/layout/display_list/webrender_helpers.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 28, 2018
@highfive
Copy link

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!

@pyfisch
Copy link
Contributor Author

pyfisch commented Oct 28, 2018

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

⌛ Trying commit b311aef with merge 89d1557...

bors-servo pushed a commit that referenced this pull request Oct 28, 2018
Auto merge of #22035 - pyfisch:line-item, r=<try>
89d1557 
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 28, 2018
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Oct 28, 2018
@pyfisch
Copy link
Contributor Author

pyfisch commented Oct 28, 2018

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

⌛ Trying commit bfd1f2b with merge 7c2e04f...

bors-servo pushed a commit that referenced this pull request Oct 28, 2018
Auto merge of #22035 - pyfisch:line-item, r=<try>
7c2e04f 
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

emilio
emilio approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

components/layout/display_list/builder.rs Outdated
orientation: webrender_api::LineOrientation::Horizontal,
wavy_line_thickness,
color: color.to_layout(),
style: LineStyle::Solid,
})));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Indentation here feels a bit weird, probably the curly brace should be on its own line before this one now, and same above.

@emilio
Copy link
Member

emilio commented Oct 28, 2018

@bors-servo delegate+

@bors-servo
Copy link
Contributor

✌️ @pyfisch can now approve this pull request

@pyfisch
Directly build WebRender LineDisplayItem
93abe79 
Remove unused SimpleMatrixDetection.
@pyfisch
Copy link
Contributor Author

pyfisch commented Oct 28, 2018

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 93abe79 has been approved by emilio

@highfive highfive assigned emilio and unassigned jdm Oct 28, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 28, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 93abe79 with merge 16be142...

bors-servo pushed a commit that referenced this pull request Oct 28, 2018
Auto merge of #22035 - pyfisch:line-item, r=emilio
16be142 
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 28, 2018
@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 28, 2018
@pyfisch
Copy link
Contributor Author

pyfisch commented Oct 28, 2018 via email

@bors-servo
Copy link
Contributor

⌛ Testing commit 93abe79 with merge 150732d...

bors-servo pushed a commit that referenced this pull request Oct 28, 2018
Auto merge of #22035 - pyfisch:line-item, r=emilio
150732d 
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 28, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 28, 2018
@CYBAI
Copy link
Member

CYBAI commented Oct 29, 2018

@bors-servo retry

  • oom in linux-rel-wpt
  • in linux-rel-css
{"status": "CRASH", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/syntax/parsing/html5lib_tests15.html?run_type=uri", "line": 199926, "action": "test_result", "expected": "OK"}

@bors-servo
Copy link
Contributor

⌛ Testing commit 93abe79 with merge d9f5e8a...

bors-servo pushed a commit that referenced this pull request Oct 29, 2018
Auto merge of #22035 - pyfisch:line-item, r=emilio
d9f5e8a 
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 29, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 29, 2018
@CYBAI
Copy link
Member

CYBAI commented Oct 29, 2018

@bors-servo retry

{"status": "FAIL", "group": "default", "message": "/css/CSS2/selectors/sibling-selector-002.xht 4e6ec2a4e7504e5c4bb739eb4fad793251d3180f\n/css/CSS2/reference/filler-text-below-green.xht 89fbe26567dcb89de46762b75a6737796e0220f3\nTesting 4e6ec2a4e7504e5c4bb739eb4fad793251d3180f == 89fbe26567dcb89de46762b75a6737796e0220f3", "stack": null, "subtest": null, "test": "/css/CSS2/selectors/sibling-selector-002.xht", "line": 13147, "action": "test_result", "expected": "PASS"}

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: emilio
Pushing d9f5e8a to master...

@bors-servo bors-servo merged commit 93abe79 into servo:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pyfisch @highfive @bors-servo @emilio @CYBAI @jdm