New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly build WebRender LineDisplayItem #22035

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
6 participants
@pyfisch
Contributor

pyfisch commented Oct 28, 2018

Remove unused SimpleMatrixDetection.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Oct 28, 2018

Heads up! This PR modifies the following files:

  • @emilio: components/layout/display_list/items.rs, components/layout/display_list/builder.rs, components/layout/display_list/webrender_helpers.rs
@highfive

This comment has been minimized.

highfive commented Oct 28, 2018

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@pyfisch

This comment has been minimized.

Contributor

pyfisch commented Oct 28, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

⌛️ Trying commit b311aef with merge 89d1557...

bors-servo added a commit that referenced this pull request Oct 28, 2018

Auto merge of #22035 - pyfisch:line-item, r=<try>
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

💔 Test failed - linux-rel-wpt

@pyfisch

This comment has been minimized.

Contributor

pyfisch commented Oct 28, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

⌛️ Trying commit bfd1f2b with merge 7c2e04f...

bors-servo added a commit that referenced this pull request Oct 28, 2018

Auto merge of #22035 - pyfisch:line-item, r=<try>
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@emilio

emilio approved these changes Oct 28, 2018

Looks great!

orientation: webrender_api::LineOrientation::Horizontal,
wavy_line_thickness,
color: color.to_layout(),
style: LineStyle::Solid,
})));

This comment has been minimized.

@emilio

emilio Oct 28, 2018

Member

nit: Indentation here feels a bit weird, probably the curly brace should be on its own line before this one now, and same above.

@emilio

This comment has been minimized.

Member

emilio commented Oct 28, 2018

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

✌️ @pyfisch can now approve this pull request

Directly build WebRender LineDisplayItem
Remove unused SimpleMatrixDetection.
@pyfisch

This comment has been minimized.

Contributor

pyfisch commented Oct 28, 2018

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

📌 Commit 93abe79 has been approved by emilio

@highfive highfive assigned emilio and unassigned jdm Oct 28, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

⌛️ Testing commit 93abe79 with merge 16be142...

bors-servo added a commit that referenced this pull request Oct 28, 2018

Auto merge of #22035 - pyfisch:line-item, r=emilio
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

💔 Test failed - linux-rel-wpt

@pyfisch

This comment has been minimized.

Contributor

pyfisch commented Oct 28, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

⌛️ Testing commit 93abe79 with merge 150732d...

bors-servo added a commit that referenced this pull request Oct 28, 2018

Auto merge of #22035 - pyfisch:line-item, r=emilio
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 28, 2018

💔 Test failed - linux-rel-css

@CYBAI

This comment has been minimized.

Collaborator

CYBAI commented Oct 29, 2018

@bors-servo retry

  • oom in linux-rel-wpt
  • in linux-rel-css
{"status": "CRASH", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/syntax/parsing/html5lib_tests15.html?run_type=uri", "line": 199926, "action": "test_result", "expected": "OK"}
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 29, 2018

⌛️ Testing commit 93abe79 with merge d9f5e8a...

bors-servo added a commit that referenced this pull request Oct 29, 2018

Auto merge of #22035 - pyfisch:line-item, r=emilio
Directly build WebRender LineDisplayItem

Remove unused SimpleMatrixDetection.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22035)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 29, 2018

💔 Test failed - linux-rel-css

@CYBAI

This comment has been minimized.

Collaborator

CYBAI commented Oct 29, 2018

@bors-servo retry

{"status": "FAIL", "group": "default", "message": "/css/CSS2/selectors/sibling-selector-002.xht 4e6ec2a4e7504e5c4bb739eb4fad793251d3180f\n/css/CSS2/reference/filler-text-below-green.xht 89fbe26567dcb89de46762b75a6737796e0220f3\nTesting 4e6ec2a4e7504e5c4bb739eb4fad793251d3180f == 89fbe26567dcb89de46762b75a6737796e0220f3", "stack": null, "subtest": null, "test": "/css/CSS2/selectors/sibling-selector-002.xht", "line": 13147, "action": "test_result", "expected": "PASS"}
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 29, 2018

@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit 93abe79 into servo:master Oct 29, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment