Change the path for SSL configs in browser_kwargs

[KiChjang]

Fixes #22252.

---

This change is 

[servo-wpt-sync]

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14197.

[jdm]

@bors-servo try=wpt

[bors-servo]

⌛ Trying commit fe096a2 with merge 4ddabfb...

[bors-servo]

💔 Test failed - linux-rel-css

[KiChjang]

Ok, so clearly this is a platform-specific problem, and I'll need some logic to detect if the current OS is windows or not.

[KiChjang]

@bors-servo try=wpt

[bors-servo]

⌛ Trying commit 4fc9f3b with merge 2e35e84...

[servo-wpt-sync]

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14197.

[bors-servo]

💔 Test failed - linux-rel-css

[KiChjang]

@bors-servo try=wpt

[bors-servo]

⌛ Trying commit c4fe0de with merge 0db3c16...

[servo-wpt-sync]

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14197.

[bors-servo]

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

[KiChjang]

r? @jdm

[jgraham]

I"m not sure what's going on here, but this is a pretty odd-looking change. If you are passing in the correct ssl_type then the path should be set correcty. Therefore I wonder if the config isn't set up to use ssl_type of pregenerated and that's the underlying issue?

[jdm]

I propose that we set kwargs['ssl_type'] = 'pregenerated' in

servo/tests/wpt/run.py

Line 51 in 0375cbc

def set_defaults(kwargs):

and see if that works without any other changes.

[KiChjang]

Trying that without the patch applied here results in:

The details of the failure are as follows:

TypeError: coercing to Unicode: need string or buffer, NoneType found

  File "D:\Workspace\servo\python\servo\testing_commands.py", line 376, in test_wpt
    ret = self.run_test_list_or_dispatch(kwargs["test_list"], "wpt", self._test_wpt, **kwargs)
  File "D:\Workspace\servo\python\servo\testing_commands.py", line 416, in run_test_list_or_dispatch
    return correct_function(**kwargs)
  File "D:\Workspace\servo\python\servo\testing_commands.py", line 402, in _test_wpt
    return self.wptrunner(run_file, **kwargs)
  File "D:\Workspace\servo\python\servo\testing_commands.py", line 448, in wptrunner
    return run_globals["run_tests"](**kwargs)
  File "D:\Workspace\servo\tests\wpt\run.py", line 31, in run_tests
    set_defaults(kwargs)
  File "D:\Workspace\servo\tests\wpt\run.py", line 80, in set_defaults
    wptcommandline.check_args(kwargs)
  File "D:\Workspace\servo\tests\wpt\web-platform-tests\tools\wptrunner\wptrunner\wptcommandline.py", line 493, in check_args
    require_arg(kwargs, "ca_cert_path", lambda x:os.path.exists(x))
  File "D:\Workspace\servo\tests\wpt\web-platform-tests\tools\wptrunner\wptrunner\wptcommandline.py", line 31, in require_arg
    if name not in kwargs or not value_func(kwargs[name]):
  File "D:\Workspace\servo\tests\wpt\web-platform-tests\tools\wptrunner\wptrunner\wptcommandline.py", line 493, in <lambda>
    require_arg(kwargs, "ca_cert_path", lambda x:os.path.exists(x))
  File "C:\Python27\lib\genericpath.py", line 26, in exists
    os.stat(path)

i.e. the ca_cert_path is not found in kwargs.

[KiChjang]

Oh, it looks like the ca_certificate_path never existed in the first place! This patch "works" because config.ssl["pregenerated"]["ca_cert_path"] was in fact None, and that simply causes the tests to not use SSL at all.

[servo-wpt-sync]

Error syncing changes upstream. Logs saved in error-snapshot-1545479328147.

[KiChjang]

@jdm @jgraham I think this should do the trick, please have a look and see if it's the correct fix.

[servo-wpt-sync]

Error syncing changes upstream. Logs saved in error-snapshot-1545509318172.