Preliminary WebXR support #22528

Manishearth · 2018-12-22T01:00:56Z

This implements just enough WebXR to display to 3DOF devices in
immersive mode only.

Couple missing things:

Handling reference spaces (even if just supporting eye-level spaces)
Spec links
We enter immersive mode when baseLayer is set, but it seems like
we're supposed to do this when requestSession is called (Specify when we enter/exit immersive mode and what the baseLayer setter does immersive-web/webxr#453)
VR/XR should block less (navigator.getDisplays() should be more async #22505)
More pref-gating
views is a method instead of an attribute because we don't support FrozenArray

~~Once I add spec links and pref gating~~ this can be landed as-is for further experimentation.

This change is

The WebVR spec no longer has a navigator.vr, but there is a navigator.XR in the XR spec. Instead of duplicating work I've combined the two.

highfive · 2018-12-22T01:01:00Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/XRSession.webidl, components/script/dom/navigator.rs, components/script/dom/webidls/XRViewport.webidl, components/script/dom/vrdisplay.rs, components/script/dom/webidls/XRStationaryReferenceSpace.webidl and 27 more
@KiChjang: components/script/dom/webidls/XRSession.webidl, components/script/dom/navigator.rs, components/script/dom/webidls/XRViewport.webidl, components/script/dom/vrdisplay.rs, components/script/dom/webidls/XRStationaryReferenceSpace.webidl and 27 more

highfive · 2018-12-22T01:01:01Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify script code, but no tests are modified. Please consider adding a test!

jdm · 2018-12-22T18:15:42Z

components/script/dom/webidls/VR.webidl

-[NoInterfaceObject]
-interface VR {
-  [Pref="dom.webvr.enabled"]
-  Promise<sequence<VRDisplay>> getDisplays();


It is not clear to me that eliminating WebVR from our implementation is the right choice right now. It's useful to test against the existing WebVR content.

I'm not! navigator.vr is old WebVR (it's not in the spec anymore). I still support navigator.getVRDisplays() which is the new thing.

https://immersive-web.github.io/webvr/spec/1.1/#interface-navigator

I just found it convenient to repurpose the VR object as XR since it has the same purpose and I didn't want to duplicate the messaging/syncing logic

Manishearth · 2018-12-22T19:19:35Z

Oh, also, one departure from the spec: we don't support FrozenArray and attributes can't be sequences so currently the views attribute is a function.

I might try to make it use any instead so that it works the same.

MortimerGoro

Great work!

Code looks good on first pass.

MortimerGoro · 2018-12-22T20:58:39Z

components/script/dom/webidls/XRFrame.webidl

+
+// https://immersive-web.github.io/webxr/#xrframe-interface
+
+[SecureContext, Exposed=Window] interface XRFrame {


The new XR interfaces should be behind a pref [Pref="dom.webxr.enabled"]

Right, I'd mentioned in the PR title that this was missing 😄

MortimerGoro · 2018-12-22T20:59:29Z

components/script/dom/webidls/XRSession.webidl

+
+callback XRFrameRequestCallback = void (DOMHighResTimeStamp time, XRFrame frame);
+
+[SecureContext, Exposed=Window] interface XRSession : EventTarget {


[Pref="dom.webxr.enabled"] and in other new interfaces

MortimerGoro · 2018-12-22T21:15:59Z

components/script/dom/webglrenderingcontext.rs

@@ -266,6 +268,7 @@ impl WebGLRenderingContext {
    pub fn recreate(&self, size: Size2D<u32>) {
        let (sender, receiver) = webgl_channel().unwrap();
        self.webgl_sender.send_resize(size, sender).unwrap();
+        self.size.set(size);


Can we guarantee that rust-offscreen-rendering-context is going to respect this size? There may be some corner cases such as JS requesting a larger size than the maximum allowed by the GPU. We can check with the existing webgl tests.

If we can guarantee this size you can also optimize DrawingBufferWidth() and DrawingBufferHeigh()

I believe when that happens it just doesn't work (throwing a GL error). At least, when I was playing with this in Firefox with Pathfinder that was the case, there's a limit to the texture size.

The webgl implementation is allowed to choose a smaller size than what is requested; Servo's implementation does not right now and panics, #21718 tracks implementing this correctly.

Is it enough to just drop a comment linking to that since that's not implemented yet?

bors-servo · 2019-01-04T00:15:23Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

Manishearth · 2019-01-04T00:15:50Z

@bors-servo try- r=jdm,MortimerGoro

bors-servo · 2019-01-04T00:15:50Z

📌 Commit fc69cd3 has been approved by jdm,MortimerGoro

bors-servo · 2019-01-04T00:15:55Z

⌛ Testing commit fc69cd3 with merge be035df...

@jdm

Preliminary WebXR support This implements just enough WebXR to display to 3DOF devices in immersive mode only. Couple missing things: - [ ] Handling reference spaces (even if just supporting eye-level spaces) - [x] Spec links - [ ] We enter immersive mode when baseLayer is set, but it seems like we're supposed to do this when requestSession is called (immersive-web/webxr#453) - [ ] VR/XR should block less (#22505) - [x] More pref-gating - [x] `views` is a method instead of an attribute because we don't support FrozenArray <s>Once I add spec links and pref gating</s> this can be landed as-is for further experimentation. r? @jdm @MortimerGoro  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22528)

bors-servo · 2019-01-04T01:34:14Z

💔 Test failed - status-taskcluster

jdm · 2019-01-04T03:59:38Z

Diff in /home/travis/build/servo/servo/components/script/dom/xrwebgllayer.rs at line 18:
 use crate::dom::xrviewport::XRViewport;
 use dom_struct::dom_struct;
 
-
 #[dom_struct]
 pub struct XRWebGLLayer {
     xrlayer: XRLayer,
Run `./mach fmt` to fix the formatting

Manishearth · 2019-01-04T07:54:13Z

@bors-servo r=jdm,MortimerGoro

bors-servo · 2019-01-04T07:54:13Z

📌 Commit e544462 has been approved by jdm,MortimerGoro

bors-servo · 2019-01-04T07:54:18Z

⌛ Testing commit e544462 with merge c4a6dcf...

@jdm

Preliminary WebXR support This implements just enough WebXR to display to 3DOF devices in immersive mode only. Couple missing things: - [ ] Handling reference spaces (even if just supporting eye-level spaces) - [x] Spec links - [ ] We enter immersive mode when baseLayer is set, but it seems like we're supposed to do this when requestSession is called (immersive-web/webxr#453) - [ ] VR/XR should block less (#22505) - [x] More pref-gating - [x] `views` is a method instead of an attribute because we don't support FrozenArray <s>Once I add spec links and pref gating</s> this can be landed as-is for further experimentation. r? @jdm @MortimerGoro  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22528)

bors-servo · 2019-01-04T09:11:17Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm,MortimerGoro
Pushing c4a6dcf to master...

Manishearth added 16 commits December 19, 2018 14:33

Move VR interface to XR

376426a

The WebVR spec no longer has a navigator.vr, but there is a navigator.XR in the XR spec. Instead of duplicating work I've combined the two.

Basic XRSession interface

ebf9ccc

Basic XRFrame interface

29e9672

Basic XRSpace interface

90e0ceb

Basic XRReferenceSpace interface

5814700

Basic XRViewerPose interface

31feb1e

Basic XRView interface

73c5303

Basic XRRigidTransform interface

520bb23

Fill in XR.requestSession

d591181

allow setting base layer

682c89a

Fill in some of XRWebGLLayer

70e8a19

Simple presentation

e259ff7

Support fetching viewport info

7e043a3

Fill in XR frame/pose/view implementations

28dff81

Support attaching RAF callbacks

1b11a30

Invoke XR RAFs appropriately

4b2fa5e

highfive assigned jdm Dec 22, 2018

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 22, 2018

jdm reviewed Dec 22, 2018

View reviewed changes

MortimerGoro suggested changes Dec 22, 2018

View reviewed changes

Add dom.webxr.enabled pref

241d933

Manishearth force-pushed the webxr branch from 917a9d5 to 68469d7 Compare December 23, 2018 06:26

Add spec links

c6c6b51

Manishearth force-pushed the webxr branch from 68469d7 to 5a6ecef Compare December 23, 2018 06:31

Properly support depthNear and depthFar

64a64a8

Manishearth force-pushed the webxr branch 2 times, most recently from 3a6a1aa to f7eab6e Compare December 23, 2018 07:00

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 4, 2019

Manishearth mentioned this pull request Jan 4, 2019

Make unrooted_must_root ignore Rc<Promise> #22608

Merged

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 4, 2019

Manishearth added 5 commits January 3, 2019 23:53

Silence unused warnings

c3b93a9

Remove Cell in XRSpace

309bd63

Link to relevant issues

cfa5397

NonNull::new()

4d73eac

Remove unrooted_must_root

e544462

Manishearth force-pushed the webxr branch from fc69cd3 to e544462 Compare January 4, 2019 07:54

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Jan 4, 2019

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 4, 2019

bors-servo merged commit e544462 into servo:master Jan 4, 2019

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 4, 2019

Manishearth deleted the webxr branch January 4, 2019 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preliminary WebXR support #22528

Preliminary WebXR support #22528

Manishearth commented Dec 22, 2018 •

edited

Loading

highfive commented Dec 22, 2018

highfive commented Dec 22, 2018

jdm Dec 22, 2018

Manishearth Dec 22, 2018

Manishearth Dec 22, 2018

Manishearth Dec 22, 2018

Manishearth commented Dec 22, 2018

MortimerGoro left a comment

MortimerGoro Dec 22, 2018

Manishearth Dec 23, 2018

MortimerGoro Dec 22, 2018

MortimerGoro Dec 22, 2018

Manishearth Dec 23, 2018 •

edited

Loading

jdm Jan 3, 2019

Manishearth Jan 3, 2019

jdm Jan 3, 2019

bors-servo commented Jan 4, 2019

Manishearth commented Jan 4, 2019

bors-servo commented Jan 4, 2019

bors-servo commented Jan 4, 2019

bors-servo commented Jan 4, 2019

jdm commented Jan 4, 2019

Manishearth commented Jan 4, 2019

bors-servo commented Jan 4, 2019

bors-servo commented Jan 4, 2019

bors-servo commented Jan 4, 2019


		// https://immersive-web.github.io/webxr/#xrframe-interface

		[SecureContext, Exposed=Window] interface XRFrame {


		callback XRFrameRequestCallback = void (DOMHighResTimeStamp time, XRFrame frame);

		[SecureContext, Exposed=Window] interface XRSession : EventTarget {

Preliminary WebXR support #22528

Preliminary WebXR support #22528

Conversation

Manishearth commented Dec 22, 2018 • edited Loading

highfive commented Dec 22, 2018

highfive commented Dec 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Manishearth commented Dec 22, 2018

MortimerGoro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Manishearth Dec 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bors-servo commented Jan 4, 2019

Manishearth commented Jan 4, 2019

bors-servo commented Jan 4, 2019

bors-servo commented Jan 4, 2019

bors-servo commented Jan 4, 2019

jdm commented Jan 4, 2019

Manishearth commented Jan 4, 2019

bors-servo commented Jan 4, 2019

bors-servo commented Jan 4, 2019

bors-servo commented Jan 4, 2019

Manishearth commented Dec 22, 2018 •

edited

Loading

Manishearth Dec 23, 2018 •

edited

Loading