Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url for LayoutImageContext #23048

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Add url for LayoutImageContext #23048

merged 1 commit into from
Mar 17, 2019

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Mar 16, 2019 •
edited by SimonSapin
Loading

This change is Reviewable

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ferjm (or someone else) soon.

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 16, 2019
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm
Copy link
Member

jdm commented Mar 16, 2019

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

📌 Commit 1cecb08 has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Mar 16, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 16, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 1cecb08 with merge db7bb2a...

bors-servo pushed a commit that referenced this pull request Mar 16, 2019
Auto merge of #23048 - c410-f3r:image-url, r=jdm
db7bb2a 
Add url for LayoutImageContext

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23043

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23048)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 16, 2019
@CYBAI
Copy link
Member

CYBAI commented Mar 17, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android-mac, arm32, arm64, linux-rel-css, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster are reusable. Rebuilding only linux-rel-wpt, mac-rel-css1...

@bors-servo
Copy link
Contributor

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing db7bb2a to master...

@bors-servo bors-servo merged commit 1cecb08 into servo:master Mar 17, 2019
@c410-f3r c410-f3r deleted the image-url branch March 17, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page load response timing information gets ignored
6 participants
@c410-f3r @highfive @jdm @bors-servo @CYBAI @ferjm