-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md - fixes Requirements for Fedora #23084
Conversation
Adds missing `libX11-devel` package for Fedora. Required for building.
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ferjm (or someone else) soon. |
@bors-servo r+ |
📌 Commit e6c5e75 has been approved by |
Update README.md - fixes Requirements for Fedora Adds missing `libX11-devel` package for Fedora. Required for building. <!-- Please describe your changes on the following line: --> libX11-devel is missing in the required dependencies for Fedora. Required for building under Feodra. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix building under fedora <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it's just the Readme.md <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23084) <!-- Reviewable:end -->
☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster |
Adds missing
libX11-devel
package for Fedora. Required for building.libX11-devel is missing in the required dependencies for Fedora. Required for building under Feodra.
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is