Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More https #23363

Merged
merged 4 commits into from May 14, 2019
Merged

More https #23363

merged 4 commits into from May 14, 2019

Conversation

@Darkspirit
Copy link
Contributor

Darkspirit commented May 10, 2019


  • ./mach build --release does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable

Darkspirit added 4 commits May 10, 2019
@highfive
Copy link

highfive commented May 10, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/NavigationPreloadManager.webidl, components/script/dom/bindings/codegen/parser/tests/test_replaceable.py, components/script/dom/offscreencanvas.rs, components/script/dom/bindings/codegen/parser/tests/test_lenientSetter.py, components/script/dom/webidls/OffscreenCanvasRenderingContext2D.webidl and 4 more
  • @KiChjang: components/script/dom/webidls/NavigationPreloadManager.webidl, components/script/dom/bindings/codegen/parser/tests/test_replaceable.py, components/script/dom/offscreencanvas.rs, components/script/dom/bindings/codegen/parser/tests/test_lenientSetter.py, components/script/dom/webidls/OffscreenCanvasRenderingContext2D.webidl and 5 more
  • @edunham: .travis.yml
  • @paulrouget: ports/glutin/browser.rs
  • @emilio: components/style/gecko/boxed_types.rs
@jdm
Copy link
Member

jdm commented May 10, 2019

@highfive highfive assigned jdm and unassigned ferjm May 10, 2019
@Darkspirit
Copy link
Contributor Author

Darkspirit commented May 14, 2019

@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2019

😪 I'm awake I'm awake

@jdm
Copy link
Member

jdm commented May 14, 2019

@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2019

📌 Commit 71fdba1 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2019

Testing commit 71fdba1 with merge 3f30720...

bors-servo added a commit that referenced this pull request May 14, 2019
More https

* Disabled unused legacy TLS.
It will be disabled for Nightly 72 or 73 in 5-7 months and ride the [trains](https://wiki.mozilla.org/Release_Management/Calendar).
https://blog.mozilla.org/security/2018/10/15/removing-old-versions-of-tls/
* Updated MPL license in a few files.
It would be nice if a new version of https://pypi.org/project/servo_tidy/ could be released to update WebRender as well.
* Switched servo-deps.s3.amazonaws.com back to https.
This was recently regressed by 10585be and fc28073.
* Made https the default protocol for address bar on desktop.
Press Ctrl+L on the Glutin port and enter `example.com`:
Servo previously assumed you meant `http://example.com/`, now it is `https://example.com/`.

---

- [x] `./mach build --release` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23363)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2019

@bors-servo bors-servo merged commit 71fdba1 into servo:master May 14, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@Darkspirit Darkspirit deleted the Darkspirit:https branch May 14, 2019
bors-servo added a commit that referenced this pull request Nov 12, 2019
HSTS & CA updates; Fix Debian bootstrap; Default to https on Android, too.

- Updated HSTS Preload list using ./mach update-hsts-preload
- Updated CA [database](https://ccadb-public.secure.force.com/mozilla/IncludedCACertificateReportPEMCSV) using etc/cert_generator.sh.
  - No additions.
  - [bug 1552374](https://bugzilla.mozilla.org/show_bug.cgi?id=1552374) removed Certinomis - Root CA
  - [bug 1574670](https://bugzilla.mozilla.org/show_bug.cgi?id=1574670) removed Class 2 Primary CA and Deutsche Telekom Root CA 2
  - [bug 1586081](https://bugzilla.mozilla.org/show_bug.cgi?id=1586081) removed GlobalSign Extended Validation CA - SHA256 - G2
- Updated Public Suffix list using ./mach update-pub-domains
- Default to https on Android, too. Desktop was done in #23363.
Keep http:// after `android.webkit.URLUtil.guessUrl()` url sanitization only if the user explicitly typed it into the address bar.
Small warning: I don't have an Android build environment yet, but still wanted to try to contribute these two lines.
- Fixed `./mach bootstrap` for Debian Testing. Regression from #24512.
After `pip install distro` (#24561) I finally got `Exception: mach bootstrap does not support Debian GNU/Linux, please file a bug`.
distrib and version were "debian" and "bullseye/sid" before, now they are "debian gnu/linux" and "testing".
- Use HSTS preload list for private HttpState, too. Private HttpState currently [creates an empty HSTS list](https://github.com/servo/servo/blob/f7fb130a2a21ae19cf0996251134ad23fea9068d/components/net/http_loader.rs#L93-L95). In contrast, regular HttpState first creates HstsList from Preload list and then adds further HSTS entries previously saved on disk.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@Darkspirit Darkspirit mentioned this pull request Dec 2, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.