New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More https #23363
Merged
Merged
More https #23363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
May 10, 2019
@bors-servo r+ |
@bors-servo ping |
😪 I'm awake I'm awake |
@bors-servo r+ |
📌 Commit 71fdba1 has been approved by |
highfive
removed
the
S-awaiting-review
There is new code that needs to be reviewed.
label
May 14, 2019
highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
May 14, 2019
bors-servo
pushed a commit
that referenced
this pull request
May 14, 2019
More https * Disabled unused legacy TLS. It will be disabled for Nightly 72 or 73 in 5-7 months and ride the [trains](https://wiki.mozilla.org/Release_Management/Calendar). https://blog.mozilla.org/security/2018/10/15/removing-old-versions-of-tls/ * Updated MPL license in a few files. It would be nice if a new version of https://pypi.org/project/servo_tidy/ could be released to update WebRender as well. * Switched servo-deps.s3.amazonaws.com back to https. This was recently regressed by 10585be and fc28073. * Made https the default protocol for address bar on desktop. Press Ctrl+L on the Glutin port and enter `example.com`: Servo previously assumed you meant `http://example.com/`, now it is `https://example.com/`. --- - [x] `./mach build --release` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23363) <!-- Reviewable:end -->
☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster |
highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
May 14, 2019
5 tasks
bors-servo
pushed a commit
that referenced
this pull request
Nov 12, 2019
HSTS & CA updates; Fix Debian bootstrap; Default to https on Android, too. - Updated HSTS Preload list using ./mach update-hsts-preload - Updated CA [database](https://ccadb-public.secure.force.com/mozilla/IncludedCACertificateReportPEMCSV) using etc/cert_generator.sh. - No additions. - [bug 1552374](https://bugzilla.mozilla.org/show_bug.cgi?id=1552374) removed Certinomis - Root CA - [bug 1574670](https://bugzilla.mozilla.org/show_bug.cgi?id=1574670) removed Class 2 Primary CA and Deutsche Telekom Root CA 2 - [bug 1586081](https://bugzilla.mozilla.org/show_bug.cgi?id=1586081) removed GlobalSign Extended Validation CA - SHA256 - G2 - Updated Public Suffix list using ./mach update-pub-domains - Default to https on Android, too. Desktop was done in #23363. Keep http:// after `android.webkit.URLUtil.guessUrl()` url sanitization only if the user explicitly typed it into the address bar. Small warning: I don't have an Android build environment yet, but still wanted to try to contribute these two lines. - Fixed `./mach bootstrap` for Debian Testing. Regression from #24512. After `pip install distro` (#24561) I finally got `Exception: mach bootstrap does not support Debian GNU/Linux, please file a bug`. distrib and version were "debian" and "bullseye/sid" before, now they are "debian gnu/linux" and "testing". - Use HSTS preload list for private HttpState, too. Private HttpState currently [creates an empty HSTS list](https://github.com/servo/servo/blob/f7fb130a2a21ae19cf0996251134ad23fea9068d/components/net/http_loader.rs#L93-L95). In contrast, regular HttpState first creates HstsList from Preload list and then adds further HSTS entries previously saved on disk. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be disabled for Nightly 72 or 73 in 5-7 months and ride the trains.
https://blog.mozilla.org/security/2018/10/15/removing-old-versions-of-tls/
It would be nice if a new version of https://pypi.org/project/servo_tidy/ could be released to update WebRender as well.
This was recently regressed by 10585be and fc28073.
Press Ctrl+L on the Glutin port and enter
example.com
:Servo previously assumed you meant
http://example.com/
, now it ishttps://example.com/
../mach build --release
does not report any errors./mach test-tidy
does not report any errorsThis change is