Update mozjs to 89

[sagudev]

Trying to catch Firefox release.
Depends on servo/rust-mozjs#543

[highfive]

Heads up! This PR modifies the following files:

• @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/script_module.rs, components/script/Cargo.toml, components/script/dom/windowproxy.rs, components/script/dom/bindings/proxyhandler.rs
• @wafflespeanut: python/servo/bootstrap.py
• @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/script_module.rs, components/script/Cargo.toml, components/script/dom/windowproxy.rs, components/script/dom/bindings/proxyhandler.rs

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[jdm]

@bors-servo try

[bors-servo]

⌛ Trying commit a044383 with merge 2e38240...

[sagudev]

@jdm mac failed on packaging app.

[bors-servo]

💔 Test failed - checks-github

[sagudev]

After reviewing tests, it looks that most of them become PASS (mostly wasm stuff), but it looks like something is wrong with promises.

[sagudev]

  ▶ Unexpected subtest result in /html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-script-error.html:
  │ FAIL [expected PASS] b'import() must reject with the same error object for each import when there is a evaluation error'
  │   → assert_equals: The error objects must be equal expected object "Error: Unevaluated or errored module returned by module resolve hook" but got object "Error: Unevaluated or errored module returned by module resolve hook"

[jdm]

The module tests in particular look like there's a problem with those changes in this PR.

[sagudev]

Changes were required because of https://bugzilla.mozilla.org/show_bug.cgi?id=1668330:

• https://hg.mozilla.org/mozilla-central/rev/be113df2bd10
• https://hg.mozilla.org/mozilla-central/rev/2690ae6050e4

[sagudev]

  ▶ Unexpected subtest result in /html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-script-error.html:
  │ FAIL [expected PASS] b'import() must reject with the same error object for each import when there is a evaluation error'
  │   → assert_equals: The error objects must be equal expected object "Error: Unevaluated or errored module returned by module resolve hook" but got object "Error: Unevaluated or errored module returned by module resolve hook"

Expected error is Error.
These Errors come from https://searchfox.org/mozilla-central/search?q=Unevaluated+or+errored&path=
There is also Unhandled rejection error in this test and in some other test there are problems with promises.

[sagudev]

On ./mach test-wpt html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-script-error.html
Expected:

What its currently:

[sagudev]

Probably missing some error handling like:
https://hg.mozilla.org/mozilla-central/rev/be113df2bd10#l4.363

[sagudev]

Very suspicious: https://bugzilla.mozilla.org/show_bug.cgi?id=1536094
Which creates:

• https://hg.mozilla.org/mozilla-central/rev/c578a7dd691c
• https://hg.mozilla.org/mozilla-central/rev/ddba49efbd9f
• https://hg.mozilla.org/mozilla-central/rev/ba4c269cea68

but probably it isn't.

[bors-servo]

☔ The latest upstream changes (presumably #28538) made this pull request unmergeable. Please resolve the merge conflicts.

[Redfire75369]

According to a GJS developer, @ewlsh in #spidermonkey:mozilla.org matrix.

It looks like they just haven't updated their code for the TLA changes to the promises API
You can look at GJS' mozjs91 MR if you want to get a sense of how to adjust API usage + handle dynamics

I believe they are referring to this MR: https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/632
Even more specifically, this looks like the commit that implemented those changes: https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/632/diffs?commit_id=e4ed245f13a703968b7e2f5acadc36a54452e22a#158c25371cf55a8db28e9b6c41a3ee4840d2cf8d.

[sagudev]

Due to not having time I'm closing this PR.