Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mozjs #28538

Merged
merged 1 commit into from Jul 10, 2021
Merged

Update mozjs #28538

merged 1 commit into from Jul 10, 2021

Conversation

yvt
Copy link
Contributor

@yvt yvt commented Jul 10, 2021

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because it introduces no behavioral changes

@yvt
chore(deps): update mozjs
727662a 
 - a8b688a: Add `ProxyTraps::{getPrototype, setPrototype, setImmutablePrototype}`
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/windowproxy.rs
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/windowproxy.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 10, 2021
@jdm
Copy link
Member

jdm commented Jul 10, 2021

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

📌 Commit 727662a has been approved by jdm

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 10, 2021
@bors-servo
Copy link
Contributor

⌛ Testing commit 727662a with merge 360c262...

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 10, 2021
bors-servo added a commit that referenced this pull request Jul 10, 2021
@bors-servo
Auto merge of #28538 - yvt:chore-mozjs, r=jdm
360c262 
Update mozjs

 - <servo/rust-mozjs#548>

---
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

---
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it introduces no behavioral changes
@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 10, 2021
@jdm
Copy link
Member

jdm commented Jul 10, 2021

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 727662a with merge 4181962...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 10, 2021
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github, status-taskcluster
Approved by: jdm
Pushing 4181962 to master...

@bors-servo bors-servo merged commit 4181962 into servo:master Jul 10, 2021
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 10, 2021
@bors-servo bors-servo mentioned this pull request Jul 10, 2021
Closed
@yvt yvt mentioned this pull request Jul 25, 2021
Closed
4 tasks
@yvt yvt deleted the chore-mozjs branch July 25, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yvt @highfive @jdm @bors-servo