Release selectors 0.24.0 and servo_arc 0.2.0 #29364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will crates.io allow publishing crates which have optional path dependencies with no version specification? Will we need to patch selectors to remove those from Cargo.toml before publishing? |
|
Hmm, good point, it looks like the answer is no: Based on rust-lang/cargo#4544, we’ll either need to publish dummy versions of to_shmem and to_shmem_derive, or publish them fully. |
|
I’ve published dummy versions of to_shmem and to_shmem_derive (0.0.0), and updated this patch accordingly. |
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Feb 16, 2023
Release selectors 0.24.0 and servo_arc 0.2.0 This patch extends #29361, bumping selectors to 0.24.0 and servo_arc to 0.2.0. We’ll need to publish them too, in order to close #29105. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29105 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because there are no functional changes
|
Results from try job (#4192346647): Unexpected results that are known to be intermittent (43)
|
|
☀️ Test successful - checks-github |
jdm
approved these changes
Feb 17, 2023
|
|
@bors-servo r=jdm |
|
📌 Commit e82d786 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2023
Release selectors 0.24.0 and servo_arc 0.2.0 This patch extends #29361, bumping selectors to 0.24.0 and servo_arc to 0.2.0. We’ll need to publish them too, in order to close #29105. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29105 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because there are no functional changes
3 tasks
|
Results from try job (#4224254439): Tests producing unexpected results (1)
Unexpected results that are known to be intermittent (37)
|
|
Results from try job (#4225081363): Unexpected results that are known to be intermittent (44)
|
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends #29361, bumping selectors to 0.24.0 and servo_arc to 0.2.0.
We’ll need to publish them too, in order to close #29105.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors