Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass S3 secrets for nightly builds and fix windows build #29615

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Pass S3 secrets for nightly builds and fix windows build #29615

merged 1 commit into from
Apr 11, 2023

Conversation

mukilan
Copy link
Member

@mukilan mukilan commented Apr 11, 2023 •
edited

Secrets need to be passed to reusable workflows either by name or by secrets: inherit from the caller workflow. The latter allows accessing all secrets in scope.

Windows build has a bug where the upload-nightly command is not run from the correct working directory.

This manual build based on this branch has passed and the binaries have also been updated in servo.org for today.

  • There are tests for these changes OR
  • These changes do not require tests because it fixes bug in CI configuration.

@mukilan
Pass S3 secrets for nightly builds and fix windows build
757666f 
Secrets need to be passed to reusable workflows either
by name or by `secrets: inherit` from the caller workflow.
The latter allows accessing all secrets in scope.

Windows build has a bug where the upload-nightly command is
not run from the correct working directory.

Closes #29614

Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
@mukilan mukilan requested a review from mrobinson April 11, 2023 10:11
mrobinson
mrobinson approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@mukilan
Copy link
Member Author

mukilan commented Apr 11, 2023

@bors-servo r=mrobinson

@bors-servo
Copy link
Contributor

📌 Commit 757666f has been approved by mrobinson

@bors-servo
Copy link
Contributor

⌛ Testing commit 757666f with merge 1f3837d...

@github-actions
Copy link

Results from try job (#4666611046):

Flaky unexpected result (21)
  • OK /_mozilla/mozilla/scrollBy.html (#21321)
    • PASS [expected FAIL] subtest: Ensure that the window.scrollBy function affects scroll position as expected
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/CSS2/floats/hit-test-floats-002.html (#25733)
    • FAIL [expected PASS] subtest: Hit test float
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-002.html (#29057)
    • FAIL [expected PASS] subtest: elementFromPoint
  • FAIL [expected PASS] /css/css-text/line-breaking/segment-break-transformation-unremovable-4.html (#28723)
  • OK /css/cssom-view/elementFromPoint-ellipsis-in-inline-box.html (#27414)
    • FAIL [expected PASS] subtest: elementFromPoint-ellipsis-in-inline-box
  • OK /css/cssom-view/elementFromPoint-float-in-relative.html (#27753)
    • PASS [expected FAIL] subtest: elementFromPoint-float-in-relative
  • OK /css/cssom-view/elementFromPoint-list-001.html (#23915)
    • FAIL [expected PASS] subtest: <li>Inside 2</li>
    • FAIL [expected PASS] subtest: <li>Inside 3</li>
    • FAIL [expected PASS] subtest: <li>Image Inside 1</li>
    • FAIL [expected PASS] subtest: <li>Image Inside 2</li>
  • OK /css/cssom-view/elementsFromPoint-simple.html
    • FAIL [expected PASS] subtest: elementsFromPoint for each corner of a simple div
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • PASS [expected FAIL] subtest: Instant scrolling while doing history navigation.
    • PASS [expected FAIL] subtest: Smooth scrolling while doing history navigation.
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html (#29050)
    • PASS [expected FAIL] subtest: <a> tag navigate fails for unparseable URLs
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
    • FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored
  • TIMEOUT [expected OK] /html/browsers/history/the-history-interface/traverse-during-unload.html (#28688)
    • TIMEOUT [expected PASS] subtest: Traversing the history during unload
  • OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
    • PASS [expected FAIL] subtest: first argument: absolute url
  • TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
    • TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
    • NOTRUN [expected FAIL] subtest: Area element should support autofocus
  • TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
    • TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise
    • TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise
  • TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events.html (#26371)
    • TIMEOUT [expected FAIL] subtest: delayed handling: delaying handling rejected promise created from createImageBitmap will cause both events to fire
  • TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
  • TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
Stable unexpected results that are known to be intermittent (22)
  • OK /_mozilla/css/stylesheet_media_queries.html (#17159)
    • FAIL [expected PASS] subtest: Media queries within stylesheets
  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-relpos-zindex.html (#29052)
    • PASS [expected FAIL] subtest: block-in-inline-hittest-relpos-zindex
  • OK /css/CSS2/normal-flow/hit-test-anonymous-block.html (#25807)
    • PASS [expected FAIL] subtest: Hit test beside line of text inside anonymous block
  • OK /css/css-transitions/properties-value-inherit-003.html (#26435)
    • PASS [expected FAIL] subtest: border-top-width length-em(em) / events
    • PASS [expected FAIL] subtest: border-right-width length-em(em) / events
    • PASS [expected FAIL] subtest: border-bottom-width length-em(em) / events
    • PASS [expected FAIL] subtest: border-left-width length-em(em) / events
    • PASS [expected FAIL] subtest: padding-bottom length-em(em) / events
    • PASS [expected FAIL] subtest: padding-left length-em(em) / events
    • PASS [expected FAIL] subtest: padding-right length-em(em) / events
    • PASS [expected FAIL] subtest: padding-top length-em(em) / events
    • PASS [expected FAIL] subtest: margin-bottom length-em(em) / events
    • PASS [expected FAIL] subtest: margin-left length-em(em) / events
    • And 19 more unexpected results...
  • OK [expected CRASH] /css/cssom-view/elementFromPoint-dynamic-anon-box.html (#22337)
  • OK /css/cssom-view/elementsFromPoint-invalid-cases.html (#21338)
    • FAIL [expected PASS] subtest: The root element is the last element returned for otherwise empty queries within the viewport
  • OK [expected TIMEOUT] /fetch/local-network-access/iframe.tentative.https.window.html (#29605)
    • FAIL [expected TIMEOUT] subtest: public to local, grandparent navigates: success.
  • TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
    • FAIL [expected PASS] subtest: border-image sec-fetch-mode - Not sent to non-trustworthy same-site destination
    • PASS [expected TIMEOUT] subtest: background-image sec-fetch-dest - Not sent to non-trustworthy same-origin destination
    • FAIL [expected PASS] subtest: border-image sec-fetch-dest - Not sent to non-trustworthy cross-site destination
    • FAIL [expected PASS] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent)
  • ERROR [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html (#28541)
  • TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-no-beforeunload.window.html (#29055)
    • PASS [expected FAIL] subtest: Navigating an opened window with an iframe via location.href to a javascript: URL must not fire beforeunload on the iframe: undefined completion
    • TIMEOUT [expected PASS] subtest: Navigating an opened window via location.href to a javascript: URL must not fire beforeunload: string completion
    • NOTRUN [expected FAIL] subtest: Navigating an opened window with an iframe via location.href to a javascript: URL must not fire beforeunload on the iframe: string completion
  • OK /html/browsers/browsing-the-web/read-media/pageload-image-in-popup.html (#23849)
    • FAIL [expected PASS] subtest: The document for a standalone media file should have one child in the body.
  • OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
  • OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
    • FAIL [expected TIMEOUT] subtest: <dialog> can contain autofocus, without stopping page autofocus content from working
    • FAIL [expected NOTRUN] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if
      allow-popups-to-escape-sandbox is used
  • OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
  • OK /html/semantics/forms/historical.html (#28568)
    • FAIL [expected PASS] subtest: <input name=isindex> should not be supported
  • TIMEOUT [expected OK] /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
    • NOTRUN [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load
  • OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
    • PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
  • TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
    • TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise
    • TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise
  • OK [expected ERROR] /resource-timing/cors-preflight.any.html (#28694)
    • FAIL [expected TIMEOUT] subtest: PerformanceResourceTiming sizes fetch with preflight test
  • OK [expected TIMEOUT] /webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html (#21743)

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: mrobinson
Pushing 1f3837d to master...

@bors-servo bors-servo merged commit 1f3837d into master Apr 11, 2023
30 checks passed
@bors-servo bors-servo deleted the fix-nightly-build branch April 11, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly job is failing for all platforms.
3 participants
@mukilan @bors-servo @mrobinson