Catch more exceptions when delivering build notifications #29647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that catching ImportError isn't enough, so we must catch any type of exception when trying to deliver a build notification. Fixes servo#29645.
jdm
approved these changes
Apr 22, 2023
|
@bors-servo r+ |
|
📌 Commit ef8359d has been approved by |
bors-servo
added a commit
that referenced
this pull request
Apr 22, 2023
…r=jdm Catch more exceptions when delivering build notifications It seems that catching ImportError isn't enough, so we must catch any type of exception when trying to deliver a build notification. Fixes #29645. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they fix a small build infrastructure issue. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Results from try job (#4772687572): Flaky unexpected result (25)
Stable unexpected results that are known to be intermittent (19)
|
|
💔 Test failed - checks-github |
|
@bors-servo retry |
|
Results from try job (#4780145081): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (22)
|
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that catching ImportError isn't enough, so we must catch any type of exception when trying to deliver a build notification.
Fixes #29645.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors