Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support text-indent in layout-2020 #29650

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

Loirooriol
Copy link
Contributor

@Loirooriol Loirooriol commented Apr 20, 2023

Existing WPT now passing:

  • _mozilla/css/text_indent_a.html
  • css/CSS2/css1/c71-fwd-parsing-002.xht
  • css/CSS2/css1/c71-fwd-parsing-004.xht
  • css/CSS2/floats-clear/floats-138.xht
  • css/CSS2/text/text-indent-007.xht
  • css/CSS2/text/text-indent-008.xht
  • css/CSS2/text/text-indent-010.xht
  • css/CSS2/text/text-indent-019.xht
  • css/CSS2/text/text-indent-020.xht
  • css/CSS2/text/text-indent-031.xht
  • css/CSS2/text/text-indent-032.xht
  • css/CSS2/text/text-indent-043.xht
  • css/CSS2/text/text-indent-044.xht
  • css/CSS2/text/text-indent-055.xht
  • css/CSS2/text/text-indent-056.xht
  • css/CSS2/text/text-indent-067.xht
  • css/CSS2/text/text-indent-068.xht
  • css/CSS2/text/text-indent-079.xht
  • css/CSS2/text/text-indent-080.xht
  • css/CSS2/text/text-indent-091.xht
  • css/CSS2/text/text-indent-092.xht
  • css/CSS2/text/text-indent-103.xht
  • css/CSS2/text/text-indent-104.xht
  • css/CSS2/text/text-indent-112.xht
  • css/CSS2/text/text-indent-113.xht
  • css/CSS2/text/text-indent-115.xht
  • css/CSS2/text/text-indent-applies-to-002.xht
  • css/CSS2/text/text-indent-applies-to-003.xht
  • css/CSS2/text/text-indent-applies-to-005.xht
  • css/CSS2/text/text-indent-applies-to-006.xht
  • css/CSS2/text/text-indent-applies-to-007.xht
  • css/CSS2/text/text-indent-applies-to-008.xht
  • css/CSS2/text/text-indent-applies-to-009.xht
  • css/CSS2/text/text-indent-applies-to-010.xht
  • css/CSS2/text/text-indent-applies-to-011.xht
  • css/CSS2/text/text-indent-applies-to-014.xht
  • css/CSS2/text/text-indent-applies-to-015.xht
  • css/CSS2/text/text-indent-inherited-001.xht
  • css/CSS2/text/text-indent-overflow-001.xht
  • css/CSS2/text/text-indent-overflow-002.xht
  • css/CSS2/text/text-indent-overflow-003.xht
  • css/CSS2/text/text-indent-overflow-004.xht
  • css/CSS2/text/text-indent-wrap-001.xht
  • css/css-text-decor/text-shadow/textindent.html
  • css/css-text/text-indent/text-indent-percentage-001.xht
  • css/css-text/text-indent/text-indent-percentage-002.html
  • css/css-text/text-indent/text-indent-percentage-003.html
  • css/css-text/text-indent/text-indent-percentage-004.html
  • css/css-values/minmax-length-percent-serialize.html
  • css/css-values/minmax-length-serialize.html

Also improvements in:

  • _mozilla/mozilla/calc.html
  • css/css-text/animations/text-indent-interpolation.html
  • css/css-text/inheritance.html
  • css/css-text/parsing/text-indent-computed.html
  • css/css-text/parsing/text-indent-valid.html
  • css/css-transitions/properties-value-implicit-001.html
  • css/css-values/animations/calc-interpolation.html
  • css/css-values/minmax-percentage-serialize.html
  • css/css-values/viewport-units-css2-001.html
  • css/css-variables/variable-substitution-basic.html
  • css/cssom/serialize-values.html

Existing WPT now failing, due to lack of direction, outside list markers,
flex and grid:

  • css/CSS2/text/text-indent-rtl-001.xht
  • css/CSS2/text/text-indent-rtl-002.xht
  • css/css-pseudo/marker-content-023.html
  • css/css-text/text-indent/anonymous-flex-item-001.html
  • css/css-text/text-indent/anonymous-grid-item-001.html

New WPT tests:

  • css/css-text/text-indent/text-indent-length-001.html
  • css/css-text/text-indent/text-indent-length-002.html
    This one fails in layout-2013.

  • There are tests for these changes OR
  • These changes do not require tests because ___

@servo-wpt-sync
Copy link
Collaborator

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#39627) with upstreamable changes.

@servo-wpt-sync
Copy link
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#39627).

@Loirooriol
Copy link
Contributor Author

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 4403b13 with merge ad852a3...

bors-servo added a commit that referenced this pull request Apr 21, 2023
Support text-indent in layout-2020

Existing WPT now passing:
  - css/css-text/text-indent/text-indent-percentage-002.html
  - css/css-text/text-indent/text-indent-percentage-003.html
  - css/css-text/text-indent/text-indent-percentage-004.html

Existing WPT now failing, due to lack of flex and grid:
  - css/css-text/text-indent/anonymous-flex-item-001.html
  - css/css-text/text-indent/anonymous-grid-item-001.html

This test was already failing due to tabs, but wasn't tracked:
  - css/css-text/text-indent/text-indent-tab-positions-001.html

New WPT tests:
 - css/css-text/text-indent/text-indent-length-001.html
 - css/css-text/text-indent/text-indent-length-002.html This one fails in layout-2013.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #29649 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@servo-wpt-sync
Copy link
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#39627).

@servo-wpt-sync
Copy link
Collaborator

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#39627) title and body.

@Loirooriol
Copy link
Contributor Author

I have identified various other tests that need to have their expectation updated, let's see if bors-servo finds the rest.

@github-actions
Copy link

Results from try job (#4767637030):

Flaky unexpected result (18)
  • OK /_mozilla/mozilla/scrollBy.html (#21321)
    • PASS [expected FAIL] subtest: Ensure that the window.scrollBy function affects scroll position as expected
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance2/glsl3/compound-assignment-type-combination.html
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/CSS2/floats/hit-test-floats-003.html (#25733)
    • PASS [expected FAIL] subtest: Miss float below something else
  • OK /css/CSS2/floats/hit-test-floats-005.html (#25804)
    • PASS [expected FAIL] subtest: Miss clipped float
  • OK /css/CSS2/normal-flow/hit-test-anonymous-block.html (#25807)
    • FAIL [expected PASS] subtest: Hit test beside line of text inside anonymous block
  • FAIL [expected PASS] /css/css-text/line-breaking/segment-break-transformation-unremovable-2.html (#28758)
  • OK /css/css-transitions/properties-value-inherit-002.html (#21486)
    • FAIL [expected PASS] subtest: color color(rgba) / values
    • FAIL [expected PASS] subtest: font-size length(pt) / values
    • FAIL [expected PASS] subtest: font-size length(pc) / values
    • FAIL [expected PASS] subtest: font-size length(px) / values
    • FAIL [expected PASS] subtest: font-size length(em) / values
    • FAIL [expected PASS] subtest: font-size length(ex) / values
    • FAIL [expected PASS] subtest: font-size length(mm) / values
    • FAIL [expected PASS] subtest: font-size length(cm) / values
    • FAIL [expected PASS] subtest: font-size length(in) / values
    • FAIL [expected PASS] subtest: font-size percentage(%) / values
    • And 40 more unexpected results...
  • OK /css/cssom-view/elementFromPosition.html (#21295)
    • PASS [expected FAIL] subtest: test some point of the element: top left corner
  • TIMEOUT /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-no-beforeunload.window.html (#29055)
    • TIMEOUT [expected PASS] subtest: Navigating an opened window via location.href to a javascript: URL must not fire beforeunload: undefined completion
    • NOTRUN [expected FAIL] subtest: Navigating an opened window with an iframe via location.href to a javascript: URL must not fire beforeunload on the iframe: undefined completion
    • NOTRUN [expected PASS] subtest: Navigating an iframe via location.href to a javascript: URL must not fire beforeunload: string completion
    • NOTRUN [expected PASS] subtest: Navigating an iframe via src="" to a javascript: URL after insertion must not fire beforeunload: string completion
    • NOTRUN [expected TIMEOUT] subtest: Navigating an opened window via location.href to a javascript: URL must not fire beforeunload: string completion
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
    • TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
      allow-popups-to-escape-sandbox is used
  • TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html
    • TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
  • TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
    • TIMEOUT [expected FAIL] subtest: Sanity check: this all works as expected with no promises involved
    • TIMEOUT [expected FAIL] subtest: Fulfillment handler on fulfilled promise
    • TIMEOUT [expected FAIL] subtest: Rejection handler on rejected promise
    • TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise
    • TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise
  • TIMEOUT [expected CRASH] /webmessaging/broadcastchannel/cross-partition.https.tentative.html (#29058)
  • TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
  • TIMEOUT [expected OK] /webmessaging/with-ports/018.html (#24485)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
  • TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
Stable unexpected results that are known to be intermittent (15)
  • TIMEOUT /FileAPI/url/url-charset.window.html (#26997)
    • TIMEOUT [expected PASS] subtest: Blob charset should override <meta charset>.
  • TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
    • FAIL [expected TIMEOUT] subtest: Opening a blob URL in a new window immediately before revoking it works.
  • OK /css/CSS2/floats/hit-test-floats-001.html (#23693)
    • PASS [expected FAIL] subtest: hit-test-floats-001
  • OK /css/cssom-view/CaretPosition-001.html (#21338)
    • PASS [expected FAIL] subtest: Element at (400, 100)
  • TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
    • PASS [expected FAIL] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent)
  • TIMEOUT /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
    • FAIL [expected TIMEOUT] subtest: Navigating to a different document with link click
    • TIMEOUT [expected NOTRUN] subtest: Navigating to a different document with form submission
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
    • FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
    • FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
  • OK /html/browsers/browsing-the-web/read-media/pageload-image-in-popup.html (#23849)
    • FAIL [expected PASS] subtest: The document for a standalone media file should have one child in the body.
  • OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
    • FAIL [expected PASS] subtest: first argument: absolute url
  • CRASH [expected OK] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
    • TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
      allow-popups-to-escape-sandbox is used
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
    • FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
    • PASS [expected FAIL] subtest: createHTMLDocument
    • PASS [expected FAIL] subtest: <template>
  • TIMEOUT [expected OK] /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
    • NOTRUN [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load
  • TIMEOUT [expected OK] /webaudio/the-audio-api/the-audiocontext-interface/audiocontext-not-fully-active.html (#27664)

@bors-servo
Copy link
Contributor

💥 Test timed out

@Loirooriol
Copy link
Contributor Author

@bors-servo try=wpt-2020

@bors-servo
Copy link
Contributor

⌛ Trying commit 63b0c45 with merge 0d7585b...

bors-servo added a commit that referenced this pull request Apr 22, 2023
Support text-indent in layout-2020

Existing WPT now passing:
  - css/CSS2/floats-clear/floats-138.xht
  - css/CSS2/text/text-indent-007.xht
  - css/CSS2/text/text-indent-008.xht
  - css/CSS2/text/text-indent-010.xht
  - css/CSS2/text/text-indent-019.xht
  - css/CSS2/text/text-indent-020.xht
  - css/CSS2/text/text-indent-031.xht
  - css/CSS2/text/text-indent-032.xht
  - css/CSS2/text/text-indent-043.xht
  - css/CSS2/text/text-indent-044.xht
  - css/CSS2/text/text-indent-055.xht
  - css/CSS2/text/text-indent-056.xht
  - css/CSS2/text/text-indent-067.xht
  - css/CSS2/text/text-indent-068.xht
  - css/CSS2/text/text-indent-079.xht
  - css/CSS2/text/text-indent-080.xht
  - css/CSS2/text/text-indent-091.xht
  - css/CSS2/text/text-indent-092.xht
  - css/CSS2/text/text-indent-103.xht
  - css/CSS2/text/text-indent-104.xht
  - css/CSS2/text/text-indent-112.xht
  - css/CSS2/text/text-indent-113.xht
  - css/CSS2/text/text-indent-115.xht
  - css/CSS2/text/text-indent-applies-to-002.xht
  - css/CSS2/text/text-indent-applies-to-003.xht
  - css/CSS2/text/text-indent-applies-to-005.xht
  - css/CSS2/text/text-indent-applies-to-006.xht
  - css/CSS2/text/text-indent-applies-to-007.xht
  - css/CSS2/text/text-indent-applies-to-008.xht
  - css/CSS2/text/text-indent-applies-to-009.xht
  - css/CSS2/text/text-indent-applies-to-010.xht
  - css/CSS2/text/text-indent-applies-to-011.xht
  - css/CSS2/text/text-indent-applies-to-014.xht
  - css/CSS2/text/text-indent-applies-to-015.xht
  - css/CSS2/text/text-indent-inherited-001.xht
  - css/CSS2/text/text-indent-overflow-001.xht
  - css/CSS2/text/text-indent-overflow-002.xht
  - css/CSS2/text/text-indent-overflow-003.xht
  - css/CSS2/text/text-indent-overflow-004.xht
  - css/CSS2/text/text-indent-wrap-001.xht
  - css/css-text-decor/text-shadow/textindent.html
  - css/css-text/text-indent/text-indent-percentage-002.html
  - css/css-text/text-indent/text-indent-percentage-003.html
  - css/css-text/text-indent/text-indent-percentage-004.html
  - css/css-values/minmax-length-percent-serialize.html
  - css/css-values/minmax-length-serialize.html

Also improvements in:
  - css/css-text/animations/text-indent-interpolation.html
  - css/css-text/inheritance.html
  - css/css-text/parsing/text-indent-computed.html
  - css/css-text/parsing/text-indent-valid.html
  - css/css-values/animations/calc-interpolation.html
  - css/css-values/minmax-percentage-serialize.html
  - css/css-values/viewport-units-css2-001.html
  - css/cssom/serialize-values.html

Existing WPT now failing, due to lack of direction, flex and grid:
  - css/CSS2/text/text-indent-rtl-001.xht
  - css/CSS2/text/text-indent-rtl-002.xht
  - css/css-text/text-indent/anonymous-flex-item-001.html
  - css/css-text/text-indent/anonymous-grid-item-001.html

This test was already failing due to tabs, but wasn't tracked:
  - css/css-text/text-indent/text-indent-tab-positions-001.html

New WPT tests:
 - css/css-text/text-indent/text-indent-length-001.html
 - css/css-text/text-indent/text-indent-length-002.html
   This one fails in layout-2013.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #29649 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@servo-wpt-sync
Copy link
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#39627).

@servo-wpt-sync
Copy link
Collaborator

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#39627) title and body.

@servo-wpt-sync
Copy link
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#39627).

@Loirooriol
Copy link
Contributor Author

@servo-wpt-sync
Copy link
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#39627).

@Loirooriol
Copy link
Contributor Author

@bors-servo try=wpt-2020

@bors-servo
Copy link
Contributor

⌛ Trying commit 0cb8154 with merge 40ac395...

bors-servo added a commit that referenced this pull request Apr 25, 2023
Support text-indent in layout-2020

Existing WPT now passing:
  - css/CSS2/floats-clear/floats-138.xht
  - css/CSS2/text/text-indent-007.xht
  - css/CSS2/text/text-indent-008.xht
  - css/CSS2/text/text-indent-010.xht
  - css/CSS2/text/text-indent-019.xht
  - css/CSS2/text/text-indent-020.xht
  - css/CSS2/text/text-indent-031.xht
  - css/CSS2/text/text-indent-032.xht
  - css/CSS2/text/text-indent-043.xht
  - css/CSS2/text/text-indent-044.xht
  - css/CSS2/text/text-indent-055.xht
  - css/CSS2/text/text-indent-056.xht
  - css/CSS2/text/text-indent-067.xht
  - css/CSS2/text/text-indent-068.xht
  - css/CSS2/text/text-indent-079.xht
  - css/CSS2/text/text-indent-080.xht
  - css/CSS2/text/text-indent-091.xht
  - css/CSS2/text/text-indent-092.xht
  - css/CSS2/text/text-indent-103.xht
  - css/CSS2/text/text-indent-104.xht
  - css/CSS2/text/text-indent-112.xht
  - css/CSS2/text/text-indent-113.xht
  - css/CSS2/text/text-indent-115.xht
  - css/CSS2/text/text-indent-applies-to-002.xht
  - css/CSS2/text/text-indent-applies-to-003.xht
  - css/CSS2/text/text-indent-applies-to-005.xht
  - css/CSS2/text/text-indent-applies-to-006.xht
  - css/CSS2/text/text-indent-applies-to-007.xht
  - css/CSS2/text/text-indent-applies-to-008.xht
  - css/CSS2/text/text-indent-applies-to-009.xht
  - css/CSS2/text/text-indent-applies-to-010.xht
  - css/CSS2/text/text-indent-applies-to-011.xht
  - css/CSS2/text/text-indent-applies-to-014.xht
  - css/CSS2/text/text-indent-applies-to-015.xht
  - css/CSS2/text/text-indent-inherited-001.xht
  - css/CSS2/text/text-indent-overflow-001.xht
  - css/CSS2/text/text-indent-overflow-002.xht
  - css/CSS2/text/text-indent-overflow-003.xht
  - css/CSS2/text/text-indent-overflow-004.xht
  - css/CSS2/text/text-indent-wrap-001.xht
  - css/css-text-decor/text-shadow/textindent.html
  - css/css-text/text-indent/text-indent-percentage-002.html
  - css/css-text/text-indent/text-indent-percentage-003.html
  - css/css-text/text-indent/text-indent-percentage-004.html
  - css/css-values/minmax-length-percent-serialize.html
  - css/css-values/minmax-length-serialize.html

Also improvements in:
  - css/css-text/animations/text-indent-interpolation.html
  - css/css-text/inheritance.html
  - css/css-text/parsing/text-indent-computed.html
  - css/css-text/parsing/text-indent-valid.html
  - css/css-transitions/properties-value-implicit-001.html
  - css/css-values/animations/calc-interpolation.html
  - css/css-values/minmax-percentage-serialize.html
  - css/css-values/viewport-units-css2-001.html
  - css/css-variables/variable-substitution-basic.html
  - css/cssom/serialize-values.html

Existing WPT now failing, due to lack of direction, outside list markers,
flex and grid:
  - css/CSS2/text/text-indent-rtl-001.xht
  - css/CSS2/text/text-indent-rtl-002.xht
  - css/css-pseudo/marker-content-023.html
  - css/css-text/text-indent/anonymous-flex-item-001.html
  - css/css-text/text-indent/anonymous-grid-item-001.html

This test was already failing due to tabs, but wasn't tracked:
  - css/css-text/text-indent/text-indent-tab-positions-001.html

New WPT tests:
 - css/css-text/text-indent/text-indent-length-001.html
 - css/css-text/text-indent/text-indent-length-002.html
   This one fails in layout-2013.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #29649 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@github-actions
Copy link

Results from try job (#4799729797):

Flaky unexpected result (4)
  • TIMEOUT [expected FAIL] /css/CSS2/floats-clear/float-replaced-width-004.xht
  • OK /css/CSS2/floats/hit-test-floats-003.html (#25733)
    • PASS [expected FAIL] subtest: Miss float below something else
  • OK /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
    • FAIL [expected PASS] subtest: addEventListener "once" option is respected
  • OK /css/cssom-view/elementFromPoint-003.html (#26924)
    • PASS [expected FAIL] subtest: Checking whether dynamic changes to visibility interact correctly with
      table anonymous boxes
Stable unexpected results that are known to be intermittent (12)
  • OK /_mozilla/mozilla/scrollBy.html (#21321)
    • FAIL [expected PASS] subtest: Ensure that the window.scrollBy function affects scroll position as expected
  • OK /css/CSS2/floats/hit-test-floats-001.html (#23693)
    • FAIL [expected PASS] subtest: hit-test-floats-001
  • OK /css/css-transitions/properties-value-001.html (#21486)
    • PASS [expected FAIL] subtest: background-color color(rgba) / values
    • PASS [expected FAIL] subtest: border-top-width length(pt) / values
    • PASS [expected FAIL] subtest: border-top-width length(pc) / values
    • PASS [expected FAIL] subtest: border-top-width length(px) / values
    • PASS [expected FAIL] subtest: border-top-width length(em) / values
    • PASS [expected FAIL] subtest: border-top-width length(ex) / values
    • PASS [expected FAIL] subtest: border-top-width length(mm) / values
    • PASS [expected FAIL] subtest: border-top-width length(cm) / values
    • PASS [expected FAIL] subtest: border-top-width length(in) / values
    • PASS [expected FAIL] subtest: border-right-width length(pt) / values
    • And 49 more unexpected results...
  • OK /css/css-transitions/properties-value-implicit-001.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
  • OK /css/css-transitions/properties-value-inherit-001.html (#21486)
    • PASS [expected FAIL] subtest: background-color color(rgba) / events
    • PASS [expected FAIL] subtest: border-top-width length(pt) / events
    • PASS [expected FAIL] subtest: border-top-width length(pc) / events
    • PASS [expected FAIL] subtest: border-top-width length(px) / events
    • PASS [expected FAIL] subtest: border-top-width length(em) / events
    • PASS [expected FAIL] subtest: border-top-width length(ex) / events
    • PASS [expected FAIL] subtest: border-top-width length(mm) / events
    • PASS [expected FAIL] subtest: border-top-width length(cm) / events
    • PASS [expected FAIL] subtest: border-top-width length(in) / events
    • PASS [expected FAIL] subtest: border-right-width length(pt) / events
    • And 49 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-002.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length(pt) / values
    • PASS [expected FAIL] subtest: text-indent length(pt) / events
    • PASS [expected FAIL] subtest: text-indent length(pc) / values
    • PASS [expected FAIL] subtest: text-indent length(pc) / events
    • PASS [expected FAIL] subtest: text-indent length(px) / values
    • PASS [expected FAIL] subtest: text-indent length(px) / events
    • PASS [expected FAIL] subtest: text-indent length(em) / values
    • PASS [expected FAIL] subtest: text-indent length(em) / events
    • PASS [expected FAIL] subtest: text-indent length(ex) / values
    • PASS [expected FAIL] subtest: text-indent length(ex) / events
    • And 8 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-003.html (#26435)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
    • PASS [expected FAIL] subtest: text-indent length-em(em) / events
  • OK /css/cssom-view/elementFromPoint-ellipsis-in-inline-box.html (#27414)
    • FAIL [expected PASS] subtest: elementFromPoint-ellipsis-in-inline-box
  • OK /css/cssom-view/elementFromPoint-float-in-relative.html (#27753)
    • FAIL [expected PASS] subtest: elementFromPoint-float-in-relative
  • OK /css/cssom-view/elementFromPoint-visibility-hidden-resizer.html (#28695)
    • PASS [expected FAIL] subtest: elementFromPoint on resizer area of an element with visibility:hidden
  • OK /css/cssom-view/elementFromPosition.html (#21295)
    • PASS [expected FAIL] subtest: test the top of layer
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • FAIL [expected PASS] subtest: Instant scrolling while doing history navigation.
Stable unexpected results (6)
  • PASS [expected FAIL] /_mozilla/css/text_indent_a.html
  • OK /_mozilla/mozilla/calc.html
    • PASS [expected FAIL] subtest: calc for text-indent
  • FAIL [expected PASS] /_mozilla/mozilla/sslfail.html
  • ERROR [expected OK] /_mozilla/mozilla/websocket_disconnect.html
    • TIMEOUT [expected PASS] subtest: Web socket doesn't panic when worker disappears
  • PASS [expected FAIL] /css/CSS2/css1/c71-fwd-parsing-002.xht
  • PASS [expected FAIL] /css/CSS2/css1/c71-fwd-parsing-004.xht

@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@servo-wpt-sync
Copy link
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#39627).

@Loirooriol
Copy link
Contributor Author

Loirooriol commented Apr 25, 2023

_mozilla/mozilla/sslfail.html and _mozilla/mozilla/websocket_disconnect.html are unrelated (flaky?)...

@Loirooriol
Copy link
Contributor Author

@bors-servo try=wpt-2020

@bors-servo
Copy link
Contributor

⌛ Trying commit 3dcd978 with merge 2e62cfd...

bors-servo added a commit that referenced this pull request Apr 25, 2023
Support text-indent in layout-2020

Existing WPT now passing:
  - css/CSS2/floats-clear/floats-138.xht
  - css/CSS2/text/text-indent-007.xht
  - css/CSS2/text/text-indent-008.xht
  - css/CSS2/text/text-indent-010.xht
  - css/CSS2/text/text-indent-019.xht
  - css/CSS2/text/text-indent-020.xht
  - css/CSS2/text/text-indent-031.xht
  - css/CSS2/text/text-indent-032.xht
  - css/CSS2/text/text-indent-043.xht
  - css/CSS2/text/text-indent-044.xht
  - css/CSS2/text/text-indent-055.xht
  - css/CSS2/text/text-indent-056.xht
  - css/CSS2/text/text-indent-067.xht
  - css/CSS2/text/text-indent-068.xht
  - css/CSS2/text/text-indent-079.xht
  - css/CSS2/text/text-indent-080.xht
  - css/CSS2/text/text-indent-091.xht
  - css/CSS2/text/text-indent-092.xht
  - css/CSS2/text/text-indent-103.xht
  - css/CSS2/text/text-indent-104.xht
  - css/CSS2/text/text-indent-112.xht
  - css/CSS2/text/text-indent-113.xht
  - css/CSS2/text/text-indent-115.xht
  - css/CSS2/text/text-indent-applies-to-002.xht
  - css/CSS2/text/text-indent-applies-to-003.xht
  - css/CSS2/text/text-indent-applies-to-005.xht
  - css/CSS2/text/text-indent-applies-to-006.xht
  - css/CSS2/text/text-indent-applies-to-007.xht
  - css/CSS2/text/text-indent-applies-to-008.xht
  - css/CSS2/text/text-indent-applies-to-009.xht
  - css/CSS2/text/text-indent-applies-to-010.xht
  - css/CSS2/text/text-indent-applies-to-011.xht
  - css/CSS2/text/text-indent-applies-to-014.xht
  - css/CSS2/text/text-indent-applies-to-015.xht
  - css/CSS2/text/text-indent-inherited-001.xht
  - css/CSS2/text/text-indent-overflow-001.xht
  - css/CSS2/text/text-indent-overflow-002.xht
  - css/CSS2/text/text-indent-overflow-003.xht
  - css/CSS2/text/text-indent-overflow-004.xht
  - css/CSS2/text/text-indent-wrap-001.xht
  - css/css-text-decor/text-shadow/textindent.html
  - css/css-text/text-indent/text-indent-percentage-002.html
  - css/css-text/text-indent/text-indent-percentage-003.html
  - css/css-text/text-indent/text-indent-percentage-004.html
  - css/css-values/minmax-length-percent-serialize.html
  - css/css-values/minmax-length-serialize.html

Also improvements in:
  - css/css-text/animations/text-indent-interpolation.html
  - css/css-text/inheritance.html
  - css/css-text/parsing/text-indent-computed.html
  - css/css-text/parsing/text-indent-valid.html
  - css/css-transitions/properties-value-implicit-001.html
  - css/css-values/animations/calc-interpolation.html
  - css/css-values/minmax-percentage-serialize.html
  - css/css-values/viewport-units-css2-001.html
  - css/css-variables/variable-substitution-basic.html
  - css/cssom/serialize-values.html

Existing WPT now failing, due to lack of direction, outside list markers,
flex and grid:
  - css/CSS2/text/text-indent-rtl-001.xht
  - css/CSS2/text/text-indent-rtl-002.xht
  - css/css-pseudo/marker-content-023.html
  - css/css-text/text-indent/anonymous-flex-item-001.html
  - css/css-text/text-indent/anonymous-grid-item-001.html

This test was already failing due to tabs, but wasn't tracked:
  - css/css-text/text-indent/text-indent-tab-positions-001.html

New WPT tests:
 - css/css-text/text-indent/text-indent-length-001.html
 - css/css-text/text-indent/text-indent-length-002.html
   This one fails in layout-2013.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #29649 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@github-actions
Copy link

Results from try job (#4800462217):

Flaky unexpected result (8)
  • TIMEOUT [expected PASS] /css/CSS2/box-display/insert-block-in-blocks-n-inlines-begin-002.xht
  • OK /css/CSS2/floats/hit-test-floats-003.html (#25733)
    • PASS [expected FAIL] subtest: Miss float below something else
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-float-001.html (#29565)
    • FAIL [expected PASS] subtest: block-in-inline-hittest-float-001
  • OK /css/css-flexbox/hittest-before-pseudo.html (#26521)
    • PASS [expected FAIL] subtest: Hit-testing text within a pseudo-element flex-item should return the flexbox as the hittest result.
  • OK /css/cssom-view/CaretPosition-001.html (#21338)
    • PASS [expected FAIL] subtest: Element at (400, 100)
  • OK /css/cssom-view/elementFromPoint-float-in-table.html (#27002)
    • PASS [expected FAIL] subtest: float-in-div
  • OK /css/cssom-view/elementFromPoint-visibility-hidden-resizer.html (#28695)
    • PASS [expected FAIL] subtest: elementFromPoint on resizer area of an element with visibility:hidden
  • OK /css/cssom-view/elementFromPosition.html (#21295)
    • PASS [expected FAIL] subtest: test some point of the element: top left corner
Stable unexpected results that are known to be intermittent (9)
  • OK /_mozilla/mozilla/scrollBy.html (#21321)
    • FAIL [expected PASS] subtest: Ensure that the window.scrollBy function affects scroll position as expected
  • OK /css/CSS2/floats/hit-test-floats-001.html (#23693)
    • FAIL [expected PASS] subtest: hit-test-floats-001
  • OK /css/css-transitions/properties-value-001.html (#21486)
    • PASS [expected FAIL] subtest: background-color color(rgba) / values
    • PASS [expected FAIL] subtest: border-top-width length(pt) / values
    • PASS [expected FAIL] subtest: border-top-width length(pc) / values
    • PASS [expected FAIL] subtest: border-top-width length(px) / values
    • PASS [expected FAIL] subtest: border-top-width length(em) / values
    • PASS [expected FAIL] subtest: border-top-width length(ex) / values
    • PASS [expected FAIL] subtest: border-top-width length(mm) / values
    • PASS [expected FAIL] subtest: border-top-width length(cm) / values
    • PASS [expected FAIL] subtest: border-top-width length(in) / values
    • PASS [expected FAIL] subtest: border-right-width length(pt) / values
    • And 49 more unexpected results...
  • OK /css/css-transitions/properties-value-implicit-001.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
  • OK /css/css-transitions/properties-value-inherit-001.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length(pt) / values
    • PASS [expected FAIL] subtest: text-indent length(pt) / events
    • PASS [expected FAIL] subtest: text-indent length(pc) / values
    • PASS [expected FAIL] subtest: text-indent length(pc) / events
    • PASS [expected FAIL] subtest: text-indent length(px) / values
    • PASS [expected FAIL] subtest: text-indent length(px) / events
    • PASS [expected FAIL] subtest: text-indent length(em) / values
    • PASS [expected FAIL] subtest: text-indent length(em) / events
    • PASS [expected FAIL] subtest: text-indent length(ex) / values
    • PASS [expected FAIL] subtest: text-indent length(ex) / events
    • And 8 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-002.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length(pt) / values
    • PASS [expected FAIL] subtest: text-indent length(pt) / events
    • PASS [expected FAIL] subtest: text-indent length(pc) / values
    • PASS [expected FAIL] subtest: text-indent length(pc) / events
    • PASS [expected FAIL] subtest: text-indent length(px) / values
    • PASS [expected FAIL] subtest: text-indent length(px) / events
    • PASS [expected FAIL] subtest: text-indent length(em) / values
    • PASS [expected FAIL] subtest: text-indent length(em) / events
    • PASS [expected FAIL] subtest: text-indent length(ex) / values
    • PASS [expected FAIL] subtest: text-indent length(ex) / events
    • And 8 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-003.html (#26435)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
    • PASS [expected FAIL] subtest: text-indent length-em(em) / events
  • OK /css/cssom-view/elementFromPoint-ellipsis-in-inline-box.html (#27414)
    • FAIL [expected PASS] subtest: elementFromPoint-ellipsis-in-inline-box
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • FAIL [expected PASS] subtest: Instant scrolling while doing history navigation.
Stable unexpected results (2)
  • FAIL [expected PASS] /_mozilla/mozilla/sslfail.html
  • ERROR [expected OK] /_mozilla/mozilla/websocket_disconnect.html
    • TIMEOUT [expected PASS] subtest: Web socket doesn't panic when worker disappears

@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@Loirooriol
Copy link
Contributor Author

@bors-servo try=wpt-2020

@bors-servo
Copy link
Contributor

⌛ Trying commit d990bac with merge 9838c2f...

bors-servo added a commit that referenced this pull request Apr 25, 2023
Support text-indent in layout-2020

Existing WPT now passing:
  - css/CSS2/floats-clear/floats-138.xht
  - css/CSS2/text/text-indent-007.xht
  - css/CSS2/text/text-indent-008.xht
  - css/CSS2/text/text-indent-010.xht
  - css/CSS2/text/text-indent-019.xht
  - css/CSS2/text/text-indent-020.xht
  - css/CSS2/text/text-indent-031.xht
  - css/CSS2/text/text-indent-032.xht
  - css/CSS2/text/text-indent-043.xht
  - css/CSS2/text/text-indent-044.xht
  - css/CSS2/text/text-indent-055.xht
  - css/CSS2/text/text-indent-056.xht
  - css/CSS2/text/text-indent-067.xht
  - css/CSS2/text/text-indent-068.xht
  - css/CSS2/text/text-indent-079.xht
  - css/CSS2/text/text-indent-080.xht
  - css/CSS2/text/text-indent-091.xht
  - css/CSS2/text/text-indent-092.xht
  - css/CSS2/text/text-indent-103.xht
  - css/CSS2/text/text-indent-104.xht
  - css/CSS2/text/text-indent-112.xht
  - css/CSS2/text/text-indent-113.xht
  - css/CSS2/text/text-indent-115.xht
  - css/CSS2/text/text-indent-applies-to-002.xht
  - css/CSS2/text/text-indent-applies-to-003.xht
  - css/CSS2/text/text-indent-applies-to-005.xht
  - css/CSS2/text/text-indent-applies-to-006.xht
  - css/CSS2/text/text-indent-applies-to-007.xht
  - css/CSS2/text/text-indent-applies-to-008.xht
  - css/CSS2/text/text-indent-applies-to-009.xht
  - css/CSS2/text/text-indent-applies-to-010.xht
  - css/CSS2/text/text-indent-applies-to-011.xht
  - css/CSS2/text/text-indent-applies-to-014.xht
  - css/CSS2/text/text-indent-applies-to-015.xht
  - css/CSS2/text/text-indent-inherited-001.xht
  - css/CSS2/text/text-indent-overflow-001.xht
  - css/CSS2/text/text-indent-overflow-002.xht
  - css/CSS2/text/text-indent-overflow-003.xht
  - css/CSS2/text/text-indent-overflow-004.xht
  - css/CSS2/text/text-indent-wrap-001.xht
  - css/css-text-decor/text-shadow/textindent.html
  - css/css-text/text-indent/text-indent-percentage-002.html
  - css/css-text/text-indent/text-indent-percentage-003.html
  - css/css-text/text-indent/text-indent-percentage-004.html
  - css/css-values/minmax-length-percent-serialize.html
  - css/css-values/minmax-length-serialize.html

Also improvements in:
  - css/css-text/animations/text-indent-interpolation.html
  - css/css-text/inheritance.html
  - css/css-text/parsing/text-indent-computed.html
  - css/css-text/parsing/text-indent-valid.html
  - css/css-transitions/properties-value-implicit-001.html
  - css/css-values/animations/calc-interpolation.html
  - css/css-values/minmax-percentage-serialize.html
  - css/css-values/viewport-units-css2-001.html
  - css/css-variables/variable-substitution-basic.html
  - css/cssom/serialize-values.html

Existing WPT now failing, due to lack of direction, outside list markers,
flex and grid:
  - css/CSS2/text/text-indent-rtl-001.xht
  - css/CSS2/text/text-indent-rtl-002.xht
  - css/css-pseudo/marker-content-023.html
  - css/css-text/text-indent/anonymous-flex-item-001.html
  - css/css-text/text-indent/anonymous-grid-item-001.html

This test was already failing due to tabs, but wasn't tracked:
  - css/css-text/text-indent/text-indent-tab-positions-001.html

New WPT tests:
 - css/css-text/text-indent/text-indent-length-001.html
 - css/css-text/text-indent/text-indent-length-002.html
   This one fails in layout-2013.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #29649 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@servo-wpt-sync
Copy link
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#39627).

@github-actions
Copy link

Results from try job (#4800806479):

Flaky unexpected result (7)
  • OK /css/CSS2/floats/hit-test-floats-004.html (#25804)
    • PASS [expected FAIL] subtest: Miss float below something else
  • TIMEOUT [expected PASS] /css/CSS2/fonts/font-size-035.xht
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-001.html (#29064)
    • PASS [expected FAIL] subtest: block-in-inline-hittest-001
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-relpos-zindex.html (#29052)
    • PASS [expected FAIL] subtest: block-in-inline-hittest-relpos-zindex
  • OK /css/cssom-view/CaretPosition-001.html (#21338)
    • PASS [expected FAIL] subtest: Element at (400, 100)
  • OK /css/cssom-view/elementFromPoint-visibility-hidden-resizer.html (#28695)
    • PASS [expected FAIL] subtest: elementFromPoint on resizer area of an element with visibility:hidden
  • OK /css/cssom-view/elementFromPosition.html (#21295)
    • PASS [expected FAIL] subtest: test some point of the element: top left corner
Stable unexpected results that are known to be intermittent (10)
  • OK /_mozilla/mozilla/scrollBy.html (#21321)
    • FAIL [expected PASS] subtest: Ensure that the window.scrollBy function affects scroll position as expected
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-float-001.html (#29565)
    • FAIL [expected PASS] subtest: block-in-inline-hittest-float-001
  • OK /css/css-transforms/transform-scale-hittest.html (#24667)
    • FAIL [expected PASS] subtest: Hit test within unscaled box
  • OK /css/css-transitions/properties-value-001.html (#21486)
    • PASS [expected FAIL] subtest: background-color color(rgba) / values
    • PASS [expected FAIL] subtest: border-top-width length(pt) / values
    • PASS [expected FAIL] subtest: border-top-width length(pc) / values
    • PASS [expected FAIL] subtest: border-top-width length(px) / values
    • PASS [expected FAIL] subtest: border-top-width length(em) / values
    • PASS [expected FAIL] subtest: border-top-width length(ex) / values
    • PASS [expected FAIL] subtest: border-top-width length(mm) / values
    • PASS [expected FAIL] subtest: border-top-width length(cm) / values
    • PASS [expected FAIL] subtest: border-top-width length(in) / values
    • PASS [expected FAIL] subtest: border-right-width length(pt) / values
    • And 49 more unexpected results...
  • OK /css/css-transitions/properties-value-implicit-001.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
  • OK /css/css-transitions/properties-value-inherit-001.html (#21486)
    • PASS [expected FAIL] subtest: background-color color(rgba) / events
    • PASS [expected FAIL] subtest: border-top-width length(pt) / events
    • PASS [expected FAIL] subtest: border-top-width length(pc) / events
    • PASS [expected FAIL] subtest: border-top-width length(px) / events
    • PASS [expected FAIL] subtest: border-top-width length(em) / events
    • PASS [expected FAIL] subtest: border-top-width length(ex) / events
    • PASS [expected FAIL] subtest: border-top-width length(mm) / events
    • PASS [expected FAIL] subtest: border-top-width length(cm) / events
    • PASS [expected FAIL] subtest: border-top-width length(in) / events
    • PASS [expected FAIL] subtest: border-right-width length(pt) / events
    • And 99 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-002.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length(pt) / values
    • PASS [expected FAIL] subtest: text-indent length(pt) / events
    • PASS [expected FAIL] subtest: text-indent length(pc) / values
    • PASS [expected FAIL] subtest: text-indent length(pc) / events
    • PASS [expected FAIL] subtest: text-indent length(px) / values
    • PASS [expected FAIL] subtest: text-indent length(px) / events
    • PASS [expected FAIL] subtest: text-indent length(em) / values
    • PASS [expected FAIL] subtest: text-indent length(em) / events
    • PASS [expected FAIL] subtest: text-indent length(ex) / values
    • PASS [expected FAIL] subtest: text-indent length(ex) / events
    • And 8 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-003.html (#26435)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
    • PASS [expected FAIL] subtest: text-indent length-em(em) / events
  • OK /css/cssom-view/elementFromPoint-float-in-relative.html (#27753)
    • FAIL [expected PASS] subtest: elementFromPoint-float-in-relative
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • FAIL [expected PASS] subtest: Instant scrolling while doing history navigation.

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
State: approved= try=True

Existing WPT now passing:
  - _mozilla/css/text_indent_a.html
  - css/CSS2/css1/c71-fwd-parsing-002.xht
  - css/CSS2/css1/c71-fwd-parsing-004.xht
  - css/CSS2/floats-clear/floats-138.xht
  - css/CSS2/text/text-indent-007.xht
  - css/CSS2/text/text-indent-008.xht
  - css/CSS2/text/text-indent-010.xht
  - css/CSS2/text/text-indent-019.xht
  - css/CSS2/text/text-indent-020.xht
  - css/CSS2/text/text-indent-031.xht
  - css/CSS2/text/text-indent-032.xht
  - css/CSS2/text/text-indent-043.xht
  - css/CSS2/text/text-indent-044.xht
  - css/CSS2/text/text-indent-055.xht
  - css/CSS2/text/text-indent-056.xht
  - css/CSS2/text/text-indent-067.xht
  - css/CSS2/text/text-indent-068.xht
  - css/CSS2/text/text-indent-079.xht
  - css/CSS2/text/text-indent-080.xht
  - css/CSS2/text/text-indent-091.xht
  - css/CSS2/text/text-indent-092.xht
  - css/CSS2/text/text-indent-103.xht
  - css/CSS2/text/text-indent-104.xht
  - css/CSS2/text/text-indent-112.xht
  - css/CSS2/text/text-indent-113.xht
  - css/CSS2/text/text-indent-115.xht
  - css/CSS2/text/text-indent-applies-to-002.xht
  - css/CSS2/text/text-indent-applies-to-003.xht
  - css/CSS2/text/text-indent-applies-to-005.xht
  - css/CSS2/text/text-indent-applies-to-006.xht
  - css/CSS2/text/text-indent-applies-to-007.xht
  - css/CSS2/text/text-indent-applies-to-008.xht
  - css/CSS2/text/text-indent-applies-to-009.xht
  - css/CSS2/text/text-indent-applies-to-010.xht
  - css/CSS2/text/text-indent-applies-to-011.xht
  - css/CSS2/text/text-indent-applies-to-014.xht
  - css/CSS2/text/text-indent-applies-to-015.xht
  - css/CSS2/text/text-indent-inherited-001.xht
  - css/CSS2/text/text-indent-overflow-001.xht
  - css/CSS2/text/text-indent-overflow-002.xht
  - css/CSS2/text/text-indent-overflow-003.xht
  - css/CSS2/text/text-indent-overflow-004.xht
  - css/CSS2/text/text-indent-wrap-001.xht
  - css/css-text-decor/text-shadow/textindent.html
  - css/css-text/text-indent/text-indent-percentage-001.xht
  - css/css-text/text-indent/text-indent-percentage-002.html
  - css/css-text/text-indent/text-indent-percentage-003.html
  - css/css-text/text-indent/text-indent-percentage-004.html
  - css/css-values/minmax-length-percent-serialize.html
  - css/css-values/minmax-length-serialize.html

Also improvements in:
  - _mozilla/mozilla/calc.html
  - css/css-text/animations/text-indent-interpolation.html
  - css/css-text/inheritance.html
  - css/css-text/parsing/text-indent-computed.html
  - css/css-text/parsing/text-indent-valid.html
  - css/css-transitions/properties-value-implicit-001.html
  - css/css-values/animations/calc-interpolation.html
  - css/css-values/minmax-percentage-serialize.html
  - css/css-values/viewport-units-css2-001.html
  - css/css-variables/variable-substitution-basic.html
  - css/cssom/serialize-values.html

Existing WPT now failing, due to lack of direction, outside list markers,
flex and grid:
  - css/CSS2/text/text-indent-rtl-001.xht
  - css/CSS2/text/text-indent-rtl-002.xht
  - css/css-pseudo/marker-content-023.html
  - css/css-text/text-indent/anonymous-flex-item-001.html
  - css/css-text/text-indent/anonymous-grid-item-001.html

New WPT tests:
 - css/css-text/text-indent/text-indent-length-001.html
 - css/css-text/text-indent/text-indent-length-002.html
   This one fails in layout-2013.
@servo-wpt-sync
Copy link
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#39627).

@Loirooriol
Copy link
Contributor Author

@bors-servo r=mrobinson

@bors-servo
Copy link
Contributor

📌 Commit c842023 has been approved by mrobinson

@servo-wpt-sync
Copy link
Collaborator

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#39627) title and body.

@bors-servo
Copy link
Contributor

⌛ Testing commit c842023 with merge 7114b31...

@github-actions
Copy link

Results from try job (#4803060181):

Flaky unexpected result (28)
  • TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
    • TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works.
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/CSS2/floats/hit-test-floats-001.html (#23693)
    • PASS [expected FAIL] subtest: hit-test-floats-001
  • OK /css/CSS2/floats/hit-test-floats-003.html (#25733)
    • PASS [expected FAIL] subtest: Miss float below something else
  • OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)
    • PASS [expected FAIL] subtest: [data-expected-height] 1
    • PASS [expected FAIL] subtest: [data-expected-height] 2
    • FAIL [expected PASS] subtest: [data-expected-height] 4
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-001.html (#29064)
    • FAIL [expected PASS] subtest: block-in-inline-hittest-001
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-float-001.html (#29565)
    • PASS [expected FAIL] subtest: block-in-inline-hittest-float-001
  • OK /css/css-transforms/transform-scale-hittest.html (#24667)
    • FAIL [expected PASS] subtest: Hit test within unscaled box
  • OK /css/css-transitions/properties-value-003.html (#21486)
    • FAIL [expected PASS] subtest: border-top-left-radius border-radius(px) / values
    • FAIL [expected PASS] subtest: border-top-left-radius border-radius(px-px) / values
    • FAIL [expected PASS] subtest: border-top-right-radius border-radius(px) / values
    • FAIL [expected PASS] subtest: border-top-right-radius border-radius(px-px) / values
    • FAIL [expected PASS] subtest: border-bottom-left-radius border-radius(px) / values
    • FAIL [expected PASS] subtest: border-bottom-left-radius border-radius(px-px) / values
    • FAIL [expected PASS] subtest: border-bottom-right-radius border-radius(px) / values
    • FAIL [expected PASS] subtest: border-bottom-right-radius border-radius(px-px) / values
    • FAIL [expected PASS] subtest: box-shadow box-shadow(shadow) / values
    • FAIL [expected PASS] subtest: font-stretch font-stretch(keyword) / values
    • And 2 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-003.html (#26435)
    • FAIL [expected PASS] subtest: border-top-width length-em(em) / events
    • FAIL [expected PASS] subtest: border-right-width length-em(em) / events
    • FAIL [expected PASS] subtest: border-bottom-width length-em(em) / events
    • FAIL [expected PASS] subtest: border-left-width length-em(em) / events
    • FAIL [expected PASS] subtest: padding-bottom length-em(em) / events
    • FAIL [expected PASS] subtest: padding-left length-em(em) / events
    • FAIL [expected PASS] subtest: padding-right length-em(em) / events
    • FAIL [expected PASS] subtest: padding-top length-em(em) / events
    • FAIL [expected PASS] subtest: margin-bottom length-em(em) / events
    • FAIL [expected PASS] subtest: margin-left length-em(em) / events
    • And 19 more unexpected results...
  • OK /css/cssom-view/elementFromPoint-dynamic-anon-box.html (#22337)
    • PASS [expected FAIL] subtest: Link should be clickable after hiding a scrollbox with an anonymous table inside
  • OK /css/cssom-view/elementFromPoint-float-in-table.html (#27002)
    • FAIL [expected PASS] subtest: float-in-div
  • OK /css/cssom-view/elementFromPoint-visibility-hidden-resizer.html (#28695)
    • FAIL [expected PASS] subtest: elementFromPoint on resizer area of an element with visibility:hidden
  • TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.any.html (#29536)
  • TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
    • FAIL [expected PASS] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent)
  • OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • TIMEOUT [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected.html (#29224)
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if
      allow-popups-to-escape-sandbox is used
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
    • TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
      allow-popups-to-escape-sandbox is used
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-child-special-cases.tentative.sub.window.html (#29069)
  • OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
    • FAIL [expected PASS] subtest: createHTMLDocument
    • FAIL [expected PASS] subtest: <template>
  • TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
    • PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
  • CRASH [expected TIMEOUT] /webmessaging/broadcastchannel/cross-partition.https.tentative.html (#29058)
  • TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
Stable unexpected results that are known to be intermittent (21)
  • OK [expected TIMEOUT] /FileAPI/url/url-charset.window.html (#26997)
    • PASS [expected TIMEOUT] subtest: Blob charset should override any auto-detected charset.
  • FAIL [expected PASS] /_mozilla/mozilla/scroll_root.html (#16603)
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-relpos-zindex.html (#29052)
    • FAIL [expected PASS] subtest: block-in-inline-hittest-relpos-zindex
  • OK /css/css-flexbox/hittest-before-pseudo.html (#26521)
    • FAIL [expected PASS] subtest: Hit-testing text within a pseudo-element flex-item should return the flexbox as the hittest result.
  • OK /css/css-transforms/inline-with-filter-and-hidden-backface.html (#29547)
    • FAIL [expected PASS] subtest: Hit test
  • OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
    • PASS [expected FAIL] subtest: listeners are called correct number of times
    • PASS [expected FAIL] subtest: listener that was added twice is called only once
  • OK /css/cssom-view/elementFromPoint-ellipsis-in-inline-box.html (#27414)
    • PASS [expected FAIL] subtest: elementFromPoint-ellipsis-in-inline-box
  • OK /css/cssom-view/elementFromPoint-list-001.html (#23915)
    • PASS [expected FAIL] subtest: <li>Inside 1</li>
    • PASS [expected FAIL] subtest: <li>Inside 2</li>
    • PASS [expected FAIL] subtest: <li>Image Inside 1</li>
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • FAIL [expected PASS] subtest: Instant scrolling while doing history navigation.
  • TIMEOUT [expected OK] /fetch/api/basic/keepalive.any.html (#29536)
  • OK [expected TIMEOUT] /fetch/local-network-access/iframe.tentative.https.window.html (#29605)
    • PASS [expected TIMEOUT] subtest: local to local, grandparent navigates: no preflight required.
    • FAIL [expected TIMEOUT] subtest: public to local, grandparent navigates: failure.
    • FAIL [expected TIMEOUT] subtest: public to local, grandparent navigates: success.
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
    • FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
  • TIMEOUT /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-no-beforeunload.window.html (#29055)
    • FAIL [expected TIMEOUT] subtest: Navigating an opened window with an iframe via location.href to a javascript: URL must not fire beforeunload on the iframe: undefined completion
    • PASS [expected NOTRUN] subtest: Navigating an iframe via location.href to a javascript: URL must not fire beforeunload: string completion
    • PASS [expected NOTRUN] subtest: Navigating an iframe via src="" to a javascript: URL after insertion must not fire beforeunload: string completion
    • TIMEOUT [expected NOTRUN] subtest: Navigating an opened window via location.href to a javascript: URL must not fire beforeunload: string completion
  • OK [expected TIMEOUT] /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
    • PASS [expected TIMEOUT] subtest: first argument: absolute url
  • TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-nonexistent.html (#28259)
    • TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with non-existent fragments should work.
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
  • TIMEOUT [expected OK] /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
    • NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
    • NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_parent does a normal load
    • NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_top does a normal load
  • OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
  • OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
    • PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
  • OK [expected TIMEOUT] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
    • FAIL [expected TIMEOUT] subtest: Sanity check: this all works as expected with no promises involved
    • FAIL [expected TIMEOUT] subtest: Fulfillment handler on fulfilled promise
    • FAIL [expected TIMEOUT] subtest: Fulfillment handler on pending-then-fulfilled promise
  • OK [expected ERROR] /resource-timing/cors-preflight.any.html (#28694)
    • FAIL [expected TIMEOUT] subtest: PerformanceResourceTiming sizes fetch with preflight test

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: mrobinson
Pushing 7114b31 to master...

@bors-servo bors-servo merged commit 7114b31 into servo:master Apr 26, 2023
10 checks passed
@Loirooriol Loirooriol deleted the text-indent branch April 26, 2023 10:14
@github-actions
Copy link

Results from try job (#4807527432):

Flaky unexpected result (9)
  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • FAIL [expected PASS] /_mozilla/mozilla/iframe/resize_after_load.html (#13573)
  • OK /css/CSS2/floats/hit-test-floats-001.html (#23693)
    • FAIL [expected PASS] subtest: hit-test-floats-001
  • OK /css/CSS2/normal-flow/hit-test-anonymous-block.html (#25807)
    • PASS [expected FAIL] subtest: Hit test beside line of text inside anonymous block
  • OK /css/cssom-view/CaretPosition-001.html (#21338)
    • PASS [expected FAIL] subtest: Element at (400, 100)
  • OK /css/cssom-view/elementFromPoint-001.html (#22452)
    • PASS [expected FAIL] subtest: CSSOM View - 5 - extensions to the Document interface
  • OK /css/cssom-view/elementFromPoint-visibility-hidden-resizer.html (#28695)
    • PASS [expected FAIL] subtest: elementFromPoint on resizer area of an element with visibility:hidden
  • OK /css/cssom-view/elementFromPosition.html (#21295)
    • PASS [expected FAIL] subtest: test some point of the element: top left corner
  • OK /css/cssom-view/elementsFromPoint-iframes.html (#19273)
    • FAIL [expected PASS] subtest: elementsFromPoint on inner documents
Stable unexpected results that are known to be intermittent (11)
  • OK /_mozilla/mozilla/scrollBy.html (#21321)
    • FAIL [expected PASS] subtest: Ensure that the window.scrollBy function affects scroll position as expected
  • FAIL [expected PASS] /_mozilla/mozilla/scroll_root.html (#16603)
  • OK /css/css-flexbox/hittest-anonymous-box.html (#27091)
    • PASS [expected FAIL] subtest: Hit-testing within an anonymous flex-item should return the flexbox as the hittest result.
  • OK /css/css-transitions/properties-value-001.html (#21486)
    • PASS [expected FAIL] subtest: background-color color(rgba) / values
    • PASS [expected FAIL] subtest: border-top-width length(pt) / values
    • PASS [expected FAIL] subtest: border-top-width length(pc) / values
    • PASS [expected FAIL] subtest: border-top-width length(px) / values
    • PASS [expected FAIL] subtest: border-top-width length(em) / values
    • PASS [expected FAIL] subtest: border-top-width length(ex) / values
    • PASS [expected FAIL] subtest: border-top-width length(mm) / values
    • PASS [expected FAIL] subtest: border-top-width length(cm) / values
    • PASS [expected FAIL] subtest: border-top-width length(in) / values
    • PASS [expected FAIL] subtest: border-right-width length(pt) / values
    • And 49 more unexpected results...
  • OK /css/css-transitions/properties-value-implicit-001.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
  • OK /css/css-transitions/properties-value-inherit-001.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length(pt) / values
    • PASS [expected FAIL] subtest: text-indent length(pt) / events
    • PASS [expected FAIL] subtest: text-indent length(pc) / values
    • PASS [expected FAIL] subtest: text-indent length(pc) / events
    • PASS [expected FAIL] subtest: text-indent length(px) / values
    • PASS [expected FAIL] subtest: text-indent length(px) / events
    • PASS [expected FAIL] subtest: text-indent length(em) / values
    • PASS [expected FAIL] subtest: text-indent length(em) / events
    • PASS [expected FAIL] subtest: text-indent length(ex) / values
    • PASS [expected FAIL] subtest: text-indent length(ex) / events
    • And 8 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-002.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length(pt) / values
    • PASS [expected FAIL] subtest: text-indent length(pt) / events
    • PASS [expected FAIL] subtest: text-indent length(pc) / values
    • PASS [expected FAIL] subtest: text-indent length(pc) / events
    • PASS [expected FAIL] subtest: text-indent length(px) / values
    • PASS [expected FAIL] subtest: text-indent length(px) / events
    • PASS [expected FAIL] subtest: text-indent length(em) / values
    • PASS [expected FAIL] subtest: text-indent length(em) / events
    • PASS [expected FAIL] subtest: text-indent length(ex) / values
    • PASS [expected FAIL] subtest: text-indent length(ex) / events
    • And 8 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-003.html (#26435)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
    • PASS [expected FAIL] subtest: text-indent length-em(em) / events
  • OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
    • PASS [expected FAIL] subtest: listeners are called correct number of times
    • PASS [expected FAIL] subtest: listeners are called in order their MQLs were created
  • OK /css/cssom-view/elementsFromPoint-inline-vlr-ltr.html (#25753)
    • FAIL [expected PASS] subtest: elementsFromPoint should return all elements under a point
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • FAIL [expected PASS] subtest: Instant scrolling while doing history navigation.
Stable unexpected results (4)
  • OK /css/css-flexbox/negative-overflow.html
    • PASS [expected FAIL] subtest: .flexbox 4
    • PASS [expected FAIL] subtest: .flexbox 5
  • OK /css/css-flexbox/overflow-auto-008.html
    • PASS [expected FAIL] subtest: hbox dimensions
  • PASS [expected FAIL] /css/css-masking/clip/clip-rect-scroll.html
  • OK /css/cssom-view/scrolling-quirks-vs-nonquirks.html
    • PASS [expected FAIL] subtest: scroll() on the HTML body element in quirks mode
    • PASS [expected FAIL] subtest: scrollBy() on the HTML body element in quirks mode
    • PASS [expected FAIL] subtest: scrollLeft/scrollTop on the HTML body element in quirks mode
    • PASS [expected FAIL] subtest: scroll() on the root element in non-quirks mode
    • PASS [expected FAIL] subtest: scrollBy() on the root element in non-quirks mode
    • PASS [expected FAIL] subtest: scrollLeft/scrollTop on the root element in non-quirks mode

@github-actions
Copy link

Results from try job (#4808203285):

Flaky unexpected result (23)
  • TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
    • TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works.
  • OK /_mozilla/mozilla/task_queue_throttling.any.html (#22519)
    • FAIL [expected PASS] subtest: Throttling the performance timeline task queue.
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/CSS2/floats/hit-test-floats-001.html (#23693)
    • PASS [expected FAIL] subtest: hit-test-floats-001
  • OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)
    • PASS [expected FAIL] subtest: [data-expected-height] 1
    • PASS [expected FAIL] subtest: [data-expected-height] 2
    • FAIL [expected PASS] subtest: [data-expected-height] 4
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-001.html (#29064)
    • FAIL [expected PASS] subtest: block-in-inline-hittest-001
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-float-001.html (#29565)
    • PASS [expected FAIL] subtest: block-in-inline-hittest-float-001
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-relpos-zindex.html (#29052)
    • FAIL [expected PASS] subtest: block-in-inline-hittest-relpos-zindex
  • OK /css/css-transforms/transform-scale-hittest.html (#24667)
    • FAIL [expected PASS] subtest: Hit test within unscaled box
  • OK /css/cssom-view/elementsFromPoint-invalid-cases.html (#21338)
    • PASS [expected FAIL] subtest: The root element is the last element returned for otherwise empty queries within the viewport
  • TIMEOUT [expected OK] /fetch/api/basic/keepalive.any.html (#29536)
  • OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
    • FAIL [expected PASS] subtest: Check execution order from nested timeout
    • FAIL [expected PASS] subtest: Check execution order on load handler
  • OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
    • PASS [expected TIMEOUT] subtest: no-referrer referrer policy used to create the starting page
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
    • PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
  • OK [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
  • TIMEOUT [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected.html (#29224)
  • TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
    • TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
    • NOTRUN [expected FAIL] subtest: Area element should support autofocus
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-child-special-cases.tentative.sub.window.html (#29069)
  • OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
    • PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
  • TIMEOUT /resource-timing/nested-context-navigations-iframe.html (#24311)
    • TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent
    • NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
    • NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
    • NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
    • NOTRUN [expected TIMEOUT] subtest: Test that iframe refreshes are not observable by the parent
  • CRASH [expected TIMEOUT] /webmessaging/broadcastchannel/cross-partition.https.tentative.html (#29058)
  • OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
Stable unexpected results that are known to be intermittent (22)
  • OK [expected TIMEOUT] /FileAPI/url/url-charset.window.html (#26997)
    • PASS [expected TIMEOUT] subtest: Blob charset should override any auto-detected charset.
  • FAIL [expected PASS] /_mozilla/mozilla/scroll_root.html (#16603)
  • OK /css/CSS2/floats/hit-test-floats-003.html (#25733)
    • PASS [expected FAIL] subtest: Miss float below something else
  • OK /css/css-flexbox/hittest-anonymous-box.html (#27091)
    • FAIL [expected PASS] subtest: Hit-testing within an anonymous flex-item should return the flexbox as the hittest result.
  • OK /css/css-transitions/properties-value-inherit-002.html (#21486)
    • PASS [expected FAIL] subtest: color color(rgba) / values
    • PASS [expected FAIL] subtest: font-size length(pt) / values
    • PASS [expected FAIL] subtest: font-size length(pc) / values
    • PASS [expected FAIL] subtest: font-size length(px) / values
    • PASS [expected FAIL] subtest: font-size length(em) / values
    • PASS [expected FAIL] subtest: font-size length(ex) / values
    • PASS [expected FAIL] subtest: font-size length(mm) / values
    • PASS [expected FAIL] subtest: font-size length(cm) / values
    • PASS [expected FAIL] subtest: font-size length(in) / values
    • PASS [expected FAIL] subtest: font-size percentage(%) / values
    • And 40 more unexpected results...
  • OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
    • PASS [expected FAIL] subtest: listeners are called correct number of times
    • PASS [expected FAIL] subtest: listener that was added twice is called only once
  • OK /css/cssom-view/elementFromPoint-001.html (#22452)
    • FAIL [expected PASS] subtest: CSSOM View - 5 - extensions to the Document interface
  • CRASH [expected OK] /css/cssom-view/elementFromPoint-dynamic-anon-box.html (#22337)
  • OK /css/cssom-view/elementFromPoint-ellipsis-in-inline-box.html (#27414)
    • PASS [expected FAIL] subtest: elementFromPoint-ellipsis-in-inline-box
  • OK /css/cssom-view/elementFromPoint-list-001.html (#23915)
    • PASS [expected FAIL] subtest: <li>Inside 1</li>
    • PASS [expected FAIL] subtest: <li>Inside 2</li>
    • FAIL [expected PASS] subtest: <li>Inside 3</li>
    • PASS [expected FAIL] subtest: <li>Image Inside 1</li>
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • FAIL [expected PASS] subtest: Instant scrolling while doing history navigation.
  • TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.any.html (#29536)
  • OK [expected TIMEOUT] /fetch/local-network-access/iframe.tentative.https.window.html (#29605)
    • PASS [expected TIMEOUT] subtest: local to local, grandparent navigates: no preflight required.
    • FAIL [expected TIMEOUT] subtest: public to local, grandparent navigates: failure.
    • FAIL [expected TIMEOUT] subtest: public to local, grandparent navigates: success.
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
    • FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
  • TIMEOUT /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-no-beforeunload.window.html (#29055)
    • FAIL [expected TIMEOUT] subtest: Navigating an opened window with an iframe via location.href to a javascript: URL must not fire beforeunload on the iframe: undefined completion
    • PASS [expected NOTRUN] subtest: Navigating an iframe via location.href to a javascript: URL must not fire beforeunload: string completion
    • PASS [expected NOTRUN] subtest: Navigating an iframe via src="" to a javascript: URL after insertion must not fire beforeunload: string completion
    • TIMEOUT [expected NOTRUN] subtest: Navigating an opened window via location.href to a javascript: URL must not fire beforeunload: string completion
  • OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
    • PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
  • OK [expected TIMEOUT] /html/browsers/history/the-history-interface/traverse-during-unload.html (#28688)
    • PASS [expected TIMEOUT] subtest: Traversing the history during unload
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
    • FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
  • OK [expected TIMEOUT] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
    • FAIL [expected TIMEOUT] subtest: Sanity check: this all works as expected with no promises involved
    • FAIL [expected TIMEOUT] subtest: Fulfillment handler on fulfilled promise
    • FAIL [expected TIMEOUT] subtest: Fulfillment handler on pending-then-fulfilled promise
  • OK [expected ERROR] /resource-timing/cors-preflight.any.html (#28694)
    • FAIL [expected TIMEOUT] subtest: PerformanceResourceTiming sizes fetch with preflight test

@github-actions
Copy link

Results from try job (#4808453667):

Flaky unexpected result (9)
  • OK /css/CSS2/floats/hit-test-floats-001.html (#23693)
    • FAIL [expected PASS] subtest: hit-test-floats-001
  • OK /css/CSS2/floats/hit-test-floats-005.html (#25804)
    • PASS [expected FAIL] subtest: Miss clipped float
  • OK /css/cssom-view/CaretPosition-001.html (#21338)
    • PASS [expected FAIL] subtest: Element at (400, 100)
  • OK /css/cssom-view/elementFromPoint-003.html (#26924)
    • PASS [expected FAIL] subtest: Checking whether dynamic changes to visibility interact correctly with
      table anonymous boxes
  • OK /css/cssom-view/elementFromPoint-ellipsis-in-inline-box.html (#27414)
    • FAIL [expected PASS] subtest: elementFromPoint-ellipsis-in-inline-box
  • OK /css/cssom-view/elementFromPoint-float-in-relative.html (#27753)
    • FAIL [expected PASS] subtest: elementFromPoint-float-in-relative
  • OK /css/cssom-view/elementFromPoint-float-in-table.html (#27002)
    • FAIL [expected PASS] subtest: float-in-div
  • OK /css/cssom-view/elementFromPosition.html (#21295)
    • PASS [expected FAIL] subtest: test some point of the element: top left corner
  • OK /css/cssom-view/elementsFromPoint-inline-vlr-ltr.html (#25753)
    • FAIL [expected PASS] subtest: elementsFromPoint should return all elements under a point
Stable unexpected results that are known to be intermittent (14)
  • OK /_mozilla/mozilla/scrollBy.html (#21321)
    • FAIL [expected PASS] subtest: Ensure that the window.scrollBy function affects scroll position as expected
  • FAIL [expected PASS] /_mozilla/mozilla/scroll_root.html (#16603)
  • OK /css/CSS2/floats/hit-test-floats-003.html (#25733)
    • PASS [expected FAIL] subtest: Miss float below something else
  • OK /css/CSS2/floats/hit-test-floats-004.html (#25804)
    • PASS [expected FAIL] subtest: Miss float below something else
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-001.html (#29064)
    • PASS [expected FAIL] subtest: block-in-inline-hittest-001
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-relpos-zindex.html (#29052)
    • PASS [expected FAIL] subtest: block-in-inline-hittest-relpos-zindex
  • OK /css/css-transitions/properties-value-001.html (#21486)
    • PASS [expected FAIL] subtest: background-color color(rgba) / values
    • PASS [expected FAIL] subtest: border-top-width length(pt) / values
    • PASS [expected FAIL] subtest: border-top-width length(pc) / values
    • PASS [expected FAIL] subtest: border-top-width length(px) / values
    • PASS [expected FAIL] subtest: border-top-width length(em) / values
    • PASS [expected FAIL] subtest: border-top-width length(ex) / values
    • PASS [expected FAIL] subtest: border-top-width length(mm) / values
    • PASS [expected FAIL] subtest: border-top-width length(cm) / values
    • PASS [expected FAIL] subtest: border-top-width length(in) / values
    • PASS [expected FAIL] subtest: border-right-width length(pt) / values
    • And 49 more unexpected results...
  • OK /css/css-transitions/properties-value-implicit-001.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
  • OK /css/css-transitions/properties-value-inherit-001.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length(pt) / values
    • PASS [expected FAIL] subtest: text-indent length(pt) / events
    • PASS [expected FAIL] subtest: text-indent length(pc) / values
    • PASS [expected FAIL] subtest: text-indent length(pc) / events
    • PASS [expected FAIL] subtest: text-indent length(px) / values
    • PASS [expected FAIL] subtest: text-indent length(px) / events
    • PASS [expected FAIL] subtest: text-indent length(em) / values
    • PASS [expected FAIL] subtest: text-indent length(em) / events
    • PASS [expected FAIL] subtest: text-indent length(ex) / values
    • PASS [expected FAIL] subtest: text-indent length(ex) / events
    • And 8 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-002.html (#21486)
    • PASS [expected FAIL] subtest: text-indent length(pt) / values
    • PASS [expected FAIL] subtest: text-indent length(pt) / events
    • PASS [expected FAIL] subtest: text-indent length(pc) / values
    • PASS [expected FAIL] subtest: text-indent length(pc) / events
    • PASS [expected FAIL] subtest: text-indent length(px) / values
    • PASS [expected FAIL] subtest: text-indent length(px) / events
    • PASS [expected FAIL] subtest: text-indent length(em) / values
    • PASS [expected FAIL] subtest: text-indent length(em) / events
    • PASS [expected FAIL] subtest: text-indent length(ex) / values
    • PASS [expected FAIL] subtest: text-indent length(ex) / events
    • And 8 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-003.html (#26435)
    • PASS [expected FAIL] subtest: text-indent length-em(em) / values
    • PASS [expected FAIL] subtest: text-indent length-em(em) / events
  • OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
    • PASS [expected FAIL] subtest: listeners are called correct number of times
    • PASS [expected FAIL] subtest: listeners are called in order their MQLs were created
  • OK /css/cssom-view/elementsFromPoint-iframes.html (#19273)
    • FAIL [expected PASS] subtest: elementsFromPoint on inner documents
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • FAIL [expected PASS] subtest: Instant scrolling while doing history navigation.
Stable unexpected results (4)
  • OK /css/css-flexbox/negative-overflow.html
    • PASS [expected FAIL] subtest: .flexbox 4
    • PASS [expected FAIL] subtest: .flexbox 5
  • OK /css/css-flexbox/overflow-auto-008.html
    • PASS [expected FAIL] subtest: hbox dimensions
  • PASS [expected FAIL] /css/css-masking/clip/clip-rect-scroll.html
  • OK /css/cssom-view/scrolling-quirks-vs-nonquirks.html
    • PASS [expected FAIL] subtest: scroll() on the HTML body element in quirks mode
    • PASS [expected FAIL] subtest: scrollBy() on the HTML body element in quirks mode
    • PASS [expected FAIL] subtest: scrollLeft/scrollTop on the HTML body element in quirks mode
    • PASS [expected FAIL] subtest: scroll() on the root element in non-quirks mode
    • PASS [expected FAIL] subtest: scrollBy() on the root element in non-quirks mode
    • PASS [expected FAIL] subtest: scrollLeft/scrollTop on the root element in non-quirks mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support text-indent in layout-2020
4 participants