Dump initial prototype of devtools server into the build. Expect lies if... #3172
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/2466 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
|
This isn't in the greatest state to be merged right now (for example, I hacked around the inability to call get_type_id in the AnyRefExt implementation by making |
|
we should refer to documents of remote debugging protocol in the code comment. |
|
cc @glennw @SimonSapin @mbrubeck (since we were talking about how awesome this would be last night...) |
|
This is in a good state for review at this point. Who wants to take it on? @Ms2ger should do the script task bits, but the actual devtools server implementation is open. @larsbergstrom? @metajack? @glennw? |
jdm
force-pushed
the
devtools
branch
2 times, most recently
from
a854d5c
to
4af3495
Compare
| } | ||
| } | ||
| } | ||
| let mut new_actors = self.new_actors.borrow_mut(); |
There was a problem hiding this comment.
Just for my own understanding, why/when would you want to register an actor later?
There was a problem hiding this comment.
I haven't found a way pass a mutable ActorRegistry reference to handle_message, since self.actors is currently frozen. This means that it's impossible to register new actors in the same vector, hence the delayed registration.
jdm
force-pushed
the
devtools
branch
4 times, most recently
from
4a4a702
to
6d57223
Compare
… if you try to use it for anything real.
…and viewing the responses from the Firefox remote console.
… somewhat useful.
Dump initial prototype of devtools server into the build. Expect lies if...
... you try to use it for anything real.