Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDump initial prototype of devtools server into the build. Expect lies if... #3172
Conversation
hoppipolla-critic-bot
commented
Aug 27, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2466 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Aug 27, 2014
|
|
|
This isn't in the greatest state to be merged right now (for example, I hacked around the inability to call get_type_id in the AnyRefExt implementation by making |
|
we should refer to documents of remote debugging protocol in the code comment. |
|
cc @glennw @SimonSapin @mbrubeck (since we were talking about how awesome this would be last night...) |
|
This is in a good state for review at this point. Who wants to take it on? @Ms2ger should do the script task bits, but the actual devtools server implementation is open. @larsbergstrom? @metajack? @glennw? |
| } | ||
| } | ||
| } | ||
| let mut new_actors = self.new_actors.borrow_mut(); |
This comment has been minimized.
This comment has been minimized.
glennw
Sep 4, 2014
Member
Just for my own understanding, why/when would you want to register an actor later?
This comment has been minimized.
This comment has been minimized.
jdm
Sep 4, 2014
Author
Member
I haven't found a way pass a mutable ActorRegistry reference to handle_message, since self.actors is currently frozen. This means that it's impossible to register new actors in the same vector, hence the delayed registration.
| json::Object(m) | ||
| } else if val.is_infinite() { | ||
| let mut m = TreeMap::new(); | ||
| if val < 0. { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdm
force-pushed the
jdm:devtools
branch
4 times, most recently
from
4a4a702
to
6d57223
Dump initial prototype of devtools server into the build. Expect lies if...
jdm commentedAug 27, 2014
... you try to use it for anything real.