Remove render backend option as it doesn't work and confuses people. #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -320,14 +320,13 @@ impl<C:RenderListener + Send> RenderTask<C> { | |||
| let size = Size2D(width as i32, height as i32); | |||
| let draw_target = match self.graphics_context { | |||
| CpuGraphicsContext => { | |||
| DrawTarget::new(self.opts.render_backend, size, B8G8R8A8) | |||
| DrawTarget::new(SkiaBackend, size, B8G8R8A8) | |||
There was a problem hiding this comment.
Can you add a FIXME/TODO/NOTE to make this configurable in the future? I would like to eventually make this configurable, even if it isn't now…
bors-servo
pushed a commit
that referenced
this pull request
Oct 19, 2014
bors-servo
pushed a commit
that referenced
this pull request
Oct 19, 2014
bors-servo
pushed a commit
that referenced
this pull request
Oct 20, 2014
tetsuharuohzeki
added a commit
to tetsuharuohzeki/servo
that referenced
this pull request
Oct 20, 2014
tetsuharuohzeki
added a commit
to tetsuharuohzeki/servo
that referenced
this pull request
Oct 22, 2014
mukilan
pushed a commit
to mukilan/servo
that referenced
this pull request
Oct 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @pcwalton @metajack