Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Arc<Box<Image>> to Arc<Image> for perf boost. #5642

Merged
merged 2 commits into from Apr 14, 2015
Merged

Switch Arc<Box<Image>> to Arc<Image> for perf boost. #5642

merged 2 commits into from Apr 14, 2015

Conversation

aneeshusa
Copy link
Contributor

Image used to be a trait, but no longer is, so boxing it is no longer
necessary. Fixes #5639.

@aneeshusa
Switch Arc<Box<Image>> to Arc<Image> for perf boost.
5b593a3 
Image used to be a trait, but no longer is, so boxing it is no longer
necessary.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 10, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4635

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 13, 2015
@jdm
Copy link
Member

jdm commented Apr 13, 2015

Good work! @Ms2ger left one comment in the Critic review.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Apr 13, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 14, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 395e8a5 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

⌛ Testing commit 395e8a5 with merge b7f59a3...

bors-servo pushed a commit that referenced this pull request Apr 14, 2015
Auto merge of #5642 - aneeshusa:arc-box-image-to-arc-image, r=Ms2ger
b7f59a3 
Image used to be a trait, but no longer is, so boxing it is no longer
necessary. Fixes #5639.
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit 395e8a5 into servo:master Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review There is new code that needs to be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch Arc<Box<Image>> to Arc<Image>
6 participants
@aneeshusa @hoppipolla-critic-bot @jdm @Ms2ger @bors-servo @highfive