Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only define feature gates when they're used. #5793

Merged
merged 1 commit into from
Apr 22, 2015
Merged

Only define feature gates when they're used. #5793

merged 1 commit into from
Apr 22, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Apr 22, 2015

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 22, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4763

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@SimonSapin
Copy link
Member

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 3cd999b has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 3cd999b with merge b2afc01...

bors-servo pushed a commit that referenced this pull request Apr 22, 2015
Auto merge of #5793 - Ms2ger:warnings, r=SimonSapin
b2afc01 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5793)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit 3cd999b into servo:master Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review There is new code that needs to be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ms2ger @hoppipolla-critic-bot @SimonSapin @bors-servo @highfive