Add move protection to Root and friends

[Manishearth]

fixes #5724, #5737

uses https://github.com/Manishearth/rust-tenacious (can be moved in-tree if needed)

I can make it Deny by default too (I'll add a cargo feature to tenacious), though we might want it on
Warn until we get some mileage on it.

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/4807

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[Manishearth]

cc @Munksgaard ExprUseVisitor was quite useful here.

However, in the case of humpty_dumpty, we need to do the opposite of ExprUseVisitor -- we can use it to track consumption (ish) but we'll still need to track branches somehow. Not sure if it will be useful; I couldn't quickly come up with a way that avoided tracking branches.

[Manishearth]

r? @kmcallister @jdm

[bors-servo]

☔ The latest upstream changes (presumably #5860) made this pull request unmergeable. Please resolve the merge conflicts.

[bors-servo]

☔ The latest upstream changes (presumably #5862) made this pull request unmergeable. Please resolve the merge conflicts.

[kmcallister]

Reviewed files:

• components/plugins/Cargo.toml @ r1
• components/plugins/lib.rs @ r1
• components/script/dom/bindings/codegen/CodegenRust.py @ r2
• components/script/dom/bindings/global.rs @ r2
• components/script/dom/bindings/js.rs @ r3
• components/script/dom/bindings/mod.rs @ r2
• components/script/dom/bindings/trace.rs @ r3
• components/script/dom/document.rs @ r2
• components/script/dom/domimplementation.rs @ r2
• components/script/dom/element.rs @ r2
• components/script/dom/eventdispatcher.rs @ r2
• components/script/dom/htmlformelement.rs @ r2
• components/script/dom/htmlinputelement.rs @ r2
• components/script/dom/htmllinkelement.rs @ r3
• components/script/dom/htmlscriptelement.rs @ r2
• components/script/dom/node.rs @ r3
• components/script/dom/text.rs @ r2
• components/script/script_task.rs @ r3
• components/servo/Cargo.lock @ r2
• ports/cef/Cargo.lock @ r2
• ports/gonk/Cargo.lock @ r2

---

Comments from the review on Reviewable.io

[Manishearth]

@bors-servo r=kmc,munksgaard

(@Munksgaard reviewed rust-tenacious)

[bors-servo]

📌 Commit f770334 has been approved by kmc,munksgaard

[bors-servo]

⌛ Testing commit f770334 with merge 834f1e2...

[bors-servo]

💔 Test failed - linux1

[Manishearth]

@bors-servo: retry

[Ms2ger]

/home/servo/buildbot/slave/linux2/build/components/script/dom/element.rs:731:13: 731:17 warning: #[no_move] type `dom::bindings::js::Root<dom::attr::Attr>` moved, #[warn(moved_no_move)] on by default
/home/servo/buildbot/slave/linux2/build/components/script/dom/element.rs:731         for attr in attrs.iter().map(|attr| attr.root()) {
                                                                                         ^~~~
/home/servo/buildbot/slave/linux2/build/components/script/dom/element.rs:731:13: 731:17 warning: #[no_move] type `core::option::Option<dom::bindings::js::Root<dom::attr::Attr>>` moved, #[warn(moved_no_move)] on by default
/home/servo/buildbot/slave/linux2/build/components/script/dom/element.rs:731         for attr in attrs.iter().map(|attr| attr.root()) {
                                                                                         ^~~~
/home/servo/buildbot/slave/linux2/build/components/script/dom/htmlinputelement.rs:844:18: 844:24 warning: #[no_move] type `dom::bindings::js::Root<dom::htmlinputelement::HTMLInputElement>` moved, #[warn(moved_no_move)] on by default
/home/servo/buildbot/slave/linux2/build/components/script/dom/htmlinputelement.rs:844             Some(button) => {
                                                                                                       ^~~~~~
/home/servo/buildbot/slave/linux2/build/components/script/dom/htmlinputelement.rs:844:13: 844:25 warning: #[no_move] type `core::option::Option<dom::bindings::js::Root<dom::htmlinputelement::HTMLInputElement>>` moved, #[warn(moved_no_move)] on by default
/home/servo/buildbot/slave/linux2/build/components/script/dom/htmlinputelement.rs:844             Some(button) => {
                                                                                                  ^~~~~~~~~~~~

[Manishearth]

ick, I thought I fixed that. Must have lost it in a rebase.

[Manishearth]

@bors-servo r=kmc,munksgaard

[bors-servo]

📌 Commit 0000000 has been approved by kmc,munksgaard

[Manishearth]

@bors-servo r=kmc,munksgaard

[bors-servo]

📌 Commit 0000000 has been approved by kmc,munksgaard

[Manishearth]

@bors-servo r=kmc,munksgaard c1b9910

[bors-servo]

🙀 c1b9910 is not a valid commit SHA. Please try again with 0000000.

[Manishearth]

wha

[Manishearth]

@bors-servo r=kmc,munksgaard c1b9910

[bors-servo]

🙀 c1b9910 is not a valid commit SHA. Please try again with 0000000.

[Manishearth]

@bors-servo: r=kmc,munksgaard 369a568

[Manishearth]

@bors-servo: r-

[Manishearth]

@bors-servo: r=kmc,munksgaard 369a568

[Manishearth]

@bors-servo: r=kmc,munksgaard 369a568

[Manishearth]

ah, works now.

[bors-servo]

⌛ Testing commit 369a568 with merge d7987e4...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2