Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid casting in the callers #6299

Merged
merged 1 commit into from
Jun 7, 2015
Merged

Conversation

GreenRecycleBin
Copy link
Contributor

get_proto_or_iface_array now returns *mut ProtoOrIfaceArray

Fix #6271

Review on Reviewable

get_proto_or_iface_array now returns *mut ProtoOrIfaceArray

Fix servo#6271
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 6, 2015
@highfive
Copy link

highfive commented Jun 6, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5201

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 7, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 15c4f7f has been approved by Ms2ger

@bors-servo
Copy link
Contributor

⌛ Testing commit 15c4f7f with merge ca6a34a...

bors-servo pushed a commit that referenced this pull request Jun 7, 2015
get_proto_or_iface_array now returns *mut ProtoOrIfaceArray

Fix #6271

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6299)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2

@bors-servo bors-servo merged commit 15c4f7f into servo:master Jun 7, 2015
@GreenRecycleBin GreenRecycleBin deleted the #6271 branch May 24, 2016 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-review There is new code that needs to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants