Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout: Don't panic if requestAnimationFrame() is called before first layout. #7220

Closed
wants to merge 1 commit into from
Closed

layout: Don't panic if requestAnimationFrame() is called before first layout. #7220

wants to merge 1 commit into from

Conversation

pcwalton
Copy link
Contributor

Closes #7115.

r? @glennw

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 14, 2015
@dzbarsky dzbarsky mentioned this pull request Aug 15, 2015
Merged
@glennw
Copy link
Member

glennw commented Aug 17, 2015

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 447ef18 has been approved by glennw

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 17, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 447ef18 with merge 5cf7307...

bors-servo pushed a commit that referenced this pull request Aug 17, 2015
Auto merge of #7220 - pcwalton:tick-animations-with-no-layout-root, r…
5cf7307 
…=glennw

layout: Don't panic if `requestAnimationFrame()` is called before first layout.

Closes #7115.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7220)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux2

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 17, 2015
@paulrouget paulrouget mentioned this pull request Aug 18, 2015
Closed
92 tasks
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 20, 2015

#7294

@Ms2ger Ms2ger closed this Aug 20, 2015
@SimonSapin SimonSapin removed the S-tests-failed The changes caused existing tests to fail. label Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pcwalton @glennw @bors-servo @Ms2ger @SimonSapin @paulrouget @highfive