Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout: Don't panic if requestAnimationFrame() is called before first layout. #7294

Merged
merged 1 commit into from
Aug 20, 2015
Merged

layout: Don't panic if requestAnimationFrame() is called before first layout. #7294

merged 1 commit into from
Aug 20, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 20, 2015

Closes #7115.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 20, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 20, 2015

@bors-servo r=glennw r+

Fixed the test.

@bors-servo
Copy link
Contributor

📌 Commit 575047c has been approved by Ms2ger

@bors-servo
Copy link
Contributor

📌 Commit 575047c has been approved by glennw

@highfive highfive removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 20, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 575047c with merge 74b2e1b...

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 20, 2015
bors-servo pushed a commit that referenced this pull request Aug 20, 2015
Auto merge of #7294 - servo:tick-animations-with-no-layout-root, r=gl…
74b2e1b 
…ennw

layout: Don't panic if `requestAnimationFrame()` is called before first layout.

Closes #7115.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7294)
<!-- Reviewable:end -->
@Ms2ger Ms2ger mentioned this pull request Aug 20, 2015
Closed
@bors-servo
Copy link
Contributor

💔 Test failed - mac1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 20, 2015
nox
nox reviewed Aug 20, 2015
View reviewed changes
components/layout/layout_task.rs
self.profiler_metadata(),
self.time_profiler_chan.clone(),
|| animation::recalc_style_for_animations(root_flow.deref_mut(), animations));
match rw_data.root_flow.as_ref() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if let Some(ref root_flow) =?

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 20, 2015

Gah, looks like rAF just doesn't work headless.

@Ms2ger Ms2ger force-pushed the tick-animations-with-no-layout-root branch from 575047c to a516042 Compare August 20, 2015 11:17
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 20, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Aug 20, 2015

@bors-servo r=glennw+Ms2ger

@bors-servo
Copy link
Contributor

📌 Commit a516042 has been approved by glennw+Ms2ger

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 20, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit a516042 with merge 8f05447...

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 20, 2015
bors-servo pushed a commit that referenced this pull request Aug 20, 2015
Auto merge of #7294 - servo:tick-animations-with-no-layout-root, r=gl…
8f05447 
…ennw+Ms2ger

layout: Don't panic if `requestAnimationFrame()` is called before first layout.

Closes #7115.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7294)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3

@bors-servo bors-servo merged commit a516042 into master Aug 20, 2015
This was referenced Aug 20, 2015
Merged
Merged
@SimonSapin SimonSapin deleted the tick-animations-with-no-layout-root branch August 20, 2015 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ms2ger @bors-servo @nox @highfive @pcwalton