Remove Emitter::markers. #7386
Merged
Remove Emitter::markers. #7386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vector is filled in and immediately emptied again. It is clearer to keep the vector in the caller instead.
highfive
added
the
S-awaiting-review
|
@bors-servo: r+ |
|
📌 Commit 18b9532 has been approved by |
highfive
added
S-awaiting-merge
|
⌛ Testing commit 18b9532 with merge 0e78815... |
bors-servo
pushed a commit
that referenced
this pull request
Aug 26, 2015
Remove Emitter::markers. The vector is filled in and immediately emptied again. It is clearer to keep the vector in the caller instead. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7386) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vector is filled in and immediately emptied again. It is clearer to
keep the vector in the caller instead.