Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer JSTrue/JSFalse to 1/0 #7439

Merged
merged 1 commit into from
Aug 29, 2015
Merged

Prefer JSTrue/JSFalse to 1/0 #7439

merged 1 commit into from
Aug 29, 2015

Conversation

frewsxcv
Copy link
Contributor

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 29, 2015
@frewsxcv frewsxcv changed the title Cleanup, refactor FormDataMethods::Get Prefer JSTrue/JSFalse to 1/0 Aug 29, 2015
@jdm
Copy link
Member

jdm commented Aug 29, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 8f876a1 has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit 8f876a1 with merge 67cbda4...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 29, 2015
bors-servo pushed a commit that referenced this pull request Aug 29, 2015
Auto merge of #7439 - frewsxcv:jsfalse-jstrue, r=jdm
67cbda4 
Prefer JSTrue/JSFalse to 1/0



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7439)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 8f876a1 into servo:master Aug 29, 2015
@frewsxcv frewsxcv deleted the jsfalse-jstrue branch October 9, 2015 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frewsxcv @jdm @bors-servo @highfive