Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate URL-related interfaces and their tests up to spec #8008
Conversation
| pub fn SetProtocol(url: &mut Url, value: USVString) { | ||
| let mut wrapper = UrlUtilsWrapper { url: url, parser: &UrlParser::new() }; | ||
| let _ = wrapper.set_scheme(&value.0); | ||
| } | ||
|
|
||
| // https://html.spec.whatwg.org/multipage/#same-origin | ||
| // g |
This comment has been minimized.
This comment has been minimized.
|
@dzbarsky Fat-fingered this, good catch. |
|
|
The URL spec recently changed and the variour "mixins" interfaces are gone, this commit updates our code and WPT accordingly. The new expected failures related to HTMLAnchorElement and HTMLAreaElement's attributes are due to their moving to the HTMLHyperLinkElementUtils interface, which is not anymore in a separate <script class=untested> element.
|
@bors-servo: r+ Reviewed 19 of 19 files at r1, 3 of 3 files at r2. components/script/dom/location.rs, line 73 [r1] (raw file): components/script/dom/location.rs, line 102 [r1] (raw file): components/script/dom/webidls/HTMLAreaElement.webidl, line 16 [r1] (raw file): components/script/dom/webidls/HTMLHyperlinkElementUtils.webidl, line 8 [r1] (raw file): Comments from the review on Reviewable.io |
|
|
Update URL-related interfaces and their tests up to spec The URL spec recently changed and the variour "mixins" interfaces are gone, this commit updates our code and WPT accordingly. The new expected failures related to HTMLAnchorElement and HTMLAreaElement's attributes are due to their moving to the HTMLHyperLinkElementUtils interface, which is not anymore in a separate `<script class=untested>` element. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8008) <!-- Reviewable:end -->
|
|
|
Sigh. #7625 strikes again. |
|
@bors-servo retry Seems like it's ok again? |
|
|
|
Never mind, misread the bot in the IRC channel… |
|
|
nox commentedOct 13, 2015
The URL spec recently changed and the variour "mixins" interfaces are gone,
this commit updates our code and WPT accordingly.
The new expected failures related to HTMLAnchorElement and HTMLAreaElement's
attributes are due to their moving to the HTMLHyperLinkElementUtils interface,
which is not anymore in a separate
<script class=untested>element.