Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding wpt lint script to tidy checks #8742

Merged
merged 1 commit into from
Dec 1, 2015
Merged

adding wpt lint script to tidy checks #8742

merged 1 commit into from
Dec 1, 2015

Conversation

jmr0
Copy link
Contributor

@jmr0 jmr0 commented Nov 30, 2015

Fixes #8285.

Tidy check will fail, however, until we merge the latest https://github.com/w3c/web-platform-tests/blob/master/lint.whitelist

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 30, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 30, 2015

Thank you for your PR.

I'm fixing the failures in #8748.

-S-awaiting-review +S-needs-code-changes +S-needs-rebase

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

python/tidy.py, line 551 [r1] (raw file):
You should be able to use the cwd argument to subprocess.check_call.

Comments from the review on Reviewable.io

@Ms2ger Ms2ger added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. S-needs-rebase There are merge conflict errors. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 30, 2015
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Nov 30, 2015
@jmr0
Copy link
Contributor Author

jmr0 commented Nov 30, 2015

Thanks! let me know if I should squash these

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 30, 2015

Please squash and rebase on top of master; we should be able to land it then.

@jmr0
Copy link
Contributor Author

jmr0 commented Nov 30, 2015

All set :)

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 1, 2015

Thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit e301ff4 has been approved by Ms2ger

@highfive highfive removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Dec 1, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit e301ff4 with merge a8cbc28...

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 1, 2015
bors-servo pushed a commit that referenced this pull request Dec 1, 2015
Auto merge of #8742 - jmr0:master, r=Ms2ger
a8cbc28 
adding wpt lint script to tidy checks

Fixes #8285.

Tidy check will fail, however, until we merge the latest https://github.com/w3c/web-platform-tests/blob/master/lint.whitelist

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8742)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit e301ff4 into servo:master Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmr0 @Ms2ger @bors-servo @highfive