New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue9185 #9248
Issue9185 #9248
Conversation
…sue9185 Conflicts: components/script/dom/htmlscriptelement.rs
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
r? @Ms2ger |
@bors-servo: try |
⌛ Trying commit 86e1030 with merge d374876... |
Issue9185 I have to write tests yet, but I wanted to see full Travis CI output. Fixes #9185 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9248) <!-- Reviewable:end -->
💔 Test failed - linux-rel |
@bors-servo retry
|
⌛ Trying commit 86e1030 with merge f6cc563... |
Issue9185 I have to write tests yet, but I wanted to see full Travis CI output. Fixes #9185 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9248) <!-- Reviewable:end -->
💔 Test failed - linux-rel |
@bors-servo: retry
|
⌛ Trying commit 86e1030 with merge 3dc2e7c... |
Issue9185 I have to write tests yet, but I wanted to see full Travis CI output. Fixes #9185 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9248) <!-- Reviewable:end -->
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
Wow, I didn't know about "try". So far so good. Now I need to add tests. Can someone suggest me what kind of tests? wpt, or unit-tests? |
These changes are affecting the HTML script element, so you'll need WPT tests. Also, "try" is a privileged command that only reviewers or people with "try" access can use. |
That being said, you're welcome to add yourself to that list: https://github.com/servo/saltfs/blob/master/homu/cfg.toml#L83 |
You can just retry it until it passes. But since you're just doing a "try" run, all you really care about is whether WPT tests relevant to your PR are failing, and looking at the results, they aren't. |
@bors-servo: retry |
Issue9185 I have to write tests yet, but I wanted to see full Travis CI output. Fixes #9185 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9248) <!-- Reviewable:end -->
@bors-servo try- |
@bors-servo r- clean force |
@bors-servo r- clean try- force |
@bors-servo clean retry |
@askalski Can you try |
@KiChjang yeah, you are right! |
The commits need to be rebased to remove that local merge, and then they need to be squashed together. |
@bors-servo try |
Issue9185 I have to write tests yet, but I wanted to see full Travis CI output. Fixes #9185 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9248) <!-- Reviewable:end -->
💔 Test failed - linux-rel |
@askalski Is this still being worked on? |
I was waiting for review to know what to fix. |
I believe @nox gave a reply to rebase and squash? |
I seem to have lost track of this PR; apologies for that. I'll try to review tomorrow. |
Tomorrow came and went... |
Reviewed and addressed some issues at #10079. Thanks for your contribution, and again my apologies for dropping the ball here. |
I have to write tests yet, but I wanted to see full Travis CI output.
Fixes #9185