This repository has been archived by the owner on Aug 10, 2023. It is now read-only.
Support preserving the drawing buffer between swaps. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2020
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jul 28, 2020
Support preserveDrawingBuffer Depends on servo/surfman-chains#9 and servo/webxr#190. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24604 - [x] There are tests for these changes
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jul 28, 2020
Support preserveDrawingBuffer Depends on servo/surfman-chains#9 and servo/webxr#190. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24604 - [x] There are tests for these changes
|
r? @asajeffrey |
|
LGTM. Can you add a major version bump and I'll merge and publish it? |
|
Hmm, we could avoid the major bump with a different API, which adds a function to blit the front buffer to the back buffer. |
|
I looked into that at first, but it's possible for the front buffer to be taken by the consumer before it can be blitted. The blit needs to happen while we know the status of both surfaces. |
|
Good point. |
bors-servo
added a commit
to servo/webxr
that referenced
this pull request
Aug 6, 2020
Adjust for surfman-chains swapping changes. Depends on servo/surfman-chains#9.
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Aug 6, 2020
Support preserveDrawingBuffer Depends on servo/surfman-chains#9 and servo/webxr#190. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24604 - [x] There are tests for these changes
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Aug 6, 2020
Support preserveDrawingBuffer Depends on servo/surfman-chains#9 and servo/webxr#190. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24604 - [x] There are tests for these changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.