Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace removal broke publishing #302

Open
jdm opened this issue Aug 3, 2024 · 2 comments
Open

Workspace removal broke publishing #302

jdm opened this issue Aug 3, 2024 · 2 comments

Comments

@jdm
Copy link
Member

jdm commented Aug 3, 2024

There are several issues:

  1. the workspace removal and subsequent restructuring broke a number of symlinks that are present in the android-example subdirectory (https://github.com/servo/surfman/tree/main/android-example/app/src/main/assets and https://github.com/servo/surfman/tree/main/android-example/app/src/main/jniLibs/arm64-v8a)
  2. cargo publish attempts to verify that all files in android-example are actually present, so we can't publish without fixing the first issue
  3. the changes in 1a522fa broke android-example compilation (incidentally, renaming a public module should have been a breaking change and caused 0.10.0)
  4. android-example compilation is no longer verified in CI, so we didn't detect issue 3
@jdm
Copy link
Member Author

jdm commented Aug 3, 2024

I worked around this for 0.9.5 by fixing the assets symlinks, unlinking the missing .so, and running with --allow-dirty.

@jschwe
Copy link
Contributor

jschwe commented Aug 23, 2024

Just a note - the android example was already broken.
We definitely should add cargo semver checks to CI though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants