Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raw-window-handle to 0.6, core-graphics to 0.23, and cocoa to 0.25 #275

Merged
merged 13 commits into from
Mar 15, 2024

Conversation

Nopey
Copy link
Contributor

@Nopey Nopey commented Feb 13, 2024

These are the latest versions of each crate.

@mrobinson
Copy link
Member

0.6 of raw-window-handle also exposes new traits which should be supported as well. The best way to do this would probably be to expose a feature which controls which versions of raw-window-handle are supported like winit does.

@Nopey
Copy link
Contributor Author

Nopey commented Feb 26, 2024

Split sm-raw-window-handle feature into sm-raw-window-handle-06 and sm-raw-window-handle-05 feature, with the latter's functions all being suffixed by raw_window_handle_05; these two features are not mutually exclusive.

sm-raw-window-handle-06 is a default feature.

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sincere apologies for the delay in reviewing! This look good in theory with one significant change. Let's not use the deprecated types in the new version of raw-window-handle and that way we can avoid the oddly named _05 functions in the public API (which aren't very future proof).

surfman/src/connection.rs Outdated Show resolved Hide resolved
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks great. I just have some suggestions around documentation consistency and correctness.

surfman/examples/threads.rs Outdated Show resolved Hide resolved
surfman/examples/threads.rs Outdated Show resolved Hide resolved
surfman/src/connection.rs Outdated Show resolved Hide resolved
surfman/src/connection.rs Outdated Show resolved Hide resolved
surfman/src/platform/android/connection.rs Outdated Show resolved Hide resolved
surfman/src/platform/windows/wgl/connection.rs Outdated Show resolved Hide resolved
surfman/src/platform/windows/wgl/connection.rs Outdated Show resolved Hide resolved
surfman/src/platform/unix/x11/connection.rs Outdated Show resolved Hide resolved
surfman/src/platform/unix/x11/connection.rs Outdated Show resolved Hide resolved
surfman/src/platform/generic/multi/connection.rs Outdated Show resolved Hide resolved
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some build failures on various platforms. These will need to be fixed before landing.

@Nopey
Copy link
Contributor Author

Nopey commented Mar 15, 2024

Thanks for fixing the workflow yml; I was able to clear those compiler errors up after running CI a few times.

@mrobinson
Copy link
Member

Thanks for all your hard work here @Nopey! I'll send this to the MQ.

@mrobinson mrobinson added this pull request to the merge queue Mar 15, 2024
Merged via the queue into servo:main with commit e42ca0d Mar 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants