-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update raw-window-handle to 0.6, core-graphics to 0.23, and cocoa to 0.25 #275
Conversation
0.6 of |
Split sm-raw-window-handle-06 is a default feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sincere apologies for the delay in reviewing! This look good in theory with one significant change. Let's not use the deprecated types in the new version of raw-window-handle
and that way we can avoid the oddly named _05
functions in the public API (which aren't very future proof).
This example segfaults on my machine (even before this PR); despite this, I think having it compile is valuable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks great. I just have some suggestions around documentation consistency and correctness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some build failures on various platforms. These will need to be fixed before landing.
Thanks for fixing the workflow yml; I was able to clear those compiler errors up after running CI a few times. |
Thanks for all your hard work here @Nopey! I'll send this to the MQ. |
These are the latest versions of each crate.