Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3u8::Playlist.read("path/to/file") fails silently #20

Closed
jbodah opened this issue Mar 6, 2017 · 2 comments
Closed

M3u8::Playlist.read("path/to/file") fails silently #20

jbodah opened this issue Mar 6, 2017 · 2 comments

Comments

@jbodah
Copy link

jbodah commented Mar 6, 2017

Had a few minutes of head scratching when I tried calling M3u8::Playlist.read with a path before I realized I needed an IO object. Calling read with a path doesn't throw an error and returns a playlist regardless

irb(main):002:0> M3u8::Playlist.read("~/Desktop/long_hls")
=> #<M3u8::Playlist:0x007fb77388de20 @version=nil, @sequence=0, @cache=nil, @target=10, @type=nil, @iframes_only=false, @independent_segments=false, @items=[]>
@sethdeckard
Copy link
Owner

Good catch, I agree that the reader should raise an error if the first line does not contain the #EXTM3U tag.

sethdeckard added a commit that referenced this issue Apr 13, 2017
Error will now be raised if first line of playlist content does
not contain the #EXTM3U tag.
@sethdeckard
Copy link
Owner

Fixed in v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants