Stop using absolute times in HTTP/2 per-thread test #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the latest CI run with this change: https://github.com/pquentin/urllib3/actions/runs/9108573005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a suggestion for a more robust version of a test that has been plaguing urllib3#3324. The idea is that with locking, a precise sequence of events must happen. We still look at the time, but only to make sure that events happen in a specific sequence. That way, even on a super slow CI host, the test should succeed. I can see myself placing callbacks in more places when we implement more HTTP/2 things.
The downside is that it clutters connection.py. But I don't think it's going to slow things down for users, as it's only adding a few ifs.