Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call API to send bonuses #836

Merged
merged 7 commits into from
Jul 5, 2023
Merged

Conversation

Ovifer13
Copy link
Collaborator

@Ovifer13 Ovifer13 commented Jun 26, 2023

Issue #829

  • Call API when sending bonuses
  • Handle successful and failed payments

Proof
image
image

@Ovifer13 Ovifer13 linked an issue Jun 26, 2023 that may be closed by this pull request
@Ovifer13 Ovifer13 requested a review from otech47 June 26, 2023 20:30
@sofiaromorales sofiaromorales temporarily deployed to trinary-staging June 26, 2023 20:30 Inactive
Copy link
Member

@otech47 otech47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor ContributorInput in the PaymentType schema to disambiguate it

i suggest

input ContributorBonus {
  contributor_id: Int!,
  amount_to_pay: Int!,
}

Copy link
Member

@otech47 otech47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sendPayment function, the contributors could be more explicit as contributorsToPay

@Ovifer13 Ovifer13 requested a review from otech47 June 28, 2023 20:11
@otech47 otech47 merged commit 3bc6980 into develop Jul 5, 2023
@otech47 otech47 deleted the or/issue-829/call-api-send-bonus branch July 5, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call API to send bonuses
3 participants