Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#49] Fixed NPE when credentials not set on Linux #50

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

g3force
Copy link
Collaborator

@g3force g3force commented Sep 10, 2017

Correctly check for missing credentials value

@ghost
Copy link

ghost commented Sep 10, 2017

Your pull request doesn't follow our guidelines. Please fix the following:

  • Pull request description cannot be empty (?)
  • Pull request title must not end with a dot (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@g3force g3force changed the title [#49] Fixed NPE when credentials not set on Linux. [#49] Fixed NPE when credentials not set on Linux Sep 10, 2017
@coveralls
Copy link

coveralls commented Sep 10, 2017

Coverage Status

Coverage remained the same at 89.583% when pulling e9ae448 on g3force:#49 into 0263d95 on seu-as-code:master.

@ghost
Copy link

ghost commented Sep 10, 2017

This pull request still violates some of our guidelines:

  • Pull request description cannot be empty (?)

Click here for details.

@ghost
Copy link

ghost commented Sep 10, 2017

Thank you, the title and description now looks good! :bowtie:

@lreimer lreimer merged commit e9747f5 into seu-as-code:master Feb 2, 2018
@lreimer
Copy link
Collaborator

lreimer commented Feb 2, 2018

Published 2.6.0 to Bintray and Gradle Plugin Portal: https://plugins.gradle.org/plugin/de.qaware.seu.as.code.credentials
Fixes #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants