Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read permissions to run-puma script #60

Closed
wants to merge 1 commit into from

Conversation

repomaa
Copy link

@repomaa repomaa commented Aug 11, 2014

Fixes issue #59

@seuros
Copy link
Owner

seuros commented Aug 11, 2014

I don't think it safe.
All other processes require root to executed, also the +r allow you to read the content of the file not run it.

@repomaa
Copy link
Author

repomaa commented Aug 11, 2014

With +x you give executing permissions to all users. You cannot however execute a script if it's not readable. I don't see any security concerns in making it readable, since it doesn't contain any critical information (passwords or similar).

@seuros
Copy link
Owner

seuros commented Aug 11, 2014

Any user can turn off the process then.

@repomaa
Copy link
Author

repomaa commented Aug 11, 2014

No, just the user that started it..

@repomaa
Copy link
Author

repomaa commented Aug 11, 2014

If i understand correctly you suggest that run-puma should be run as root. Wouldn't that run puma itself at root (something you most definitely wouldn't want).

@seuros
Copy link
Owner

seuros commented Aug 11, 2014

No, what i did before (I don't use jungle anymore): Is that i assign the run_puma to a group where only the users allowed to run it are added.

@repomaa
Copy link
Author

repomaa commented Aug 11, 2014

Alright, that's a good solution too, although it's not exactly plug 'n' play. Documentation regarding this would be nice though.

@seuros
Copy link
Owner

seuros commented Aug 11, 2014

I'm planning in adding upstart and improved version of monit tasks.
These tools are much better since they will restart the process if it crash unexpectedly.

@repomaa repomaa closed this Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants