Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Demucs v3/hdemucs_mmi inference #17

Merged
merged 51 commits into from
May 6, 2024
Merged

Add Demucs v3/hdemucs_mmi inference #17

merged 51 commits into from
May 6, 2024

Conversation

sevagh
Copy link
Owner

@sevagh sevagh commented Apr 16, 2024

Addressing #11 - let's add the architecture of Demucs v3

Advantages:

  • Demucs v3 (hdemucs_mmi) has it's own performance characteristics that may be better on some music
  • It is (probably) faster since it doesn't have the crosstransformer in the middle

@sevagh
[WIP] Demucs v3 mmi
ee5d580
@sevagh
Adjust more v3 sizes
a4b775c
@sevagh
Add encoders 4, 5 (bilstm + localattn)
688613c
@sevagh
Load all decoder layers
e8cfec2
@sevagh
Start working on inference pass
bc3230c
@sevagh
Add inference for t/encoder 0
2364d19
@sevagh
T/encoder 0-3 done
2ab93ea
@sevagh
Add unique tencoder-4
c117bf1
@sevagh
Begin working on LSTM
51b736b
@sevagh
LSTM sorta correct
a4bb0fb
@sevagh
Now add lstm linear layer
f00c446
@sevagh
More progress in LocalState
f51fd1d
@sevagh
Keep working on LocalState/dot
5b2e4b3
@sevagh
Merge some for loops
4eb0b5a
@sevagh
Try stitching together both dconv modules
eb0894f
@sevagh
Dconv corrections
0b40678
@sevagh
More corrections for encoder 4
bff785a
@sevagh
Fix encoder 5
eb0be43
@sevagh
Start working on decoders
0e4bc30
@sevagh
Decoders are pure chaos
e119b7b
@sevagh
Move v3-specific group norms to v3 namespace
8538ffb
@sevagh
Reuse existing group norm functions
ebae57c
@sevagh
Fix eigen dim bugs in encoders
9722d35
@sevagh
Working on common decoder layers
a074fd3
@sevagh
Implement common decoder layer
251b175
@sevagh
Fix up final decoders
989321b
@sevagh
Produce target waveforms
d03bba3
@sevagh
Record initial (buggy) performance
15a6b14
@sevagh
Debug conv1d issue
84e8c9e
@sevagh
Some conv2d fixes
9b46d68
@sevagh sevagh marked this pull request as ready for review May 5, 2024 21:42
@sevagh sevagh changed the title [WIP] Demucs v3 mmi Add Demucs v3/hdemucs_mmi inference May 6, 2024
@sevagh sevagh merged commit 84e62f0 into main May 6, 2024
@sevagh sevagh deleted the demucs-v3-mmi branch May 6, 2024 11:35
@sevagh sevagh mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sevagh