Updated Gopkg.lock / vendor #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this just a general update of all the dependencies? Or was there a sync problem with the lock file and toml file? |
|
Yep, just a general update. It compiles fine and still seems to work properly 👌 |
|
out of curiosity, is there any particular reason/concerns not to put |
|
https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory It's an additional safety measure in case my dependencies change, disappear, etc. |
|
ah ok, cool, thanks for the info 👍 |
|
Thanks for all the contributions. Are you using goat in production? |
|
yw! not yet but we are planning to! :) |
sevagh
pushed a commit
that referenced
this pull request
Nov 21, 2018
sevagh
pushed a commit
that referenced
this pull request
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.