Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for riscv64 on Linux #75

Merged
merged 1 commit into from
May 8, 2021
Merged

Conversation

Civil
Copy link
Contributor

@Civil Civil commented May 1, 2021

Linux on riscv64 doesn't have support for Dup2 syscall,
but as in case with arm64 it defines Dup3 syscall.

  • Rename syscall_dup_arm64 to syscall_dup3
  • Add a conditional compilation comment there to compile it on riscv64 as well

Fixes #74

Linux on riscv64 doesn't have support for Dup2 syscall,
but as in case with arm64 it defines Dup3 syscall.

 * Rename syscall_dup_arm64 to syscall_dup3
 * Add a conditional compilation comment there to compile it on riscv64 as well
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #75 (e36527e) into master (bf83969) will decrease coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   15.89%   14.56%   -1.33%     
==========================================
  Files          10        8       -2     
  Lines         258      206      -52     
==========================================
- Hits           41       30      -11     
+ Misses        212      171      -41     
  Partials        5        5              
Impacted Files Coverage Δ
lock_file.go 58.97% <0.00%> (-5.61%) ⬇️
lock_file_unix.go 75.00% <0.00%> (-5.00%) ⬇️
signal.go 7.14% <0.00%> (-2.39%) ⬇️
daemon.go 0.00% <0.00%> (ø)
command.go 0.00% <0.00%> (ø)
daemon_unix.go 0.00% <0.00%> (ø)
syscall_dup_pre17.go 0.00% <0.00%> (ø)
os_executable_pre18.go 0.00% <0.00%> (ø)
os_executable.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf83969...e36527e. Read the comment docs.

@deniszh deniszh merged commit 15bb82c into sevlyar:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTBS on riscv64
2 participants