Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: testing webhook #15

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: testing webhook #15

wants to merge 1 commit into from

Conversation

Azhng
Copy link

@Azhng Azhng commented Jun 3, 2020

testing webhook


This change is Reviewable

@Azhng Azhng requested a review from sexxi-bot June 3, 2020 19:04
@sexxi-bot
Copy link
Collaborator

Start running build job...

@Azhng Azhng removed the request for review from sexxi-bot June 3, 2020 19:10
@sexxi-bot
Copy link
Collaborator

Start running build job...

@Azhng Azhng requested review from sexxi-bot and removed request for sexxi-bot June 3, 2020 19:10
@sexxi-bot
Copy link
Collaborator

Start running build job...

@sexxi-bot
Copy link
Collaborator

Job Completed, access build log here

@Azhng Azhng requested review from sexxi-bot and removed request for sexxi-bot June 3, 2020 20:20
@sexxi-bot
Copy link
Collaborator

Start running build job...

@sexxi-bot
Copy link
Collaborator

Build job 6c85cdd2-5e89-4643-b3c5-f92cd3b8498e failed, access buidl log here: unit test failed: remote command failed: exit code: 1

@Azhng Azhng removed the request for review from sexxi-bot June 3, 2020 20:58
@sexxi-bot
Copy link
Collaborator

Start running build job, job id: 74cd4a5f-437d-4b5e-b279-e403fe079855

@Azhng Azhng requested a review from sexxi-bot June 3, 2020 20:58
@sexxi-bot
Copy link
Collaborator

Build job 74cd4a5f-437d-4b5e-b279-e403fe079855 failed, access build log here: unit test failed: remote command failed: exit code: 1

@Azhng Azhng requested review from sexxi-bot and removed request for sexxi-bot June 3, 2020 21:13
@sexxi-bot
Copy link
Collaborator

🤔 Start running build job, job id: 71de4116-2b44-46d1-9d76-faab4744329a

@sexxi-bot
Copy link
Collaborator

❌ Build job 71de4116-2b44-46d1-9d76-faab4744329a failed, access build log here: unable to update submodules: remote command failed: exit code: 1

@Azhng Azhng removed the request for review from sexxi-bot June 3, 2020 21:23
@sexxi-bot
Copy link
Collaborator

🤔 Start running build job, job id: da0a04f4-4041-4252-b612-91fe7c839562

@Azhng Azhng requested a review from sexxi-bot June 3, 2020 21:23
@sexxi-bot
Copy link
Collaborator

❌ Build job da0a04f4-4041-4252-b612-91fe7c839562 failed, access build log here: unable to check out sha: remote command failed: exit code: 128

@Azhng Azhng requested review from sexxi-bot and removed request for sexxi-bot June 3, 2020 21:26
@sexxi-bot
Copy link
Collaborator

🤔 Start running build job, job id: 6982245f-dc4c-4613-8de7-accd15d42af6

@sexxi-bot
Copy link
Collaborator

🏃‍♂️ Start running build job, job id: 40fa7bad-0707-4f04-81b9-6989ce0775fa

@roxelo roxelo removed the request for review from sexxi-bot June 25, 2020 19:18
@sexxi-bot
Copy link
Collaborator

❌ Build job 40fa7bad-0707-4f04-81b9-6989ce0775fa failed, access build log here: unit test failed: job canceled

@roxelo roxelo requested a review from sexxi-bot June 25, 2020 19:21
@sexxi-bot
Copy link
Collaborator

🏃‍♂️ Start running build job, job id: bd0e08d0-eb40-4882-b667-743771f46027

@sexxi-bot
Copy link
Collaborator

✅ Job Completed, access build log here

@roxelo roxelo requested review from sexxi-bot and removed request for sexxi-bot June 26, 2020 01:29
@sexxi-bot
Copy link
Collaborator

🏃‍♂️ Start running build job, job id: 63cac424-9b38-4b31-a88e-4586135f8ca2

@roxelo roxelo requested review from sexxi-bot and removed request for sexxi-bot June 26, 2020 01:38
@sexxi-bot
Copy link
Collaborator

🏃‍♂️ Start running build job, job id: 8560d0a2-f7c4-42e3-af11-90a189c25065

@roxelo roxelo removed the request for review from sexxi-bot June 26, 2020 01:38
@sexxi-bot
Copy link
Collaborator

❌ Build job 8560d0a2-f7c4-42e3-af11-90a189c25065 failed, access build log here: unit test failed: job canceled

@roxelo roxelo requested a review from sexxi-bot June 26, 2020 01:46
@sexxi-bot
Copy link
Collaborator

🏃‍♂️ Start running build job, job id: f44a634c-6e6f-4778-bad4-85bbbd1bc584

@roxelo roxelo requested review from sexxi-bot and removed request for sexxi-bot June 26, 2020 01:52
@sexxi-bot
Copy link
Collaborator

🏃‍♂️ Start running build job, job id: 548c1fb7-e19b-465b-83d5-ae95f48c162e

@roxelo roxelo requested review from sexxi-bot and removed request for sexxi-bot June 26, 2020 02:00
@sexxi-bot
Copy link
Collaborator

🏃‍♂️ Start running build job, job id: aaee7570-9f45-4550-ad4d-7b12168f79a9

@roxelo roxelo requested review from sexxi-bot and removed request for sexxi-bot June 26, 2020 02:01
@sexxi-bot
Copy link
Collaborator

🏃‍♂️ Start running build job, job id: 4d09df92-26ab-4a60-8807-6d2ee1d3e747

sexxi-bot pushed a commit that referenced this pull request Oct 5, 2020
This is a combination of 18 commits.

Commit #2:

Additional examples and some small improvements.

Commit #3:

fixed mir-opt non-mir extensions and spanview title elements

Corrected a fairly recent assumption in runtest.rs that all MIR dump
files end in .mir. (It was appending .mir to the graphviz .dot and
spanview .html file names when generating blessed output files. That
also left outdated files in the baseline alongside the files with the
incorrect names, which I've now removed.)

Updated spanview HTML title elements to match their content, replacing a
hardcoded and incorrect name that was left in accidentally when
originally submitted.

Commit #4:

added more test examples

also improved Makefiles with support for non-zero exit status and to
force validation of tests unless a specific test overrides it with a
specific comment.

Commit #5:

Fixed rare issues after testing on real-world crate

Commit #6:

Addressed PR feedback, and removed temporary -Zexperimental-coverage

-Zinstrument-coverage once again supports the latest capabilities of
LLVM instrprof coverage instrumentation.

Also fixed a bug in spanview.

Commit #7:

Fix closure handling, add tests for closures and inner items

And cleaned up other tests for consistency, and to make it more clear
where spans start/end by breaking up lines.

Commit #8:

renamed "typical" test results "expected"

Now that the `llvm-cov show` tests are improved to normally expect
matching actuals, and to allow individual tests to override that
expectation.

Commit #9:

test coverage of inline generic struct function

Commit #10:

Addressed review feedback

* Removed unnecessary Unreachable filter.
* Replaced a match wildcard with remining variants.
* Added more comments to help clarify the role of successors() in the
CFG traversal

Commit #11:

refactoring based on feedback

* refactored `fn coverage_spans()`.
* changed the way I expand an empty coverage span to improve performance
* fixed a typo that I had accidently left in, in visit.rs

Commit #12:

Optimized use of SourceMap and SourceFile

Commit rust-lang#13:

Fixed a regression, and synched with upstream

Some generated test file names changed due to some new change upstream.

Commit #14:

Stripping out crate disambiguators from demangled names

These can vary depending on the test platform.

Commit #15:

Ignore llvm-cov show diff on test with generics, expand IO error message

Tests with generics produce llvm-cov show results with demangled names
that can include an unstable "crate disambiguator" (hex value). The
value changes when run in the Rust CI Windows environment. I added a sed
filter to strip them out (in a prior commit), but sed also appears to
fail in the same environment. Until I can figure out a workaround, I'm
just going to ignore this specific test result. I added a FIXME to
follow up later, but it's not that critical.

I also saw an error with Windows GNU, but the IO error did not
specify a path for the directory or file that triggered the error. I
updated the error messages to provide more info for next, time but also
noticed some other tests with similar steps did not fail. Looks
spurious.

Commit #16:

Modify rust-demangler to strip disambiguators by default

Commit #17:

Remove std::process::exit from coverage tests

Due to Issue rust-lang#77553, programs that call std::process::exit() do not
generate coverage results on Windows MSVC.

Commit #18:

fix: test file paths exceeding Windows max path len
arora-aman pushed a commit that referenced this pull request Oct 28, 2020
@Azhng Azhng closed this Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants