Fix E9x effect bug that would cause it to always retrigger on tick 1. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. I hope that this doesn't open a can of worms :) |
|
I can't imagine this made anything worse off than it was before... :( |
|
OK :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the overtly wrong behavior of the .MOD
E9xretrigger effect and attempts to at least establish a sensible default behavior in the spirit of what the original code here was supposed to do. As mentioned by @sagamusix in #21 this probably will need to be followed up with careful inspection/correction for individual formats and .MOD variants (I commented a list of different affected formats also in that issue).