Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errors if connections can't be initiated #16

Closed
reem opened this issue Oct 30, 2015 · 3 comments
Closed

Better errors if connections can't be initiated #16

reem opened this issue Oct 30, 2015 · 3 comments

Comments

@reem
Copy link

reem commented Oct 30, 2015

Right now all one gets is InitializationError(()) which gives very little information about what could have gone wrong, even if there is an informative error from the connection-opening function.

@sfackler
Copy link
Owner

The errors will be forwarded to the configured error handler where they can be e.g. logged.

We could theoretically forward all of the connection errors to the connection call, but there can be an unbounded amount of them depending on how long the initialization timeout is, and there could even be none.

@sfackler
Copy link
Owner

sfackler commented Jan 8, 2016

The next breaking release will have a couple of changes here: The default error handler will log instead of discarding errors, and the last error message will be saved off and put in initialization/get timeout errors: 99b19cc. It's not the actual error value since the error handler consumes those. We could change it to only get passed a reference to allow them to be stored off, but that seems not super worth it.

@sfackler
Copy link
Owner

Fixed in 0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants