Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION] lib atomic is loaded dynamic again on armv6 with openssl-sys v0.9.93 #2043

Closed
BlackDex opened this issue Sep 13, 2023 · 3 comments · Fixed by #2094
Closed

[REGRESSION] lib atomic is loaded dynamic again on armv6 with openssl-sys v0.9.93 #2043

BlackDex opened this issue Sep 13, 2023 · 3 comments · Fixed by #2094

Comments

@BlackDex
Copy link
Contributor

Since #1925 the issue described in #1779 is back again.

Not sure why this is reverted though. If i pin openssl-sys to v0.9.92` it works again, but that doesn't seem to be a good long-term-solution.

Is there some way this can be optional, or that it uses static instead of dylib when some flag is set?
This makes static build binaries break because this forces rustc to dynamically link to atomic.

If you need more information, please let me know.

BlackDex added a commit to BlackDex/rust-musl that referenced this issue Sep 14, 2023
- Updated cURL, OpenSSL and SQLite
- Updated Github workflow
- Some small changes
- Fixed `openssl-sys` version to prevent armv6/armel building failure
  See: sfackler/rust-openssl#2043
@link2xt
Copy link

link2xt commented Oct 7, 2023

I have what seems to be the same problem here: deltachat/deltachat-core-rust#4799

@link2xt
Copy link

link2xt commented Oct 15, 2023

I made a PR reverting a revert once again to move this forward a bit: #2058

@link2xt
Copy link

link2xt commented Oct 15, 2023

I have managed to workaround this issue with -DBROKEN_CLANG_ATOMICS: deltachat/deltachat-core-rust@54ea3ec

BlackDex added a commit to BlackDex/rust-openssl that referenced this issue Nov 14, 2023
Since sfackler#1925 building static binaries fails because of a hardcoded `dylib`.
Removing the `dylib` but still let rust search for the dependency it
will still link it.

This should still keep sfackler#1645 fixed but also fixes sfackler#2043.

I have tested this by building Vaultwarden for both dynamically linked
debian based image, and a statically linked musl/alpine based image.
But are using OpenSSL v3.x.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants