Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid extra clone in config if possible #1137

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Avoid extra clone in config if possible #1137

merged 1 commit into from
Jul 6, 2024

Commits on May 2, 2024

  1. Avoid extra clone in config if possible 

    Using `impl Into<String>` instead of `&str` in a fn arg allows both `&str` and `String` as parameters - thus if the caller already has a String object that it doesn't need, it can pass it in without extra cloning.

The same might be done with the password, but may require closer look.
    @nyurik
    nyurik committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3c6dbe9 View commit details
    Browse the repository at this point in the history