add requirements file #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current modules used in all files For easy use with pip install -r --upgrade requirements.txt
|
Looks good! Thanks for putting this together. |
pahdo
approved these changes
Jan 11, 2019
|
Can you squash these commits when merging? |
|
@pahdo I've made it a setting to only allow squash commits when merging a pull request. I generally agree with this approach as it keeps |
VincentLa14
requested changes
Jan 15, 2019
There was a problem hiding this comment.
Also pending conversation here: https://sfbrigade.slack.com/archives/CEL6C4Q49/p1547185246007700 I would say lets hold off merging a tiny bit as we resolve whether we should use Anaconda or pip/virtual env to manage our environments.
|
See #21 |
|
Happy to move over to Anaconda as we discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements file so that anyone can get started with the repo by pip installing these packages into their virtual environment
I added the current modules for any package used in all files - Excluding standard python 3.6 packages
You can use
pip install -r --upgrade requirements.txtfrom within the base directory to install these packagesPartly addresses issue in #6