Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image urls to tweet #45

Merged
merged 1 commit into from
Feb 7, 2019
Merged

add image urls to tweet #45

merged 1 commit into from
Feb 7, 2019

Conversation

nathanhc
Copy link
Collaborator

1. Brief Summary of what this PR accomplishes (140 characters or less. If you find trouble describing what you are doing in this length, consider breaking the PR into multiple ones.)
Append image urls to the end of tweet if it exists

2. Link to GitHub Issue
#4

3. More detailed description and other questions to address in code review
Add image urls from tweets onto twitter. Other changes are miscellaneous but decided to go forward to not slow down iteration speed

4. Remember to tag reviewers!

@nathanhc nathanhc requested a review from frhino January 31, 2019 05:00
@frhino
Copy link
Collaborator

frhino commented Jan 31, 2019

@nathanhc in comments, please paste a few rows of the updated data file so we can inspect the structure now that image urls are added.

@nathanhc
Copy link
Collaborator Author

nathanhc commented Feb 7, 2019

@nathanhc in comments, please paste a few rows of the updated data file so we can inspect the structure now that image urls are added.

b'@sfenvironment @RecologyWZ @sfmta_muni And this https://t.co/olricrbNuu http://pbs.twimg.com/media/DyNMPdnUwAAJvS_.jpg'

@pahdo pahdo self-requested a review February 7, 2019 08:37
Copy link
Collaborator

@frhino frhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, this closes issue 3, 4, 37, and 46!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants