Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server should verify license number is valid on user registration #60

Closed
francisli opened this issue Mar 17, 2024 · 1 comment · Fixed by #74
Closed

Server should verify license number is valid on user registration #60

francisli opened this issue Mar 17, 2024 · 1 comment · Fixed by #74
Assignees
@javtran

Comments

@francisli
Copy link
Contributor

Let's use the helper that Sammy wrote to ensure that the licenseNumber passed in during user registration is valid/active and store that data in the User object as well.
@francisli
Copy link
Contributor Author

The licenseNumber should be a required field

@javtran javtran mentioned this issue May 28, 2024
Merged
francisli pushed a commit that referenced this issue Jun 5, 2024
@javtran
[Closes #57, Closes #60] User Register endpoint validates input (#74)
bd7f777 
* verify license number on register api

* adjusted user test for licenseNumber verification

* change invite nodemailer test due to inconsistent nodemailer result

* error response added to license for user register

* Validate all fields and able to return compiled list of errors

* fixed and added test to validate other user registration data

* fixed lint issue

* - added citext postgresql extension to prisma for case insensitive email field
- moved zod user schema to user object
- remove repeated parse and used error list directly returned from zod parse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javtran javtran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Closes #60] User Register Endpoint verifies licenseNumber sfbrigade/sf-lifeline
2 participants
@francisli @javtran