Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise functions to use names of $graphAttributes$Nodes$names if no match is found #58

Closed
3 tasks done
sfcheung opened this issue Dec 12, 2020 · 0 comments · Fixed by #61
Closed
3 tasks done

Revise functions to use names of $graphAttributes$Nodes$names if no match is found #58

sfcheung opened this issue Dec 12, 2020 · 0 comments · Fixed by #61
Labels
bug Something isn't working top priority
Milestone
Finalize change_n...

Comments

@sfcheung
Copy link
Owner

sfcheung commented Dec 12, 2020 •
edited
Loading

$graphAttributes$Nodes$names can be changed by change_node_label() and some other functions. The following functions need to be revised such that if no match in node names is found in $graphAttributes$Nodes$names, then the names of this vector will be searched:

  • rotate_resid(). (Already works. Tested in test-change-node.R)
  • set_cfa_layout(). (77d3bd5)
  • set_sem_layout(). (2fb1d0b)
@sfcheung sfcheung added bug Something isn't working 1st - *work on this first* "Top on the top priority" labels Dec 12, 2020
@sfcheung sfcheung mentioned this issue Dec 12, 2020
Closed
marklhc added a commit that referenced this issue Dec 31, 2020
@marklhc
Fix rotate_resid() bug in #58
1b02cbc
marklhc added a commit that referenced this issue Dec 31, 2020
@marklhc
Revision based on #58
3700d63
@sfcheung sfcheung added top priority and removed 1st - *work on this first* "Top on the top priority" labels Jul 27, 2021
@sfcheung sfcheung linked a pull request Aug 2, 2021 that will close this issue
Iss58 #61
Merged
sfcheung added a commit that referenced this issue Aug 2, 2021
@sfcheung
Fix set_cfa_layout for the bug in #58
77d3bd5 
Test passed.
sfcheung added a commit that referenced this issue Aug 2, 2021
@sfcheung
Fix set_sem_layout for the bug in #58
2fb1d0b 
Test passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working top priority
Projects
None yet
Milestone
Finalize change_node_label and push r...
Development

Successfully merging a pull request may close this issue.

Iss58 sfcheung/semptools
1 participant
@sfcheung